Page MenuHomePhabricator

mrexodia (Duncan Ogilvie)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 1 2017, 3:54 PM (136 w, 5 d)

Recent Activity

Sun, Oct 27

mrexodia added a comment to D69433: [clang-format] [NFC] update the documentation in Format.h to allow dump_format_style.py to get a little closer to being correct. (part 2).

I don't really have a say in this, but I was trying to run the python script to generate the rst file and it didn't work. I tried fixing it, but it's definitely very hacky. Perhaps some kind of test can be introduced that runs this python script and checks if it succeeds, so that people are aware that their changes to Format.h break the documentation generation. I also need this to continue with https://reviews.llvm.org/D31635.

Sun, Oct 27, 4:52 AM · Restricted Project, Restricted Project

Oct 7 2019

mrexodia added a comment to D31635: [clang-format] Added ReferenceAlignmentStyle option.

I rebased and added unit tests + and ran clang-format.

Oct 7 2019, 2:49 PM · Restricted Project, Restricted Project, Restricted Project
mrexodia updated the diff for D31635: [clang-format] Added ReferenceAlignmentStyle option.
Oct 7 2019, 2:33 PM · Restricted Project, Restricted Project, Restricted Project

Oct 6 2019

mrexodia added a comment to D31574: [clang-format] update documentation.

Okay I remember what happened now. In the past Allman and Stroustroup had the same documentation (Allman being incorrect), so I updated the documentation for Allman, but by accident I updated the documentation for Stroustroup instead. Anyway I went over the changes and will upload a new diff with the ones that are still relevant today.

Oct 6 2019, 1:18 PM · Restricted Project, Restricted Project, Restricted Project
mrexodia updated the diff for D31574: [clang-format] update documentation.
Oct 6 2019, 1:18 PM · Restricted Project, Restricted Project, Restricted Project
mrexodia added a comment to D31574: [clang-format] update documentation.

If I'm not mistaken the documentation I updated was not for BS_Mozilla, but for BS_Stroustrup. It's been a very long time though so I absolutely don't remember unfortunately.

Oct 6 2019, 12:45 PM · Restricted Project, Restricted Project, Restricted Project

Apr 3 2017

mrexodia updated the summary of D31635: [clang-format] Added ReferenceAlignmentStyle option.
Apr 3 2017, 6:09 PM · Restricted Project, Restricted Project, Restricted Project
mrexodia created D31635: [clang-format] Added ReferenceAlignmentStyle option.
Apr 3 2017, 6:04 PM · Restricted Project, Restricted Project, Restricted Project

Apr 2 2017

mrexodia added a comment to D31574: [clang-format] update documentation.

This file is auto-generated from include/clang/format/Format.h. Changes need to be made there and then this files needs to be regenerated with docs/tools/dump_format_style.py. Sorry, we probably need to make that more obvious.

Apr 2 2017, 4:58 PM · Restricted Project, Restricted Project, Restricted Project
mrexodia updated the diff for D31574: [clang-format] update documentation.
Apr 2 2017, 4:58 PM · Restricted Project, Restricted Project, Restricted Project

Apr 1 2017

mrexodia updated the diff for D31574: [clang-format] update documentation.
Apr 1 2017, 4:56 PM · Restricted Project, Restricted Project, Restricted Project
mrexodia created D31574: [clang-format] update documentation.
Apr 1 2017, 4:53 PM · Restricted Project, Restricted Project, Restricted Project