Page MenuHomePhabricator

mmpozulp (Mike Pozulp)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 24 2019, 11:46 PM (24 w, 6 d)

Recent Activity

Sep 13 2019

mmpozulp committed rGc45fd0cad428: [llvm-objcopy] Add support for response files in llvm-strip and llvm-objcopy (authored by mmpozulp).
[llvm-objcopy] Add support for response files in llvm-strip and llvm-objcopy
Sep 13 2019, 6:15 PM
mmpozulp updated the diff for D65372: [llvm-objcopy] Add support for response files in llvm-strip and llvm-objcopy.

Incorporate feedback from @jhenderson and @rupprecht

Sep 13 2019, 4:27 PM · Restricted Project

Sep 11 2019

mmpozulp added a comment to D65372: [llvm-objcopy] Add support for response files in llvm-strip and llvm-objcopy.

Ping

Sep 11 2019, 10:57 PM · Restricted Project

Aug 14 2019

mmpozulp committed rG9abf668c08b0: [llvm-objdump] Add warning messages if disassembly + source for problematic… (authored by mmpozulp).
[llvm-objdump] Add warning messages if disassembly + source for problematic…
Aug 14 2019, 10:18 PM
mmpozulp added a comment to D62462: [llvm-objdump] Add warning messages if disassembly + source for problematic inputs.

@mmpozulp, can I confirm that this is now in? It looks like Phabricator hasn't auto-closed this issue.

Aug 14 2019, 10:18 PM · Restricted Project
mmpozulp added a comment to D65991: [llvm-objcopy] Move duplicate tablegen from objcopy and strip into one file.

Copied from llvm/tools/llvm-objcopy/StripOpts.td

Phabricator is smart?

I think it's to do with how the patch is written. I'm not sure though :/

Aug 14 2019, 10:00 PM · Restricted Project
mmpozulp committed rG9cf1eab73e23: [llvm-objcopy] Move duplicate tablegen from objcopy and strip into one file (authored by mmpozulp).
[llvm-objcopy] Move duplicate tablegen from objcopy and strip into one file
Aug 14 2019, 9:47 PM

Aug 9 2019

mmpozulp updated the diff for D65372: [llvm-objcopy] Add support for response files in llvm-strip and llvm-objcopy.

Rebaseline to get the new llvm-strip.rst docs page.
Incorporate feedback from @jhenderson to

  1. Click "Done" boxes in phabricator. Thanks :)
  2. Add @FILE check to help-message.test
  3. Update llvm-strip.rst and llvm-objcopy.rst docs with @FILE option.
  4. Remove the header re-ordering. I like it the way it was before.
  5. Change response-file.test to a) use llvm-readobj to check sections,

and b) run cmp to show the output files are identical.
TODO: Try refactoring tools which call cl::ExpandResponseFiles to
avoid copy-pasting code from lib/Support/CommandLine.cpp like I did here.

Aug 9 2019, 1:23 PM · Restricted Project
mmpozulp committed rG3de981313c9b: [Docs][llvm-strip] Fix an indentation issue. (authored by mmpozulp).
[Docs][llvm-strip] Fix an indentation issue.
Aug 9 2019, 12:43 PM
mmpozulp updated the diff for D65991: [llvm-objcopy] Move duplicate tablegen from objcopy and strip into one file.

Delete CommonAliases.td by incorporating feedback from @jhenderson.

Aug 9 2019, 12:34 PM · Restricted Project
mmpozulp committed rG4fe911d9dd37: [Docs][llvm-strip] Add help text to llvm-strip rst doc (authored by mmpozulp).
[Docs][llvm-strip] Add help text to llvm-strip rst doc
Aug 9 2019, 12:11 PM

Aug 8 2019

mmpozulp added inline comments to D65372: [llvm-objcopy] Add support for response files in llvm-strip and llvm-objcopy.
Aug 8 2019, 10:32 PM · Restricted Project
mmpozulp updated the diff for D65372: [llvm-objcopy] Add support for response files in llvm-strip and llvm-objcopy.

Capitalize variable newArgv -> NewArgv

Aug 8 2019, 10:19 PM · Restricted Project
mmpozulp updated the diff for D65372: [llvm-objcopy] Add support for response files in llvm-strip and llvm-objcopy.

Incorporate feedback from @jhenderson. I still need to try refactoring tools which call cl::ExpandResponseFiles to avoid code duplication. If successful then we won't have to continue the code duplication trend here.

Aug 8 2019, 10:14 PM · Restricted Project
mmpozulp updated the summary of D65991: [llvm-objcopy] Move duplicate tablegen from objcopy and strip into one file.
Aug 8 2019, 8:09 PM · Restricted Project
mmpozulp updated the diff for D65991: [llvm-objcopy] Move duplicate tablegen from objcopy and strip into one file.

Rebase on master to get commit from @wolfgangp which added --strip-sections
to llvm-strip. Move it into CommonOpts.td since llvm-objcopy supports it to.

Aug 8 2019, 8:07 PM · Restricted Project
mmpozulp added a comment to D65384: [Docs][llvm-strip] Add help text to llvm-strip rst doc.

Also, I moved the tablegen changes to https://reviews.llvm.org/D65991

Aug 8 2019, 7:57 PM · Restricted Project
mmpozulp updated the diff for D65384: [Docs][llvm-strip] Add help text to llvm-strip rst doc.

Incorporate feedback from @jhenderson.
Add new switch --strip-sections. Thanks, James.

Aug 8 2019, 7:55 PM · Restricted Project
mmpozulp created D65991: [llvm-objcopy] Move duplicate tablegen from objcopy and strip into one file.
Aug 8 2019, 7:35 PM · Restricted Project
mmpozulp added a comment to D62462: [llvm-objdump] Add warning messages if disassembly + source for problematic inputs.

Thanks, @grimar and @jhenderson. I feel ready for another re-commit. Think so too?

Aug 8 2019, 7:18 PM · Restricted Project
mmpozulp updated the diff for D62462: [llvm-objdump] Add warning messages if disassembly + source for problematic inputs.

Use {{.*}}2.o rather than {{.+}}

Aug 8 2019, 7:15 PM · Restricted Project

Aug 5 2019

mmpozulp updated the diff for D65384: [Docs][llvm-strip] Add help text to llvm-strip rst doc.

Incorporate feedback from @jhenderson.

Aug 5 2019, 4:03 AM · Restricted Project
mmpozulp added a comment to D65734: [llvm-objdump] Quote filename to fix windows test failure.

Ok thanks for the explanations @jhenderson and @dyung. I abandoned my attempt to use [[FILE]] in the tests. See https://reviews.llvm.org/D62462.

Aug 5 2019, 3:27 AM · Restricted Project
mmpozulp updated the diff for D62462: [llvm-objdump] Add warning messages if disassembly + source for problematic inputs.

Abandon [[FILE]] use in tests.
@grimar please try this on your windows box.

Aug 5 2019, 3:27 AM · Restricted Project
mmpozulp abandoned D65734: [llvm-objdump] Quote filename to fix windows test failure.

@grimar I reverted the commit, re-opened the original revision, and updated it with the '[[FILE]]' change. I'd love if you could test it on windows for me! Please use https://reviews.llvm.org/D62462.

Aug 5 2019, 2:04 AM · Restricted Project
mmpozulp updated the diff for D62462: [llvm-objdump] Add warning messages if disassembly + source for problematic inputs.

Add single quotes so [[FILE]] is now '[[FILE]]'.
@grimar can you see if this fixes the windows failures?

Aug 5 2019, 2:00 AM · Restricted Project
mmpozulp committed rG3046ef5c1101: Revert "[llvm-objdump] Re-commit r367284." (authored by mmpozulp).
Revert "[llvm-objdump] Re-commit r367284."
Aug 5 2019, 1:58 AM
mmpozulp reopened D62462: [llvm-objdump] Add warning messages if disassembly + source for problematic inputs.

Reverted in r367816 because the modified tests failed on windows http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/27368

Aug 5 2019, 1:57 AM · Restricted Project

Aug 4 2019

mmpozulp added a comment to D65734: [llvm-objdump] Quote filename to fix windows test failure.

@dyung @jhenderson do either of you know how I can test this on windows without having my own windows machine? It passes on my linux box but that's not where the failure was. Thanks :)

Aug 4 2019, 10:22 PM · Restricted Project
mmpozulp created D65734: [llvm-objdump] Quote filename to fix windows test failure.
Aug 4 2019, 10:08 PM · Restricted Project

Aug 3 2019

mmpozulp committed rGd34099926e90: [llvm-objdump] Re-commit r367284. (authored by mmpozulp).
[llvm-objdump] Re-commit r367284.
Aug 3 2019, 11:04 PM
mmpozulp updated the diff for D62462: [llvm-objdump] Add warning messages if disassembly + source for problematic inputs.

Replacing svn diff with git diff.

Aug 3 2019, 10:50 PM · Restricted Project

Jul 30 2019

mmpozulp committed rG074db9b8e97a: Revert "[llvm-objdump] Add warning messages if disassembly + source for… (authored by mmpozulp).
Revert "[llvm-objdump] Add warning messages if disassembly + source for…
Jul 30 2019, 12:10 AM
mmpozulp reopened D62462: [llvm-objdump] Add warning messages if disassembly + source for problematic inputs.

Reverted after the buildbots informed me that I caused a test to fail
http://lab.llvm.org:8011/builders/clang-ppc64be-linux-lnt/builds/29488

Jul 30 2019, 12:10 AM · Restricted Project

Jul 29 2019

mmpozulp added a comment to D65384: [Docs][llvm-strip] Add help text to llvm-strip rst doc.

Thanks for working on this! You're missing a number of aliases from the list. Please make sure they are included in the doc.

Jul 29 2019, 11:01 PM · Restricted Project
mmpozulp added a comment to D65374: [llvm-nm] Use same symbol types as gnu nm when --format=sysv.

Hi @mmpozulp. Thanks for looking at this. One of my colleagues (@Sunil_Srivastava) has been working on the same fix, but we forgot to update the LLVM bug. His approach also solves a bug in llvm-readelf, so would you mind holding off on this patch until he's got a chance to finish off his version ready for review?

Jul 29 2019, 10:52 PM · Restricted Project
mmpozulp committed rGb1cbe51bdf44: [llvm-objdump] Add warning messages if disassembly + source for problematic… (authored by mmpozulp).
[llvm-objdump] Add warning messages if disassembly + source for problematic…
Jul 29 2019, 10:30 PM

Jul 28 2019

mmpozulp created D65384: [Docs][llvm-strip] Add help text to llvm-strip rst doc.
Jul 28 2019, 5:54 PM · Restricted Project
mmpozulp added a comment to D65374: [llvm-nm] Use same symbol types as gnu nm when --format=sysv.

Should we match gnu nm exactly or is this enough?
If we check all 16 possible bit-patterns of the 4-bit-wide symbol type (as in format-sysv-type.test) we can see that gnu nm prints the symbol_section and symbol_common symbols differently than we do. See (4) below for the differences.

Jul 28 2019, 12:33 AM · Restricted Project
mmpozulp created D65374: [llvm-nm] Use same symbol types as gnu nm when --format=sysv.
Jul 28 2019, 12:18 AM · Restricted Project

Jul 27 2019

mmpozulp added inline comments to D65372: [llvm-objcopy] Add support for response files in llvm-strip and llvm-objcopy.
Jul 27 2019, 6:14 PM · Restricted Project
Herald added a reviewer for D65372: [llvm-objcopy] Add support for response files in llvm-strip and llvm-objcopy: alexshap.
Jul 27 2019, 6:02 PM · Restricted Project
mmpozulp updated the diff for D62462: [llvm-objdump] Add warning messages if disassembly + source for problematic inputs.

Run git-clang-format

Jul 27 2019, 10:39 AM · Restricted Project

Jul 26 2019

mmpozulp added a comment to D62462: [llvm-objdump] Add warning messages if disassembly + source for problematic inputs.

Thanks James. I was able to induce an error by modifying SymbolizableObjectFile::create to unconditionally return object_error::unexpected_eof which produced

./bin/llvm-objdump: warning: failed to parse debug information for tmp2.o: The end of the file was unexpectedly encountered
Jul 26 2019, 8:08 PM · Restricted Project
mmpozulp updated the diff for D62462: [llvm-objdump] Add warning messages if disassembly + source for problematic inputs.

Use error message from Symbolizer->symbolizeCode() in "failed to parse debug information" warning

Jul 26 2019, 8:07 PM · Restricted Project

Jul 21 2019

mmpozulp added a comment to D62462: [llvm-objdump] Add warning messages if disassembly + source for problematic inputs.

@jhenderson, can you think of an input that would cause Symbolizer->symbolizeCode(*Obj, Address) to return an Error?

Jul 21 2019, 10:01 PM · Restricted Project

Jul 18 2019

mmpozulp added a comment to D62462: [llvm-objdump] Add warning messages if disassembly + source for problematic inputs.

@jhenderson thanks for clarifying. I'll take a look and see what I can find.

Jul 18 2019, 12:23 PM · Restricted Project

Jul 14 2019

mmpozulp added a comment to D62462: [llvm-objdump] Add warning messages if disassembly + source for problematic inputs.

@jhenderson thanks so much for the feedback. Anything else?

Jul 14 2019, 11:30 PM · Restricted Project
mmpozulp added inline comments to D62462: [llvm-objdump] Add warning messages if disassembly + source for problematic inputs.
Jul 14 2019, 11:25 PM · Restricted Project
mmpozulp updated the diff for D62462: [llvm-objdump] Add warning messages if disassembly + source for problematic inputs.

Use original wording of "failed to parse..."

Jul 14 2019, 10:33 PM · Restricted Project

Jul 12 2019

mmpozulp updated the diff for D62462: [llvm-objdump] Add warning messages if disassembly + source for problematic inputs.

Emit object file name in warning message. Duh. Thanks, @jhenderson!

Jul 12 2019, 12:44 AM · Restricted Project

Jul 10 2019

mmpozulp added inline comments to D62462: [llvm-objdump] Add warning messages if disassembly + source for problematic inputs.
Jul 10 2019, 10:35 PM · Restricted Project
mmpozulp updated the diff for D62462: [llvm-objdump] Add warning messages if disassembly + source for problematic inputs.

Incorporate feedback from @jhenderson

Jul 10 2019, 10:25 PM · Restricted Project

Jul 9 2019

mmpozulp added inline comments to D62462: [llvm-objdump] Add warning messages if disassembly + source for problematic inputs.
Jul 9 2019, 11:04 PM · Restricted Project
mmpozulp updated the diff for D62462: [llvm-objdump] Add warning messages if disassembly + source for problematic inputs.

Change global variable names, update warning message, delete extra newline.

Jul 9 2019, 10:41 PM · Restricted Project
mmpozulp updated the diff for D62462: [llvm-objdump] Add warning messages if disassembly + source for problematic inputs.

Rebase on master

Jul 9 2019, 9:29 PM · Restricted Project

Jul 3 2019

mmpozulp added a comment to D62462: [llvm-objdump] Add warning messages if disassembly + source for problematic inputs.

Taking off on a camping trip for the week. If anyone wants these features upstream'd before I get back please feel free to pick up where I left off, otherwise I'll be back at next week. :)

Jul 3 2019, 1:27 AM · Restricted Project

Jun 29 2019

mmpozulp updated the diff for D62462: [llvm-objdump] Add warning messages if disassembly + source for problematic inputs.

Rebase on master

Jun 29 2019, 6:10 PM · Restricted Project

Jun 24 2019

mmpozulp added a comment to D62462: [llvm-objdump] Add warning messages if disassembly + source for problematic inputs.

Hey @jhenderson, thanks for asking! I will have some questions for you once I look at the code again. I return from vacation on Wednesday. :)

Jun 24 2019, 10:51 AM · Restricted Project

Jun 10 2019

mmpozulp updated the diff for D62462: [llvm-objdump] Add warning messages if disassembly + source for problematic inputs.

Incorporate excellent feedback from @grimar and @jhenderson. Thanks!

Jun 10 2019, 5:29 PM · Restricted Project

Jun 7 2019

mmpozulp committed rGc3c18f4a0dc6: [llvm-objdump] Add warning if --disassemble-functions specifies an unknown… (authored by mmpozulp).
[llvm-objdump] Add warning if --disassemble-functions specifies an unknown…
Jun 7 2019, 1:33 PM
mmpozulp added a comment to D62275: [llvm-objdump] Add warning if --disassemble-functions specifies an unknown symbol.

Committed as r362838.

Jun 7 2019, 1:32 PM · Restricted Project
mmpozulp updated the summary of D62275: [llvm-objdump] Add warning if --disassemble-functions specifies an unknown symbol.
Jun 7 2019, 1:32 PM · Restricted Project
mmpozulp closed D63000: [ADT] Fix asan-detected stack-buffer-overflow in StringSetTest.cpp.

I applied this revision on top of D62369.

Jun 7 2019, 1:28 PM · Restricted Project
mmpozulp reopened D62275: [llvm-objdump] Add warning if --disassemble-functions specifies an unknown symbol.
Jun 7 2019, 1:28 PM · Restricted Project
mmpozulp committed rG31650eaa0242: [ADT] Enable set_difference() to be used on StringSet (authored by mmpozulp).
[ADT] Enable set_difference() to be used on StringSet
Jun 7 2019, 1:24 PM
mmpozulp added a comment to D62369: [ADT] Enable set_difference() to be used on StringSet.

Committed as r362835.

Jun 7 2019, 1:24 PM · Restricted Project
mmpozulp updated the summary of D62369: [ADT] Enable set_difference() to be used on StringSet.
Jun 7 2019, 1:17 PM · Restricted Project
mmpozulp updated the diff for D62369: [ADT] Enable set_difference() to be used on StringSet.

Fix asan-detected stack-buffer-overflow in StringSetTest.cpp

Jun 7 2019, 1:10 PM · Restricted Project
mmpozulp added a comment to D62369: [ADT] Enable set_difference() to be used on StringSet.

@dblaikie approved the stack-buffer-overflow fix (see https://reviews.llvm.org/D63000) which I have applied here, so I'm going to re-land this patch :)

Jun 7 2019, 1:10 PM · Restricted Project
mmpozulp reopened D62369: [ADT] Enable set_difference() to be used on StringSet.
Jun 7 2019, 12:50 PM · Restricted Project
mmpozulp added a comment to D63000: [ADT] Fix asan-detected stack-buffer-overflow in StringSetTest.cpp.

This fixes the build error discovered by the asan buildbot

FAIL: LLVM-Unit :: ADT/./ADTTests/StringSetTest.InsertAndCountStringMapEntry (1017 of 31700)
******************** TEST 'LLVM-Unit :: ADT/./ADTTests/StringSetTest.InsertAndCountStringMapEntry' FAILED ********************
Note: Google Test filter = StringSetTest.InsertAndCountStringMapEntry
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from StringSetTest
[ RUN      ] StringSetTest.InsertAndCountStringMapEntry
=================================================================
==10147==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7fc65d1d0738 at pc 0x0000013db225 bp 0x7ffd223d3200 sp 0x7ffd223d31f8
READ of size 1 at 0x7fc65d1d0738 thread T0
    #0 0x13db224 in djbHash /b/sanitizer-x86_64-linux-fast/build/llvm/include/llvm/Support/DJB.h:22:24
    #1 0x13db224 in llvm::StringMapImpl::LookupBucketFor(llvm::StringRef) /b/sanitizer-x86_64-linux-fast/build/llvm/lib/Support/StringMap.cpp:83
    #2 0x11e5d81 in std::__1::pair<llvm::StringMapIterator<char>, bool> llvm::StringMap<char, llvm::MallocAllocator>::try_emplace<char>(llvm::StringRef, char&&) /b/sanitizer-x86_64-linux-fast/build/llvm/include/llvm/ADT/StringMap.h:400:25
    #3 0x11e6360 in insert /b/sanitizer-x86_64-linux-fast/build/llvm/include/llvm/ADT/StringMap.h:391:12
    #4 0x11e6360 in insert /b/sanitizer-x86_64-linux-fast/build/llvm/include/llvm/ADT/StringSet.h:40
    #5 0x11e6360 in insert<llvm::StringRef> /b/sanitizer-x86_64-linux-fast/build/llvm/include/llvm/ADT/StringSet.h:52
    #6 0x11e6360 in (anonymous namespace)::StringSetTest_InsertAndCountStringMapEntry_Test::TestBody() /b/sanitizer-x86_64-linux-fast/build/llvm/unittests/ADT/StringSetTest.cpp:37
    #7 0x1470290 in HandleExceptionsInMethodIfSupported<testing::Test, void> /b/sanitizer-x86_64-linux-fast/build/llvm/utils/unittest/googletest/src/gtest.cc
    #8 0x1470290 in testing::Test::Run() /b/sanitizer-x86_64-linux-fast/build/llvm/utils/unittest/googletest/src/gtest.cc:2474
    #9 0x1472845 in testing::TestInfo::Run() /b/sanitizer-x86_64-linux-fast/build/llvm/utils/unittest/googletest/src/gtest.cc:2656:11
    #10 0x1473cc0 in testing::TestCase::Run() /b/sanitizer-x86_64-linux-fast/build/llvm/utils/unittest/googletest/src/gtest.cc:2774:28
    #11 0x14927ad in testing::internal::UnitTestImpl::RunAllTests() /b/sanitizer-x86_64-linux-fast/build/llvm/utils/unittest/googletest/src/gtest.cc:4649:43
    #12 0x1491960 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> /b/sanitizer-x86_64-linux-fast/build/llvm/utils/unittest/googletest/src/gtest.cc
    #13 0x1491960 in testing::UnitTest::Run() /b/sanitizer-x86_64-linux-fast/build/llvm/utils/unittest/googletest/src/gtest.cc:4257
    #14 0x1454700 in RUN_ALL_TESTS /b/sanitizer-x86_64-linux-fast/build/llvm/utils/unittest/googletest/include/gtest/gtest.h:2233:46
    #15 0x1454700 in main /b/sanitizer-x86_64-linux-fast/build/llvm/utils/unittest/UnitTestMain/TestMain.cpp:50
    #16 0x7fc66053c2e0 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x202e0)
    #17 0x5daf89 in _start (/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan/unittests/ADT/ADTTests+0x5daf89)
Jun 7 2019, 2:14 AM · Restricted Project
mmpozulp created D63000: [ADT] Fix asan-detected stack-buffer-overflow in StringSetTest.cpp.
Jun 7 2019, 2:08 AM · Restricted Project

Jun 6 2019

mmpozulp committed rG65d1ff8e7e2d: [NFC] Delete trailing whitespace character. (authored by mmpozulp).
[NFC] Delete trailing whitespace character.
Jun 6 2019, 11:30 PM
mmpozulp added a comment to D62461: [llvm-objdump] Print source when subsequent lines in the translation unit come from the same line in two different headers..

Committed as r362771.

Jun 6 2019, 11:30 PM · Restricted Project
mmpozulp committed rG767bdd55e1a0: [llvm-objdump] Print source when subsequent lines in the translation unit come… (authored by mmpozulp).
[llvm-objdump] Print source when subsequent lines in the translation unit come…
Jun 6 2019, 11:22 PM
mmpozulp updated the diff for D62461: [llvm-objdump] Print source when subsequent lines in the translation unit come from the same line in two different headers..

Incorporate feedback from @jhenderson to change 'headers' to 'files' in test description.

Jun 6 2019, 11:00 PM · Restricted Project
mmpozulp added a comment to D62275: [llvm-objdump] Add warning if --disassemble-functions specifies an unknown symbol.

Committed as r362768. Thanks!

Jun 6 2019, 10:16 PM · Restricted Project
mmpozulp committed rG50f61af3f304: [llvm-objdump] Add warning if --disassemble-functions specifies an unknown… (authored by mmpozulp).
[llvm-objdump] Add warning if --disassemble-functions specifies an unknown…
Jun 6 2019, 10:12 PM
mmpozulp closed D62275: [llvm-objdump] Add warning if --disassemble-functions specifies an unknown symbol.
Jun 6 2019, 10:12 PM · Restricted Project
mmpozulp updated the diff for D62275: [llvm-objdump] Add warning if --disassemble-functions specifies an unknown symbol.

Incorporate feedback from @MaskRay to delete redundant if-statement.

Jun 6 2019, 9:22 PM · Restricted Project
mmpozulp removed a child revision for D62369: [ADT] Enable set_difference() to be used on StringSet: D62275: [llvm-objdump] Add warning if --disassemble-functions specifies an unknown symbol.
Jun 6 2019, 9:09 PM · Restricted Project
mmpozulp removed a parent revision for D62275: [llvm-objdump] Add warning if --disassemble-functions specifies an unknown symbol: D62369: [ADT] Enable set_difference() to be used on StringSet.
Jun 6 2019, 9:09 PM · Restricted Project
mmpozulp closed D62369: [ADT] Enable set_difference() to be used on StringSet.

I committed as r362766. Thanks!

Jun 6 2019, 8:41 PM · Restricted Project
mmpozulp added a comment to D62992: [ADT] Enable set_difference() to be used on StringSet.

Please see https://reviews.llvm.org/D62369 which is the revision that I meant to update. Instead I created this new revision by accident.

Jun 6 2019, 8:41 PM · Restricted Project
mmpozulp reopened D62369: [ADT] Enable set_difference() to be used on StringSet.
Jun 6 2019, 8:39 PM · Restricted Project
mmpozulp closed D62369: [ADT] Enable set_difference() to be used on StringSet.
Jun 6 2019, 8:37 PM · Restricted Project
mmpozulp committed rG0bddef79019a: [ADT] Enable set_difference() to be used on StringSet (authored by mmpozulp).
[ADT] Enable set_difference() to be used on StringSet
Jun 6 2019, 8:23 PM
mmpozulp updated the diff for D62369: [ADT] Enable set_difference() to be used on StringSet.

Delete unused header in StringSetTest.cpp.

Jun 6 2019, 8:09 PM · Restricted Project
mmpozulp added a comment to D62992: [ADT] Enable set_difference() to be used on StringSet.

I meant to run arc diff --update D62369 but I ran arc diff instead, oops! Please ignore this revision.

Jun 6 2019, 8:09 PM · Restricted Project
mmpozulp abandoned D62992: [ADT] Enable set_difference() to be used on StringSet.
Jun 6 2019, 8:06 PM · Restricted Project
mmpozulp created D62992: [ADT] Enable set_difference() to be used on StringSet.
Jun 6 2019, 8:06 PM · Restricted Project
mmpozulp committed rGc7029e4ef468: [NFC] Test commit. (authored by mmpozulp).
[NFC] Test commit.
Jun 6 2019, 6:54 PM
mmpozulp updated subscribers of D62369: [ADT] Enable set_difference() to be used on StringSet.

Good news! Apparently I can commit from git (https://llvm.org/docs/GettingStarted.html#for-developers-to-commit-changes-from-git). Thank you, @smeenai!!! I should be able to land this commit soon. Good-bye svn :)

Jun 6 2019, 5:25 PM · Restricted Project
mmpozulp added a comment to D62461: [llvm-objdump] Print source when subsequent lines in the translation unit come from the same line in two different headers..

Will do. Sorry for the delay, I'm fighting with svn. See my comment in https://reviews.llvm.org/D62369.

Jun 6 2019, 5:09 PM · Restricted Project
mmpozulp added a comment to D62275: [llvm-objdump] Add warning if --disassemble-functions specifies an unknown symbol.

I'm fighting with svn. See my comment in https://reviews.llvm.org/D62369.

Jun 6 2019, 5:09 PM · Restricted Project
mmpozulp added a comment to D62369: [ADT] Enable set_difference() to be used on StringSet.

I'm fighting with svn. I ran svn co https://user@llvm.org/svn/llvm-project/llvm/trunk llvm which took about 90 minutes to checkout the repo. If I run svn up it hangs for ~10 minutes on a poll() call (which I discovered by running strace) then emits an error

Jun 6 2019, 5:03 PM · Restricted Project

May 29 2019

mmpozulp updated the diff for D62462: [llvm-objdump] Add warning messages if disassembly + source for problematic inputs.

Incorporate feedback from @grimar to simplify an if-statement.

May 29 2019, 4:21 PM · Restricted Project
mmpozulp added inline comments to D62462: [llvm-objdump] Add warning messages if disassembly + source for problematic inputs.
May 29 2019, 4:12 PM · Restricted Project
mmpozulp added a comment to D62461: [llvm-objdump] Print source when subsequent lines in the translation unit come from the same line in two different headers..

This LGTM. But please hold this on until anyone else take a look too.

May 29 2019, 3:39 PM · Restricted Project