Page MenuHomePhabricator

mmpozulp (Mike Pozulp)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 24 2019, 11:46 PM (8 w, 5 h)

Recent Activity

Mon, Jun 10

mmpozulp updated the diff for D62462: [llvm-objdump] Add warning messages if disassembly + source for problematic inputs.

Incorporate excellent feedback from @grimar and @jhenderson. Thanks!

Mon, Jun 10, 5:29 PM · Restricted Project

Fri, Jun 7

mmpozulp committed rGc3c18f4a0dc6: [llvm-objdump] Add warning if --disassemble-functions specifies an unknown… (authored by mmpozulp).
[llvm-objdump] Add warning if --disassemble-functions specifies an unknown…
Fri, Jun 7, 1:33 PM
mmpozulp added a comment to D62275: [llvm-objdump] Add warning if --disassemble-functions specifies an unknown symbol.

Committed as r362838.

Fri, Jun 7, 1:32 PM · Restricted Project
mmpozulp updated the summary of D62275: [llvm-objdump] Add warning if --disassemble-functions specifies an unknown symbol.
Fri, Jun 7, 1:32 PM · Restricted Project
mmpozulp closed D63000: [ADT] Fix asan-detected stack-buffer-overflow in StringSetTest.cpp.

I applied this revision on top of D62369.

Fri, Jun 7, 1:28 PM · Restricted Project
mmpozulp reopened D62275: [llvm-objdump] Add warning if --disassemble-functions specifies an unknown symbol.
Fri, Jun 7, 1:28 PM · Restricted Project
mmpozulp committed rG31650eaa0242: [ADT] Enable set_difference() to be used on StringSet (authored by mmpozulp).
[ADT] Enable set_difference() to be used on StringSet
Fri, Jun 7, 1:24 PM
mmpozulp added a comment to D62369: [ADT] Enable set_difference() to be used on StringSet.

Committed as r362835.

Fri, Jun 7, 1:24 PM · Restricted Project
mmpozulp updated the summary of D62369: [ADT] Enable set_difference() to be used on StringSet.
Fri, Jun 7, 1:17 PM · Restricted Project
mmpozulp updated the diff for D62369: [ADT] Enable set_difference() to be used on StringSet.

Fix asan-detected stack-buffer-overflow in StringSetTest.cpp

Fri, Jun 7, 1:10 PM · Restricted Project
mmpozulp added a comment to D62369: [ADT] Enable set_difference() to be used on StringSet.

@dblaikie approved the stack-buffer-overflow fix (see https://reviews.llvm.org/D63000) which I have applied here, so I'm going to re-land this patch :)

Fri, Jun 7, 1:10 PM · Restricted Project
mmpozulp reopened D62369: [ADT] Enable set_difference() to be used on StringSet.
Fri, Jun 7, 12:50 PM · Restricted Project
mmpozulp added a comment to D63000: [ADT] Fix asan-detected stack-buffer-overflow in StringSetTest.cpp.

This fixes the build error discovered by the asan buildbot

FAIL: LLVM-Unit :: ADT/./ADTTests/StringSetTest.InsertAndCountStringMapEntry (1017 of 31700)
******************** TEST 'LLVM-Unit :: ADT/./ADTTests/StringSetTest.InsertAndCountStringMapEntry' FAILED ********************
Note: Google Test filter = StringSetTest.InsertAndCountStringMapEntry
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from StringSetTest
[ RUN      ] StringSetTest.InsertAndCountStringMapEntry
=================================================================
==10147==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7fc65d1d0738 at pc 0x0000013db225 bp 0x7ffd223d3200 sp 0x7ffd223d31f8
READ of size 1 at 0x7fc65d1d0738 thread T0
    #0 0x13db224 in djbHash /b/sanitizer-x86_64-linux-fast/build/llvm/include/llvm/Support/DJB.h:22:24
    #1 0x13db224 in llvm::StringMapImpl::LookupBucketFor(llvm::StringRef) /b/sanitizer-x86_64-linux-fast/build/llvm/lib/Support/StringMap.cpp:83
    #2 0x11e5d81 in std::__1::pair<llvm::StringMapIterator<char>, bool> llvm::StringMap<char, llvm::MallocAllocator>::try_emplace<char>(llvm::StringRef, char&&) /b/sanitizer-x86_64-linux-fast/build/llvm/include/llvm/ADT/StringMap.h:400:25
    #3 0x11e6360 in insert /b/sanitizer-x86_64-linux-fast/build/llvm/include/llvm/ADT/StringMap.h:391:12
    #4 0x11e6360 in insert /b/sanitizer-x86_64-linux-fast/build/llvm/include/llvm/ADT/StringSet.h:40
    #5 0x11e6360 in insert<llvm::StringRef> /b/sanitizer-x86_64-linux-fast/build/llvm/include/llvm/ADT/StringSet.h:52
    #6 0x11e6360 in (anonymous namespace)::StringSetTest_InsertAndCountStringMapEntry_Test::TestBody() /b/sanitizer-x86_64-linux-fast/build/llvm/unittests/ADT/StringSetTest.cpp:37
    #7 0x1470290 in HandleExceptionsInMethodIfSupported<testing::Test, void> /b/sanitizer-x86_64-linux-fast/build/llvm/utils/unittest/googletest/src/gtest.cc
    #8 0x1470290 in testing::Test::Run() /b/sanitizer-x86_64-linux-fast/build/llvm/utils/unittest/googletest/src/gtest.cc:2474
    #9 0x1472845 in testing::TestInfo::Run() /b/sanitizer-x86_64-linux-fast/build/llvm/utils/unittest/googletest/src/gtest.cc:2656:11
    #10 0x1473cc0 in testing::TestCase::Run() /b/sanitizer-x86_64-linux-fast/build/llvm/utils/unittest/googletest/src/gtest.cc:2774:28
    #11 0x14927ad in testing::internal::UnitTestImpl::RunAllTests() /b/sanitizer-x86_64-linux-fast/build/llvm/utils/unittest/googletest/src/gtest.cc:4649:43
    #12 0x1491960 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> /b/sanitizer-x86_64-linux-fast/build/llvm/utils/unittest/googletest/src/gtest.cc
    #13 0x1491960 in testing::UnitTest::Run() /b/sanitizer-x86_64-linux-fast/build/llvm/utils/unittest/googletest/src/gtest.cc:4257
    #14 0x1454700 in RUN_ALL_TESTS /b/sanitizer-x86_64-linux-fast/build/llvm/utils/unittest/googletest/include/gtest/gtest.h:2233:46
    #15 0x1454700 in main /b/sanitizer-x86_64-linux-fast/build/llvm/utils/unittest/UnitTestMain/TestMain.cpp:50
    #16 0x7fc66053c2e0 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x202e0)
    #17 0x5daf89 in _start (/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan/unittests/ADT/ADTTests+0x5daf89)
Fri, Jun 7, 2:14 AM · Restricted Project
mmpozulp created D63000: [ADT] Fix asan-detected stack-buffer-overflow in StringSetTest.cpp.
Fri, Jun 7, 2:08 AM · Restricted Project

Thu, Jun 6

mmpozulp committed rG65d1ff8e7e2d: [NFC] Delete trailing whitespace character. (authored by mmpozulp).
[NFC] Delete trailing whitespace character.
Thu, Jun 6, 11:30 PM
mmpozulp added a comment to D62461: [llvm-objdump] Print source when subsequent lines in the translation unit come from the same line in two different headers..

Committed as r362771.

Thu, Jun 6, 11:30 PM · Restricted Project
mmpozulp committed rG767bdd55e1a0: [llvm-objdump] Print source when subsequent lines in the translation unit come… (authored by mmpozulp).
[llvm-objdump] Print source when subsequent lines in the translation unit come…
Thu, Jun 6, 11:22 PM
mmpozulp updated the diff for D62461: [llvm-objdump] Print source when subsequent lines in the translation unit come from the same line in two different headers..

Incorporate feedback from @jhenderson to change 'headers' to 'files' in test description.

Thu, Jun 6, 11:00 PM · Restricted Project
mmpozulp added a comment to D62275: [llvm-objdump] Add warning if --disassemble-functions specifies an unknown symbol.

Committed as r362768. Thanks!

Thu, Jun 6, 10:16 PM · Restricted Project
mmpozulp committed rG50f61af3f304: [llvm-objdump] Add warning if --disassemble-functions specifies an unknown… (authored by mmpozulp).
[llvm-objdump] Add warning if --disassemble-functions specifies an unknown…
Thu, Jun 6, 10:12 PM
mmpozulp closed D62275: [llvm-objdump] Add warning if --disassemble-functions specifies an unknown symbol.
Thu, Jun 6, 10:12 PM · Restricted Project
mmpozulp updated the diff for D62275: [llvm-objdump] Add warning if --disassemble-functions specifies an unknown symbol.

Incorporate feedback from @MaskRay to delete redundant if-statement.

Thu, Jun 6, 9:22 PM · Restricted Project
mmpozulp removed a child revision for D62369: [ADT] Enable set_difference() to be used on StringSet: D62275: [llvm-objdump] Add warning if --disassemble-functions specifies an unknown symbol.
Thu, Jun 6, 9:09 PM · Restricted Project
mmpozulp removed a parent revision for D62275: [llvm-objdump] Add warning if --disassemble-functions specifies an unknown symbol: D62369: [ADT] Enable set_difference() to be used on StringSet.
Thu, Jun 6, 9:09 PM · Restricted Project
mmpozulp closed D62369: [ADT] Enable set_difference() to be used on StringSet.

I committed as r362766. Thanks!

Thu, Jun 6, 8:41 PM · Restricted Project
mmpozulp added a comment to D62992: [ADT] Enable set_difference() to be used on StringSet.

Please see https://reviews.llvm.org/D62369 which is the revision that I meant to update. Instead I created this new revision by accident.

Thu, Jun 6, 8:41 PM · Restricted Project
mmpozulp reopened D62369: [ADT] Enable set_difference() to be used on StringSet.
Thu, Jun 6, 8:39 PM · Restricted Project
mmpozulp closed D62369: [ADT] Enable set_difference() to be used on StringSet.
Thu, Jun 6, 8:37 PM · Restricted Project
mmpozulp committed rG0bddef79019a: [ADT] Enable set_difference() to be used on StringSet (authored by mmpozulp).
[ADT] Enable set_difference() to be used on StringSet
Thu, Jun 6, 8:23 PM
mmpozulp updated the diff for D62369: [ADT] Enable set_difference() to be used on StringSet.

Delete unused header in StringSetTest.cpp.

Thu, Jun 6, 8:09 PM · Restricted Project
mmpozulp added a comment to D62992: [ADT] Enable set_difference() to be used on StringSet.

I meant to run arc diff --update D62369 but I ran arc diff instead, oops! Please ignore this revision.

Thu, Jun 6, 8:09 PM · Restricted Project
mmpozulp abandoned D62992: [ADT] Enable set_difference() to be used on StringSet.
Thu, Jun 6, 8:06 PM · Restricted Project
mmpozulp created D62992: [ADT] Enable set_difference() to be used on StringSet.
Thu, Jun 6, 8:06 PM · Restricted Project
mmpozulp committed rGc7029e4ef468: [NFC] Test commit. (authored by mmpozulp).
[NFC] Test commit.
Thu, Jun 6, 6:54 PM
mmpozulp updated subscribers of D62369: [ADT] Enable set_difference() to be used on StringSet.

Good news! Apparently I can commit from git (https://llvm.org/docs/GettingStarted.html#for-developers-to-commit-changes-from-git). Thank you, @smeenai!!! I should be able to land this commit soon. Good-bye svn :)

Thu, Jun 6, 5:25 PM · Restricted Project
mmpozulp added a comment to D62461: [llvm-objdump] Print source when subsequent lines in the translation unit come from the same line in two different headers..

Will do. Sorry for the delay, I'm fighting with svn. See my comment in https://reviews.llvm.org/D62369.

Thu, Jun 6, 5:09 PM · Restricted Project
mmpozulp added a comment to D62275: [llvm-objdump] Add warning if --disassemble-functions specifies an unknown symbol.

I'm fighting with svn. See my comment in https://reviews.llvm.org/D62369.

Thu, Jun 6, 5:09 PM · Restricted Project
mmpozulp added a comment to D62369: [ADT] Enable set_difference() to be used on StringSet.

I'm fighting with svn. I ran svn co https://user@llvm.org/svn/llvm-project/llvm/trunk llvm which took about 90 minutes to checkout the repo. If I run svn up it hangs for ~10 minutes on a poll() call (which I discovered by running strace) then emits an error

Thu, Jun 6, 5:03 PM · Restricted Project

Wed, May 29

mmpozulp updated the diff for D62462: [llvm-objdump] Add warning messages if disassembly + source for problematic inputs.

Incorporate feedback from @grimar to simplify an if-statement.

Wed, May 29, 4:21 PM · Restricted Project
mmpozulp added inline comments to D62462: [llvm-objdump] Add warning messages if disassembly + source for problematic inputs.
Wed, May 29, 4:12 PM · Restricted Project
mmpozulp added a comment to D62461: [llvm-objdump] Print source when subsequent lines in the translation unit come from the same line in two different headers..

This LGTM. But please hold this on until anyone else take a look too.

Wed, May 29, 3:39 PM · Restricted Project
mmpozulp added a comment to D62369: [ADT] Enable set_difference() to be used on StringSet.

Can you commit this yourself - or would you like me to do it for you?

Wed, May 29, 2:55 PM · Restricted Project
mmpozulp updated the diff for D62369: [ADT] Enable set_difference() to be used on StringSet.

Change a const char * to a StringRef

Wed, May 29, 2:49 PM · Restricted Project
mmpozulp updated the diff for D62369: [ADT] Enable set_difference() to be used on StringSet.

Incorporate feedback from @dblaikie to call insert(StringMapEntry) and count(StringMapEntry) instead of set_difference(StringSet, StringSet) in StringSetTest.cpp, which better adheres to the spirit of unit-testing.

Wed, May 29, 2:41 PM · Restricted Project

Sun, May 26

mmpozulp created D62462: [llvm-objdump] Add warning messages if disassembly + source for problematic inputs.
Sun, May 26, 1:22 AM · Restricted Project

Sat, May 25

mmpozulp created D62461: [llvm-objdump] Print source when subsequent lines in the translation unit come from the same line in two different headers..
Sat, May 25, 11:47 PM · Restricted Project

Fri, May 24

mmpozulp updated the diff for D62275: [llvm-objdump] Add warning if --disassemble-functions specifies an unknown symbol.

Incorporate feedback from @jhenderson to remove unneeded errs().flush().

Fri, May 24, 3:07 PM · Restricted Project
mmpozulp updated the diff for D62369: [ADT] Enable set_difference() to be used on StringSet.

Incorporated feedback from @dblaikie to change test name from SetOperationsTest.cpp to StringSetTest.cpp and moved an existing StringSet test from StringMapTest.cpp to new file StringSetTest.cpp.

Fri, May 24, 2:51 PM · Restricted Project
mmpozulp added a parent revision for D62275: [llvm-objdump] Add warning if --disassemble-functions specifies an unknown symbol: D62369: [ADT] Enable set_difference() to be used on StringSet.
Fri, May 24, 2:19 PM · Restricted Project
mmpozulp added a child revision for D62369: [ADT] Enable set_difference() to be used on StringSet: D62275: [llvm-objdump] Add warning if --disassemble-functions specifies an unknown symbol.
Fri, May 24, 2:19 PM · Restricted Project
mmpozulp updated the diff for D62275: [llvm-objdump] Add warning if --disassemble-functions specifies an unknown symbol.

Incorporate feedback from @jhenderson, including moving ADT changes (which must land before this patch) to a separate patch https://reviews.llvm.org/D62369

Fri, May 24, 1:15 AM · Restricted Project
mmpozulp added a comment to D62369: [ADT] Enable set_difference() to be used on StringSet.

This patch must land before https://reviews.llvm.org/D62275 in which I use set_difference() on StringSet

Fri, May 24, 12:38 AM · Restricted Project
mmpozulp created D62369: [ADT] Enable set_difference() to be used on StringSet.
Fri, May 24, 12:34 AM · Restricted Project

Thu, May 23

mmpozulp added a comment to D61117: Fix Bug 41353 - unique symbols printed as D instead of u.

LGTM. Do you need help committing this?

Thu, May 23, 5:12 PM · Restricted Project

Wed, May 22

mmpozulp added a comment to D62275: [llvm-objdump] Add warning if --disassemble-functions specifies an unknown symbol.

I've taken a bit of a heavy-hammer approach here. In order to use set_difference() on StringSet I had to extend the StringMap and StringSet APIs. Are the downsides of having a bigger API warranted by the ability to use set_difference() on StringSet? If so, I can break it out into a different patch. An alternative would be to write this patch without calling set_difference(), but that imposes some code duplication.

Wed, May 22, 5:16 PM · Restricted Project
mmpozulp updated the summary of D62275: [llvm-objdump] Add warning if --disassemble-functions specifies an unknown symbol.
Wed, May 22, 5:16 PM · Restricted Project
mmpozulp created D62275: [llvm-objdump] Add warning if --disassemble-functions specifies an unknown symbol.
Wed, May 22, 5:06 PM · Restricted Project
mmpozulp updated the diff for D61117: Fix Bug 41353 - unique symbols printed as D instead of u.

Use yaml2obj %s instead of yaml2obj < %s in test, thanks @rupprecht.

Wed, May 22, 4:42 PM · Restricted Project
mmpozulp updated the diff for D61117: Fix Bug 41353 - unique symbols printed as D instead of u.

Update test to make sure that we print 'U' for a unique symbol without a section. Thanks, @jhenderson, for suggesting this.

Wed, May 22, 2:48 PM · Restricted Project

Tue, May 21

mmpozulp added inline comments to D61117: Fix Bug 41353 - unique symbols printed as D instead of u.
Tue, May 21, 12:27 PM · Restricted Project

May 20 2019

mmpozulp updated the diff for D61117: Fix Bug 41353 - unique symbols printed as D instead of u.

Move the 'u' check before if (SecI != Obj.section_end()), thanks @MaskRay.

May 20 2019, 10:18 PM · Restricted Project
mmpozulp updated the diff for D62054: [llvm-objdump] Make --disassemble-functions imply -d.

Change a CHECK to CHECK-NEXT, thanks @jhenderson.

May 20 2019, 9:54 PM · Restricted Project
mmpozulp added a comment to D62054: [llvm-objdump] Make --disassemble-functions imply -d.

LGTM, with one minor comment outstanding.

Do you need somebody to commit it for you?

May 20 2019, 9:54 PM · Restricted Project

May 19 2019

mmpozulp added a comment to D61117: Fix Bug 41353 - unique symbols printed as D instead of u.

BTW, I think STB_GNU_UNIQUE is a misfeature (no clear specification, only (complex) implementation is in glibc, interaction with STB_WEAK/STB_GLOBAL is unclear..).. this feature will highlight the problem :)

May 19 2019, 12:30 AM · Restricted Project

May 18 2019

mmpozulp added inline comments to D62054: [llvm-objdump] Make --disassemble-functions imply -d.
May 18 2019, 5:53 PM · Restricted Project
mmpozulp updated the diff for D62054: [llvm-objdump] Make --disassemble-functions imply -d.

Incorporate feedback from @jhenderson.

May 18 2019, 5:45 PM · Restricted Project
mmpozulp updated the diff for D61117: Fix Bug 41353 - unique symbols printed as D instead of u.

Squish tests together into one file and use more descriptive section/symbol names. Thanks @jhenderson :)

May 18 2019, 5:20 PM · Restricted Project

May 16 2019

mmpozulp created D62054: [llvm-objdump] Make --disassemble-functions imply -d.
May 16 2019, 11:39 PM · Restricted Project
mmpozulp added inline comments to D61117: Fix Bug 41353 - unique symbols printed as D instead of u.
May 16 2019, 9:49 PM · Restricted Project
mmpozulp updated the diff for D61117: Fix Bug 41353 - unique symbols printed as D instead of u.

Incorporate feedback by @jhenderson.

May 16 2019, 9:37 PM · Restricted Project

May 14 2019

mmpozulp updated the diff for D61117: Fix Bug 41353 - unique symbols printed as D instead of u.

Rebase and fix yaml spaces. Thanks @MaskRay and @jhenderson :)

May 14 2019, 3:53 PM · Restricted Project

May 13 2019

mmpozulp added inline comments to D61117: Fix Bug 41353 - unique symbols printed as D instead of u.
May 13 2019, 1:29 PM · Restricted Project
mmpozulp updated the diff for D61117: Fix Bug 41353 - unique symbols printed as D instead of u.

Incorporate feedback by @grimar

May 13 2019, 1:11 PM · Restricted Project

May 7 2019

mmpozulp updated the diff for D61117: Fix Bug 41353 - unique symbols printed as D instead of u.

Inline the check for gnu unique symbol as per suggestion by @grimar. Use yaml2obj instead of llvm-mc in unique.test.

May 7 2019, 2:05 PM · Restricted Project

May 6 2019

mmpozulp updated the diff for D61117: Fix Bug 41353 - unique symbols printed as D instead of u.

Delete unnecessary modification to ELFTypes.h

May 6 2019, 3:20 PM · Restricted Project
mmpozulp updated the diff for D61117: Fix Bug 41353 - unique symbols printed as D instead of u.

Incorporate feedback from @rupprecht

May 6 2019, 3:11 PM · Restricted Project

Apr 25 2019

mmpozulp updated the diff for D61117: Fix Bug 41353 - unique symbols printed as D instead of u.

Protect dyn_cast with isELF() check

Apr 25 2019, 1:10 PM · Restricted Project
mmpozulp created D61117: Fix Bug 41353 - unique symbols printed as D instead of u.
Apr 25 2019, 12:13 AM · Restricted Project