Page MenuHomePhabricator

mmalcomson (Matthew Malcomson)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 10 2019, 6:26 AM (88 w, 1 d)

Recent Activity

Feb 19 2021

mmalcomson committed rGc1653b8cc7bd: Hwasan InitPrctl check for error using internal_iserror (authored by mmalcomson).
Hwasan InitPrctl check for error using internal_iserror
Feb 19 2021, 8:34 AM

Feb 18 2021

mmalcomson reopened D94425: Hwasan InitPrctl check for error using internal_iserror.

Reopening with new revision since previous version has been reverted due to my mistake.
Apologies again for that lazy mistake.

Feb 18 2021, 8:48 AM · Restricted Project, Restricted Project
mmalcomson updated the diff for D94425: Hwasan InitPrctl check for error using internal_iserror.

Apologies for the original mistake (which was pretty bad), and the very slow response.

Feb 18 2021, 8:47 AM · Restricted Project, Restricted Project
mmalcomson abandoned D96964: Hwasan InitPrctl check for error using internal_iserror.

Accidentally created a new revision when attempting to update an existing revision.
Was trying to use arc for first time.

Feb 18 2021, 8:29 AM · Restricted Project
mmalcomson requested review of D96964: Hwasan InitPrctl check for error using internal_iserror.
Feb 18 2021, 8:26 AM · Restricted Project

Jan 13 2021

mmalcomson committed rG1854594b80b4: Hwasan InitPrctl check for error using internal_iserror (authored by mmalcomson).
Hwasan InitPrctl check for error using internal_iserror
Jan 13 2021, 3:36 AM
mmalcomson closed D94425: Hwasan InitPrctl check for error using internal_iserror.
Jan 13 2021, 3:36 AM · Restricted Project, Restricted Project

Jan 11 2021

mmalcomson requested review of D94425: Hwasan InitPrctl check for error using internal_iserror.
Jan 11 2021, 9:13 AM · Restricted Project, Restricted Project

Nov 16 2020

mmalcomson committed rG83ac18205ec6: Hwasan reporting check for dladdr failing (authored by mmalcomson).
Hwasan reporting check for dladdr failing
Nov 16 2020, 4:26 AM
mmalcomson closed D91344: [hwasan] Handle possible failure of dladdr.
Nov 16 2020, 4:26 AM · Restricted Project

Nov 13 2020

mmalcomson added a comment to D91344: [hwasan] Handle possible failure of dladdr.

The problem is when hwasan detects a fault accessing a value on the stack in Linux.
What I believe happens is:

Nov 13 2020, 2:28 AM · Restricted Project

Nov 12 2020

mmalcomson requested review of D91344: [hwasan] Handle possible failure of dladdr.
Nov 12 2020, 6:07 AM · Restricted Project

May 14 2020

mmalcomson added a comment to D69045: libhwasan interceptor ABI intercept longjmp/setjmp.

(FWIW this particular setjmp can be intercepted in glibc 2.31 -- so hopefully as time goes on this will be less of a problem).

I am the reporter of the linked GitHub issue. Are you saying that if I just built with glibc 2.31, without any change to clang, then I would not see this instance of the setjmp error?

I believe I am on 2.31 already:

May 14 2020, 4:15 AM · Restricted Project, Restricted Project

May 12 2020

mmalcomson added a comment to D69045: libhwasan interceptor ABI intercept longjmp/setjmp.

According to https://github.com/google/sanitizers/issues/1244, there is a non-interceptable _setjmp in __libc_start_main that is later jumped to in pthread_exit.
It seems to break this approach.
Any idea what to do? Detect that jmpbuf is not a hwasan jmpbuf and bail out? This is happening at the very end of a thread's life, so hopefully it should not matter that the stack in not untagged.

May 12 2020, 8:34 AM · Restricted Project, Restricted Project

Nov 13 2019

mmalcomson committed rGe5f3760e8c7f: Fix comment spelling {addresing -> addressing} (NFC) (authored by mmalcomson).
Fix comment spelling {addresing -> addressing} (NFC)
Nov 13 2019, 8:18 AM

Nov 1 2019

mmalcomson added a comment to D69574: Remove lazy thread-initialisation.

Ping @pcc -- does this change to remove lazy thread initialisation look OK?

Nov 1 2019, 8:26 AM · Restricted Project, Restricted Project, Restricted Project

Oct 31 2019

mmalcomson added inline comments to D69045: libhwasan interceptor ABI intercept longjmp/setjmp.
Oct 31 2019, 3:07 AM · Restricted Project, Restricted Project

Oct 29 2019

mmalcomson created D69574: Remove lazy thread-initialisation.
Oct 29 2019, 11:04 AM · Restricted Project, Restricted Project, Restricted Project
mmalcomson updated the diff for D69045: libhwasan interceptor ABI intercept longjmp/setjmp.

Have addressed raised issues.

Oct 29 2019, 9:58 AM · Restricted Project, Restricted Project

Oct 25 2019

mmalcomson updated the diff for D69045: libhwasan interceptor ABI intercept longjmp/setjmp.

I've tried to get this working for Android.

Oct 25 2019, 9:57 AM · Restricted Project, Restricted Project
mmalcomson abandoned D69051: Handle libhwasan system allocator fallback during thread initialisation.

Closing given the allocator fallback feature is not being pursued any more.

Oct 25 2019, 8:07 AM · Restricted Project, Restricted Project

Oct 21 2019

mmalcomson added a comment to D69199: [hwasan] Remove system allocator fallback..

If late interposition is no longer a supported use-case, does that apply to the pthread use case as well?
https://reviews.llvm.org/D56038

Oct 21 2019, 3:01 AM · Restricted Project, Restricted Project

Oct 18 2019

mmalcomson updated the diff for D69051: Handle libhwasan system allocator fallback during thread initialisation.

Now avoid returning a zero tag when tagging is disabled.

Oct 18 2019, 10:11 AM · Restricted Project, Restricted Project
mmalcomson updated the diff for D69045: libhwasan interceptor ABI intercept longjmp/setjmp.
Oct 18 2019, 10:11 AM · Restricted Project, Restricted Project
mmalcomson updated the diff for D69113: Expose __hwasan_tag_mismatch_stub.
Oct 18 2019, 8:38 AM · Restricted Project, Restricted Project
mmalcomson added inline comments to D69045: libhwasan interceptor ABI intercept longjmp/setjmp.
Oct 18 2019, 7:13 AM · Restricted Project, Restricted Project
mmalcomson added inline comments to D69045: libhwasan interceptor ABI intercept longjmp/setjmp.
Oct 18 2019, 3:27 AM · Restricted Project, Restricted Project

Oct 17 2019

mmalcomson updated the diff for D69051: Handle libhwasan system allocator fallback during thread initialisation.

Remove some superfluous semicolons that were causing warnings.

Oct 17 2019, 10:14 AM · Restricted Project, Restricted Project
mmalcomson created D69113: Expose __hwasan_tag_mismatch_stub.
Oct 17 2019, 8:49 AM · Restricted Project, Restricted Project
mmalcomson updated the diff for D69045: libhwasan interceptor ABI intercept longjmp/setjmp.

Added a test in the hwasan testsuite.

Oct 17 2019, 5:35 AM · Restricted Project, Restricted Project

Oct 16 2019

mmalcomson created D69051: Handle libhwasan system allocator fallback during thread initialisation.
Oct 16 2019, 9:32 AM · Restricted Project, Restricted Project
mmalcomson created D69045: libhwasan interceptor ABI intercept longjmp/setjmp.
Oct 16 2019, 8:36 AM · Restricted Project, Restricted Project
mmalcomson added a comment to D68794: libhwasan initialisation include kernel syscall ABI relaxation.

LGTM
Thank you!
Do you want me to submit this change for you?

Oct 16 2019, 1:36 AM · Restricted Project, Restricted Project

Oct 15 2019

mmalcomson updated the diff for D68794: libhwasan initialisation include kernel syscall ABI relaxation.

Run prctl syscall for Android, but ignore EINVAL failures.

NOTE: I don't believe this distinguishes between running on a kernel with with the tagged address ABI unconditional or running on a newer kernel or on a kernel with sysctl abi.tagged_addr_disabled=1 (https://android.googlesource.com/kernel/common/+/690c4ca8a5715644370384672f24d95b042db74a/Documentation/arm64/tagged-address-abi.rst)

This is a good point. It appears that PR_GET_TAGGED_ADDR_CTRL works even when abi.tagged_addr_disabled=1, we can use it to tell these two cases apart

Oct 15 2019, 4:46 AM · Restricted Project, Restricted Project

Oct 11 2019

mmalcomson updated the diff for D68794: libhwasan initialisation include kernel syscall ABI relaxation.

Run prctl syscall for Android, but ignore EINVAL failures.

Oct 11 2019, 6:40 AM · Restricted Project, Restricted Project

Oct 10 2019

mmalcomson created D68794: libhwasan initialisation include kernel syscall ABI relaxation.
Oct 10 2019, 8:33 AM · Restricted Project, Restricted Project