Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

mkroll (Moritz Kroll)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 11 2017, 9:39 AM (345 w, 6 d)

Recent Activity

Jul 1 2023

mkroll added a comment to D150184: [ORC] Fix race-condition in RTDyldObjectLinkingLayer::onObjEmit..

Ping!
I won't have access to my computer for two months starting on Wednesday, so if you still want anything to be changed before you can approve this, there's not much time for me left ^_^

Jul 1 2023, 11:07 AM · Restricted Project, Restricted Project

May 31 2023

mkroll updated the diff for D150184: [ORC] Fix race-condition in RTDyldObjectLinkingLayer::onObjEmit..

Update order as discussed to first EventListeners, then NotifyEmitted, then adding the MemMgr and then MaterializationResponsibility::notifyEmitted().
This is basically the same order as in ObjectLinkingLayer now.

May 31 2023, 2:16 PM · Restricted Project, Restricted Project
mkroll added a comment to D150184: [ORC] Fix race-condition in RTDyldObjectLinkingLayer::onObjEmit..

Finally found some time to continue looking into this...
ObjectLinkingLayer doesn't have this problem because it uses this order in ObjectLinkingLayerJITLinkContext:

May 31 2023, 2:08 PM · Restricted Project, Restricted Project

May 11 2023

mkroll added inline comments to D150184: [ORC] Fix race-condition in RTDyldObjectLinkingLayer::onObjEmit..
May 11 2023, 6:59 AM · Restricted Project, Restricted Project

May 9 2023

mkroll updated the diff for D150184: [ORC] Fix race-condition in RTDyldObjectLinkingLayer::onObjEmit..

Added missing check on Expected result of lookup.
Apply ugly clang-format include reordering (this is not even alphabetic, is this just about editing distance to the containing file name?).

May 9 2023, 6:22 AM · Restricted Project, Restricted Project
mkroll requested review of D150184: [ORC] Fix race-condition in RTDyldObjectLinkingLayer::onObjEmit..
May 9 2023, 2:06 AM · Restricted Project, Restricted Project

Feb 12 2017

mkroll added a comment to D29864: Update Kaleidoscope tutorial and improve Windows support.

I would also prefer to provide a patch set to have sensibly grouped changes like with git.

Feb 12 2017, 9:06 AM
mkroll created D29875: Kaleidoscope-Ch7: Add missing transformutils to llvm-config params.
Feb 12 2017, 9:04 AM

Feb 11 2017

mkroll added a comment to D29864: Update Kaleidoscope tutorial and improve Windows support.

Sure, the Windows specific changes work fine on Windows.

Feb 11 2017, 1:30 PM
mkroll updated the diff for D29864: Update Kaleidoscope tutorial and improve Windows support.

Fixed some too long lines

Feb 11 2017, 1:21 PM
mkroll created D29864: Update Kaleidoscope tutorial and improve Windows support.
Feb 11 2017, 10:10 AM