Page MenuHomePhabricator

mjsabby (Mukul Sabharwal)


User does not belong to any projects.

User Details

User Since
Jan 27 2015, 2:49 AM (425 w, 6 h)

Recent Activity

Apr 23 2015

mjsabby added a comment to D9212: Start to share SWIG interface files between languages..

Looks good.

Apr 23 2015, 11:05 AM

Apr 16 2015

mjsabby added a comment to D9027: Add LLDB C Bindings.

I would love to see everyone stick to using SWIG.

No symbols need to be exported from the LLDB shared library except stuff that starts with "lldb::" or "init_lldb*". We use this as our exports list:

% cat resources/lldb-framework-exports

So adding extra languages will add a bit of bulk to the size of the LLDB shared library, but it shouldn't affect the public interface. So I vote to use SWIG.

Also, you can use the C++ mangled names like you would use a C interface. We don't use any inheritance and we use no virtual functions so every C++ function is available by looking up the mangled name and then you can learn how to call it correctly.

Apr 16 2015, 1:29 PM

Apr 15 2015

mjsabby added a comment to D9027: Add LLDB C Bindings.

With Zachary on this - I think it would be better to ensure the configuration/input files to the tool that produces these bindings is committed rather than the output itself.

I'm actually still not convinced that even that is the best solution. Hopefully Mukul can expand on why using SWIG directly to generate C# bindings doesn't work. We already have all these swig interface files built up, and the CMake is mostly set up to just work. Why not just use it and generate C# bindings directly?

Apr 15 2015, 1:28 PM
mjsabby added a comment to D9027: Add LLDB C Bindings.

Automating it seems like an ok thing to do, this was a start to see if the
community feels it will benefit them immediately having a C interface.

Apr 15 2015, 10:56 AM
mjsabby retitled D9027: Add LLDB C Bindings from to Add LLDB C Bindings.
Apr 15 2015, 12:40 AM

Apr 10 2015

mjsabby added a comment to D8979: Making linking against Python simpler on Windows.

Can you also include the changes to

Apr 10 2015, 2:36 PM

Apr 1 2015

mjsabby retitled D8788: Expose llvm::linkShadowStackGC() via C bindings from to Expose llvm::linkShadowStackGC() via C bindings.
Apr 1 2015, 3:31 PM