Page MenuHomePhabricator

minjaehwang (MinJae Hwang)
User

Projects

User does not belong to any projects.

User Details

User Since
May 30 2020, 12:48 PM (121 w, 1 d)

Recent Activity

Jun 17 2021

minjaehwang updated the summary of D93233: [libc++] Replaces std::sort by Bitset sorting algorithm..
Jun 17 2021, 12:49 AM · Unknown Object (Project), Restricted Project
minjaehwang updated the diff for D93233: [libc++] Replaces std::sort by Bitset sorting algorithm..

Improved randomized sort performance for all types.
Added introsort feature.

Jun 17 2021, 12:44 AM · Unknown Object (Project), Restricted Project

Jun 16 2021

minjaehwang updated the summary of D93233: [libc++] Replaces std::sort by Bitset sorting algorithm..
Jun 16 2021, 11:37 PM · Unknown Object (Project), Restricted Project
minjaehwang added a comment to D93233: [libc++] Replaces std::sort by Bitset sorting algorithm..

I worked on performance improvements and wrote a documentation what bitset sort is and why it is faster. Thanks to LLVM's ability to generate SIMD instructions, bitset sort lets LLVM to generate SIMD instructions for the critical path (bitset partition).

Jun 16 2021, 11:34 PM · Unknown Object (Project), Restricted Project

Dec 21 2020

minjaehwang added a comment to D93233: [libc++] Replaces std::sort by Bitset sorting algorithm..

Thank @Morwenn very much for looking into this code.

Dec 21 2020, 1:27 PM · Unknown Object (Project), Restricted Project

Dec 14 2020

minjaehwang added inline comments to D93233: [libc++] Replaces std::sort by Bitset sorting algorithm..
Dec 14 2020, 12:25 PM · Unknown Object (Project), Restricted Project
minjaehwang added a comment to D93233: [libc++] Replaces std::sort by Bitset sorting algorithm..

IMHO bitset sort is not a standard term, so it needs some clarification. From a glance this uses a bitset partition and needs temporary storage (heap memory allocation?). Does the original algorithm have heap memory allocation?

Dec 14 2020, 12:24 PM · Unknown Object (Project), Restricted Project
minjaehwang added a comment to D93233: [libc++] Replaces std::sort by Bitset sorting algorithm..

What are the perf changes on CPU's without support for those instructions?

Dec 14 2020, 12:23 PM · Unknown Object (Project), Restricted Project
minjaehwang added a comment to D93233: [libc++] Replaces std::sort by Bitset sorting algorithm..

This is an interesting contribution. I'm trying to wrap my head around it.

Dec 14 2020, 12:20 PM · Unknown Object (Project), Restricted Project
minjaehwang added a comment to D93233: [libc++] Replaces std::sort by Bitset sorting algorithm..

Did you upload the right diff? The code does not show sort.

Dec 14 2020, 9:59 AM · Unknown Object (Project), Restricted Project
minjaehwang updated the diff for D93233: [libc++] Replaces std::sort by Bitset sorting algorithm..

Made the incorrect patch previously.

Dec 14 2020, 9:58 AM · Unknown Object (Project), Restricted Project
minjaehwang added a reviewer for D93233: [libc++] Replaces std::sort by Bitset sorting algorithm.: EricWF.
Dec 14 2020, 9:32 AM · Unknown Object (Project), Restricted Project
minjaehwang updated the summary of D93233: [libc++] Replaces std::sort by Bitset sorting algorithm..
Dec 14 2020, 9:31 AM · Unknown Object (Project), Restricted Project
minjaehwang updated the summary of D93233: [libc++] Replaces std::sort by Bitset sorting algorithm..
Dec 14 2020, 9:30 AM · Unknown Object (Project), Restricted Project
minjaehwang updated the summary of D93233: [libc++] Replaces std::sort by Bitset sorting algorithm..
Dec 14 2020, 9:29 AM · Unknown Object (Project), Restricted Project
minjaehwang requested review of D93233: [libc++] Replaces std::sort by Bitset sorting algorithm..
Dec 14 2020, 9:27 AM · Unknown Object (Project), Restricted Project

Jul 6 2020

minjaehwang added a comment to D81770: Modifications to the algorithm sort benchmark.

Resolved your comments!

Jul 6 2020, 1:50 PM · Unknown Object (Project)
minjaehwang updated the diff for D81770: Modifications to the algorithm sort benchmark.

Fix the typo

Jul 6 2020, 1:44 PM · Unknown Object (Project)

Jun 18 2020

minjaehwang added a comment to D81770: Modifications to the algorithm sort benchmark.

clang-tidy complains that "benchmark/benchmark.h" is not found at CartesianBehcmarks.h. This diff does not modify that file and this is a benign error. It compiles without a problem.

Jun 18 2020, 8:43 PM · Unknown Object (Project)
minjaehwang updated the diff for D81770: Modifications to the algorithm sort benchmark.

Fix clang-tidy warnings.

Jun 18 2020, 5:31 PM · Unknown Object (Project)
minjaehwang updated the diff for D81770: Modifications to the algorithm sort benchmark.

Reflects EricWF's comment. Change a bool variable to an enum.

Jun 18 2020, 3:54 PM · Unknown Object (Project)

Jun 12 2020

minjaehwang created D81770: Modifications to the algorithm sort benchmark.
Jun 12 2020, 3:58 PM · Unknown Object (Project)