Page MenuHomePhabricator

mikael (Mikael Nilsson)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 3 2018, 6:41 AM (54 w, 4 d)

Recent Activity

Jan 10 2019

mikael accepted D56509: [AST] Remove ASTContext from getThisType (NFC).

The changes looks good to me.

Jan 10 2019, 5:39 AM

Jan 8 2019

mikael abandoned D55656: [OpenCL] Address space for default class members.
Jan 8 2019, 11:38 PM

Dec 13 2018

mikael added inline comments to D55656: [OpenCL] Address space for default class members.
Dec 13 2018, 7:41 AM
mikael created D55656: [OpenCL] Address space for default class members.
Dec 13 2018, 7:30 AM
mikael committed rLLDB349020: Fix for clang interface update.
Fix for clang interface update
Dec 13 2018, 2:21 AM
mikael committed rL349020: Fix for clang interface update.
Fix for clang interface update
Dec 13 2018, 2:20 AM
mikael committed rL349019: [OpenCL] Add generic AS to 'this' pointer.
[OpenCL] Add generic AS to 'this' pointer
Dec 13 2018, 2:19 AM
mikael committed rC349019: [OpenCL] Add generic AS to 'this' pointer.
[OpenCL] Add generic AS to 'this' pointer
Dec 13 2018, 2:19 AM

Dec 12 2018

mikael committed rL348931: Revert "[OpenCL] Add generic AS to 'this' pointer".
Revert "[OpenCL] Add generic AS to 'this' pointer"
Dec 12 2018, 7:09 AM
mikael committed rC348931: Revert "[OpenCL] Add generic AS to 'this' pointer".
Revert "[OpenCL] Add generic AS to 'this' pointer"
Dec 12 2018, 7:09 AM
mikael added a comment to D54862: [OpenCL] Add generic AS to 'this' pointer.

Seems like my this commit broke: http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-buildserver/builds/33176

Dec 12 2018, 7:06 AM
mikael committed rC348927: [OpenCL] Add generic AS to 'this' pointer.
[OpenCL] Add generic AS to 'this' pointer
Dec 12 2018, 6:17 AM
mikael committed rL348927: [OpenCL] Add generic AS to 'this' pointer.
[OpenCL] Add generic AS to 'this' pointer
Dec 12 2018, 6:17 AM
mikael closed D54862: [OpenCL] Add generic AS to 'this' pointer.
Dec 12 2018, 6:17 AM

Dec 11 2018

mikael added inline comments to D54862: [OpenCL] Add generic AS to 'this' pointer.
Dec 11 2018, 4:00 AM
mikael added inline comments to D54862: [OpenCL] Add generic AS to 'this' pointer.
Dec 11 2018, 2:59 AM

Dec 10 2018

mikael added inline comments to D54862: [OpenCL] Add generic AS to 'this' pointer.
Dec 10 2018, 2:58 AM
mikael added a comment to D54862: [OpenCL] Add generic AS to 'this' pointer.

I rebased on Friday, and noticed that I broke two tests:

Dec 10 2018, 2:48 AM
mikael updated the diff for D54862: [OpenCL] Add generic AS to 'this' pointer.
Dec 10 2018, 2:42 AM

Dec 6 2018

mikael added inline comments to D54862: [OpenCL] Add generic AS to 'this' pointer.
Dec 6 2018, 2:53 AM
mikael updated the diff for D54862: [OpenCL] Add generic AS to 'this' pointer.
  • Added FIXME's.
  • Fixed the latest comments.
Dec 6 2018, 2:43 AM
mikael added inline comments to D54862: [OpenCL] Add generic AS to 'this' pointer.
Dec 6 2018, 12:04 AM

Dec 5 2018

mikael added inline comments to D54862: [OpenCL] Add generic AS to 'this' pointer.
Dec 5 2018, 8:00 AM
mikael updated the diff for D54862: [OpenCL] Add generic AS to 'this' pointer.

I uploaded a new patch for most of the comments. I did leave some things out since they need clarification.

Dec 5 2018, 7:58 AM
mikael added a comment to D54862: [OpenCL] Add generic AS to 'this' pointer.

Thanks for the feedback, I'll work on fixing the issues!

Dec 5 2018, 5:32 AM

Dec 4 2018

mikael added inline comments to D54862: [OpenCL] Add generic AS to 'this' pointer.
Dec 4 2018, 5:02 AM
mikael updated the diff for D54862: [OpenCL] Add generic AS to 'this' pointer.
Dec 4 2018, 4:10 AM

Nov 30 2018

mikael added inline comments to D54862: [OpenCL] Add generic AS to 'this' pointer.
Nov 30 2018, 2:33 AM
mikael updated the diff for D54862: [OpenCL] Add generic AS to 'this' pointer.
Nov 30 2018, 2:24 AM

Nov 28 2018

mikael updated the diff for D54862: [OpenCL] Add generic AS to 'this' pointer.
Nov 28 2018, 2:59 AM

Nov 27 2018

mikael added inline comments to D54862: [OpenCL] Add generic AS to 'this' pointer.
Nov 27 2018, 7:27 AM

Nov 23 2018

mikael created D54862: [OpenCL] Add generic AS to 'this' pointer.
Nov 23 2018, 7:05 AM

Sep 26 2018

mikael committed rL343086: Run VerifyDAGDiverence in debug only.
Run VerifyDAGDiverence in debug only
Sep 26 2018, 2:28 AM
mikael closed D52454: Run VerifyDAGDiverence in debug only.
Sep 26 2018, 2:28 AM

Sep 25 2018

mikael added a comment to D52454: Run VerifyDAGDiverence in debug only.

The compile time increase showed up in our internal GPU target.

Sep 25 2018, 4:23 AM
mikael added a reviewer for D52454: Run VerifyDAGDiverence in debug only: eli.friedman.
Sep 25 2018, 4:03 AM
mikael created D52454: Run VerifyDAGDiverence in debug only.
Sep 25 2018, 2:59 AM

Sep 6 2018

mikael added a comment to D51596: Fix bug in MachineInstr::hasPropertyInBundle.

I don't have commit access yet, I would like to have it at some point, but for now I'd be happy if someone could push it for me.

Sep 6 2018, 12:30 AM

Sep 5 2018

mikael added a comment to D51596: Fix bug in MachineInstr::hasPropertyInBundle.

@bjope, are you happy with the last diff?

Sep 5 2018, 11:15 PM

Sep 4 2018

mikael updated the diff for D51596: Fix bug in MachineInstr::hasPropertyInBundle.

Added the suggested assertion comment.

Sep 4 2018, 7:35 AM
mikael updated the diff for D51596: Fix bug in MachineInstr::hasPropertyInBundle.

Updated the patch to include suggestions from @bjope

Sep 4 2018, 6:09 AM

Sep 3 2018

mikael added a comment to D51596: Fix bug in MachineInstr::hasPropertyInBundle.

I'm not sure it can be reproduced in an in-tree target. But it is easy to give you an example when this happens:

Sep 3 2018, 11:21 PM
mikael created D51596: Fix bug in MachineInstr::hasPropertyInBundle.
Sep 3 2018, 7:50 AM