Page MenuHomePhabricator

michoecho (Michał Chojnowski)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 4 2022, 8:25 AM (5 w, 4 d)

Recent Activity

Jul 7 2022

michoecho added a comment to D129089: [BOLT] Fix concurrent hash table modification in the instrumentation runtime.

Sure, but we need your git name and email to specify it in patch, since diff does not contain this information we need to set it manually

Oh.
Name: Michał Chojnowski
E-mail: michal.chojnowski@scylladb.com
Thanks!

Jul 7 2022, 3:31 AM · Restricted Project, Restricted Project

Jul 6 2022

michoecho added a comment to D129089: [BOLT] Fix concurrent hash table modification in the instrumentation runtime.

I don't have commit access. Could you commit the change, please?

Jul 6 2022, 5:15 PM · Restricted Project, Restricted Project
michoecho updated the diff for D129089: [BOLT] Fix concurrent hash table modification in the instrumentation runtime.

I have removed the Mutex fix from the diff, since the alternative fix (https://reviews.llvm.org/D129162) has been merged.
The __bolt_instr_data_dump() fix remains.

Jul 6 2022, 5:36 AM · Restricted Project, Restricted Project

Jul 4 2022

michoecho added a comment to D129089: [BOLT] Fix concurrent hash table modification in the instrumentation runtime.

The CI at https://buildkite.com/llvm-project/premerge-checks/builds/100883#0181ca04-ccc6-4cd2-98aa-df8a08a31b12 seems to have failed due to the problem which will be fixed by https://reviews.llvm.org/D128971.

Jul 4 2022, 9:56 AM · Restricted Project, Restricted Project
michoecho added a comment to D129089: [BOLT] Fix concurrent hash table modification in the instrumentation runtime.

Why can't we use standard std::lock_guard here?

Jul 4 2022, 9:38 AM · Restricted Project, Restricted Project
michoecho added a comment to D129089: [BOLT] Fix concurrent hash table modification in the instrumentation runtime.

Note: those bugs were found when applying BOLT's instrumentation to ScyllaDB. After the fix, I haven't found any other issues.

Jul 4 2022, 9:33 AM · Restricted Project, Restricted Project
michoecho updated the summary of D129089: [BOLT] Fix concurrent hash table modification in the instrumentation runtime.
Jul 4 2022, 9:21 AM · Restricted Project, Restricted Project
michoecho requested review of D129089: [BOLT] Fix concurrent hash table modification in the instrumentation runtime.
Jul 4 2022, 9:20 AM · Restricted Project, Restricted Project