Page MenuHomePhabricator

mgartmann (Marco Gartmann)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 29 2021, 6:44 AM (6 w, 6 d)

Recent Activity

Yesterday

mgartmann added inline comments to D102325: [clang-tidy] cppcoreguidelines-virtual-base-class-destructor: a new check.
Sat, May 15, 7:30 AM · Restricted Project
mgartmann updated the diff for D102325: [clang-tidy] cppcoreguidelines-virtual-base-class-destructor: a new check.

Resolved readability-identifier-naming warning, adjusted check's documentation.

Sat, May 15, 7:24 AM · Restricted Project
mgartmann updated the diff for D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check.

Fetched new commits from upstream main branch and resolved merge conflicts.

Sat, May 15, 7:00 AM · Restricted Project
mgartmann updated the diff for D102325: [clang-tidy] cppcoreguidelines-virtual-base-class-destructor: a new check.

Incorporated Phabricator review feedback:

  • added matchers and tests for subclasses with inherited virtual methods
  • made aid methods static and not part of the check's class
  • replaced auto with types where it was suggested
  • adjusted diagnostic messages
Sat, May 15, 4:18 AM · Restricted Project
mgartmann added a comment to D102325: [clang-tidy] cppcoreguidelines-virtual-base-class-destructor: a new check.

Whats the intended behaviour for derived classes and their destructors? Can test be added to demonstrate that behaviour?

Sat, May 15, 4:10 AM · Restricted Project

Wed, May 12

mgartmann requested review of D102325: [clang-tidy] cppcoreguidelines-virtual-base-class-destructor: a new check.
Wed, May 12, 6:53 AM · Restricted Project
mgartmann updated the diff for D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check.
Wed, May 12, 2:32 AM · Restricted Project
mgartmann updated the diff for D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check.

Remove any parentheses and slashes from the check's section in ReleaseNotes.rst in order to try to fix the build.

Wed, May 12, 2:20 AM · Restricted Project
mgartmann updated the diff for D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check.

Re-add description for this check in ReleaseNotes.rst.
Adjust AvoidStdIoOutsideMainCheck.cpp third matcher to call hasAnyName() with a vector.

Wed, May 12, 1:25 AM · Restricted Project
mgartmann updated the diff for D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check.

Revert ReleaseNotes.rst to its initial content in a try to fix the pre-build tests.

Wed, May 12, 12:01 AM · Restricted Project

Mon, May 10

mgartmann updated the diff for D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check.

Revert ReleaseNotes.rst to a point where the build worked.

Mon, May 10, 6:34 AM · Restricted Project
mgartmann updated the diff for D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check.

Change encoding of patch to UTF-8 in order to fix build.

Mon, May 10, 5:57 AM · Restricted Project
mgartmann updated the diff for D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check.

Updated diff to fix the build.

Mon, May 10, 5:05 AM · Restricted Project
mgartmann updated the diff for D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check.

Remove trailing whitespaces from documentation file.

Mon, May 10, 3:00 AM · Restricted Project

Sun, May 9

mgartmann added a comment to D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check.

@njames93 thanks a lot for your answer! I extracted the STD IO stream and C-like function names according to your comment.

Sun, May 9, 7:25 AM · Restricted Project
mgartmann updated the diff for D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check.

Extracted STD IO stream and C-like IO function names into vectors.

Sun, May 9, 7:21 AM · Restricted Project

Fri, Apr 30

mgartmann added a comment to D100972: [clang-tidy] cppcoreguidelines-avoid-non-const-global-variables: add fixes to checks.

Friendly ping, any feedback would be appreciated :)

Fri, Apr 30, 5:31 AM · Restricted Project

Wed, Apr 28

mgartmann updated the diff for D100972: [clang-tidy] cppcoreguidelines-avoid-non-const-global-variables: add fixes to checks.

Replaced string comparison to check if a character is a space with std::isspace().
Added test case for this scenario.

Wed, Apr 28, 5:17 AM · Restricted Project

Sun, Apr 25

mgartmann added a comment to D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check.

Friendly ping :)

Sun, Apr 25, 11:13 PM · Restricted Project

Thu, Apr 22

mgartmann updated the diff for D100972: [clang-tidy] cppcoreguidelines-avoid-non-const-global-variables: add fixes to checks.

Fixed one-off error.

Thu, Apr 22, 5:20 AM · Restricted Project
mgartmann updated the diff for D100972: [clang-tidy] cppcoreguidelines-avoid-non-const-global-variables: add fixes to checks.
  • Renamed printCleanedType() to cleanType()
  • Extended cleanType() to also remove (anonymous) from a type
  • Made hasSpaceAfterType() more error-robust.
Thu, Apr 22, 4:44 AM · Restricted Project

Wed, Apr 21

mgartmann requested review of D100972: [clang-tidy] cppcoreguidelines-avoid-non-const-global-variables: add fixes to checks.
Wed, Apr 21, 9:55 AM · Restricted Project

Apr 13 2021

mgartmann added inline comments to D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check.
Apr 13 2021, 11:35 PM · Restricted Project

Apr 7 2021

mgartmann updated the diff for D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check.

Corrected check's entry in list.rst after renaming the check.

Apr 7 2021, 9:20 AM · Restricted Project
mgartmann updated the diff for D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check.
  • Added two new matchers to flag uses of stdio.h/csdtio functions outside of main.
  • Renamed the check to fit those new functionalities.
Apr 7 2021, 2:36 AM · Restricted Project

Apr 1 2021

mgartmann added a comment to D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check.

Is it not wise to also check the c standard library.
So check for function refs to these names in the global or std namespace.
printf, vprintf, puts, putchar, scanf, scanf, getchar and gets
It may be a bit of a pain checking for usages of stdin and stdout due to them being defined as macros.

Apr 1 2021, 6:45 AM · Restricted Project
mgartmann added inline comments to D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check.
Apr 1 2021, 3:17 AM · Restricted Project
mgartmann updated the diff for D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check.

Add isInStdNamespace to matcher so that only global objects in namespace std are matched and add corresponding tests.

Apr 1 2021, 3:12 AM · Restricted Project

Mar 31 2021

mgartmann updated the diff for D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check.

Removed superfluous semicolon in StdStreamObjectsOutsideMainCheck.cpp according to feedback.

Mar 31 2021, 11:38 PM · Restricted Project
mgartmann updated the diff for D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check.

Refactored the code and documentation files according to the feedback received on the first diff.

Mar 31 2021, 2:03 PM · Restricted Project
mgartmann added inline comments to D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check.
Mar 31 2021, 1:55 PM · Restricted Project
mgartmann added a comment to D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check.

I am working on fixing the failing build.

Mar 31 2021, 5:14 AM · Restricted Project
mgartmann requested review of D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check.
Mar 31 2021, 3:09 AM · Restricted Project