Page MenuHomePhabricator

mgartmann (Marco Gartmann)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 29 2021, 6:44 AM (72 w, 1 d)

Recent Activity

Oct 4 2021

mgartmann added a comment to D110614: [clang-tidy] Fix false positives in cppcoreguidelines-virtual-class-destructor .

Please excuse my late reply! I have been on vacation for the last two weeks and didn't have the time to respond to this thread until now.

Oct 4 2021, 11:53 AM · Restricted Project

Sep 3 2021

mgartmann added a comment to D102325: [clang-tidy] cppcoreguidelines-virtual-base-class-destructor: a new check.

@whisperity Thanks a lot for helping me out!
Name: Marco Gartmann
E-Mail: gartmannmarco@hotmail.com

Sep 3 2021, 2:30 AM · Restricted Project

Aug 28 2021

mgartmann added a comment to D102325: [clang-tidy] cppcoreguidelines-virtual-base-class-destructor: a new check.

@aaron.ballman Thanks a lot for your review!

Aug 28 2021, 6:33 AM · Restricted Project

Aug 9 2021

mgartmann updated the diff for D102325: [clang-tidy] cppcoreguidelines-virtual-base-class-destructor: a new check.
  • Updated this patch with the current state of the LLVM project GitHub repository
Aug 9 2021, 5:08 AM · Restricted Project

Jun 14 2021

mgartmann added a comment to D102325: [clang-tidy] cppcoreguidelines-virtual-base-class-destructor: a new check.

Thanks a lot for your feedback, @aaron.ballman!

Jun 14 2021, 7:39 AM · Restricted Project
mgartmann updated the diff for D102325: [clang-tidy] cppcoreguidelines-virtual-base-class-destructor: a new check.
  • changed name of check to cppcoreguidelines-virtual-class-destructor
  • removed matcher for class or struct in AST matcher
  • changed string concatenations to use llvm::twine
  • adjusted documentation and removed unnecessary semicolons in it
Jun 14 2021, 7:38 AM · Restricted Project
mgartmann added inline comments to D102779: [clang-tidy] cppcoreguidelines-explicit-constructor-and-conversion: new alias.
Jun 14 2021, 5:47 AM · Restricted Project
mgartmann updated the diff for D102779: [clang-tidy] cppcoreguidelines-explicit-constructor-and-conversion: new alias.
  • removed empty configs from tests
  • moved documentation to Google's check
  • extended matchers so that namespaces for classes and conversion operators can be specified
  • adjusted documentation and tests
Jun 14 2021, 5:40 AM · Restricted Project

Jun 1 2021

mgartmann updated the diff for D102325: [clang-tidy] cppcoreguidelines-virtual-base-class-destructor: a new check.
  • added fixes for private destructors
  • separated fixes for private destructors into notes
  • added a test case for a = default; constructor
Jun 1 2021, 9:08 AM · Restricted Project

May 27 2021

mgartmann updated the diff for D102779: [clang-tidy] cppcoreguidelines-explicit-constructor-and-conversion: new alias.
  • added testcase of explicit operator
May 27 2021, 12:49 PM · Restricted Project

May 26 2021

mgartmann added a comment to D102779: [clang-tidy] cppcoreguidelines-explicit-constructor-and-conversion: new alias.

@aaron.ballman Thanks a lot for your valuable feedback! I incorporated it accordingly.

May 26 2021, 8:27 AM · Restricted Project
mgartmann updated the diff for D102779: [clang-tidy] cppcoreguidelines-explicit-constructor-and-conversion: new alias.
  • added option to ignore conversion operators
  • added tests for new and existing options
  • renamed options to Ignore...
  • ensured that option's strings only get parsed once
May 26 2021, 8:25 AM · Restricted Project

May 24 2021

mgartmann added a comment to D102779: [clang-tidy] cppcoreguidelines-explicit-constructor-and-conversion: new alias.

Dear reviewers,

May 24 2021, 8:24 AM · Restricted Project
mgartmann added a comment to D102325: [clang-tidy] cppcoreguidelines-virtual-base-class-destructor: a new check.

Dear reviewers,

May 24 2021, 8:23 AM · Restricted Project
mgartmann added a comment to D100972: [clang-tidy] cppcoreguidelines-avoid-non-const-global-variables: add fixes to checks.

Dear reviewers,

May 24 2021, 8:22 AM · Restricted Project
mgartmann added a comment to D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check.

Dear reviewers,

May 24 2021, 8:21 AM · Restricted Project

May 20 2021

mgartmann requested review of D102836: [clang] Fix Typo in AST Matcher Reference.
May 20 2021, 3:06 AM · Restricted Project
mgartmann updated the diff for D102779: [clang-tidy] cppcoreguidelines-explicit-constructor-and-conversion: new alias.

Added ConstructorWhitelist option to the google-explicit-constructor check.

May 20 2021, 12:21 AM · Restricted Project

May 19 2021

mgartmann updated the summary of D102779: [clang-tidy] cppcoreguidelines-explicit-constructor-and-conversion: new alias.
May 19 2021, 7:52 AM · Restricted Project
mgartmann requested review of D102779: [clang-tidy] cppcoreguidelines-explicit-constructor-and-conversion: new alias.
May 19 2021, 7:47 AM · Restricted Project

May 15 2021

mgartmann added inline comments to D102325: [clang-tidy] cppcoreguidelines-virtual-base-class-destructor: a new check.
May 15 2021, 7:30 AM · Restricted Project
mgartmann updated the diff for D102325: [clang-tidy] cppcoreguidelines-virtual-base-class-destructor: a new check.

Resolved readability-identifier-naming warning, adjusted check's documentation.

May 15 2021, 7:24 AM · Restricted Project
mgartmann updated the diff for D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check.

Fetched new commits from upstream main branch and resolved merge conflicts.

May 15 2021, 7:00 AM · Restricted Project
mgartmann updated the diff for D102325: [clang-tidy] cppcoreguidelines-virtual-base-class-destructor: a new check.

Incorporated Phabricator review feedback:

  • added matchers and tests for subclasses with inherited virtual methods
  • made aid methods static and not part of the check's class
  • replaced auto with types where it was suggested
  • adjusted diagnostic messages
May 15 2021, 4:18 AM · Restricted Project
mgartmann added a comment to D102325: [clang-tidy] cppcoreguidelines-virtual-base-class-destructor: a new check.

Whats the intended behaviour for derived classes and their destructors? Can test be added to demonstrate that behaviour?

May 15 2021, 4:10 AM · Restricted Project

May 12 2021

mgartmann requested review of D102325: [clang-tidy] cppcoreguidelines-virtual-base-class-destructor: a new check.
May 12 2021, 6:53 AM · Restricted Project
mgartmann updated the diff for D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check.
May 12 2021, 2:32 AM · Restricted Project
mgartmann updated the diff for D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check.

Remove any parentheses and slashes from the check's section in ReleaseNotes.rst in order to try to fix the build.

May 12 2021, 2:20 AM · Restricted Project
mgartmann updated the diff for D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check.

Re-add description for this check in ReleaseNotes.rst.
Adjust AvoidStdIoOutsideMainCheck.cpp third matcher to call hasAnyName() with a vector.

May 12 2021, 1:25 AM · Restricted Project
mgartmann updated the diff for D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check.

Revert ReleaseNotes.rst to its initial content in a try to fix the pre-build tests.

May 12 2021, 12:01 AM · Restricted Project

May 10 2021

mgartmann updated the diff for D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check.

Revert ReleaseNotes.rst to a point where the build worked.

May 10 2021, 6:34 AM · Restricted Project
mgartmann updated the diff for D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check.

Change encoding of patch to UTF-8 in order to fix build.

May 10 2021, 5:57 AM · Restricted Project
mgartmann updated the diff for D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check.

Updated diff to fix the build.

May 10 2021, 5:05 AM · Restricted Project
mgartmann updated the diff for D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check.

Remove trailing whitespaces from documentation file.

May 10 2021, 3:00 AM · Restricted Project

May 9 2021

mgartmann added a comment to D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check.

@njames93 thanks a lot for your answer! I extracted the STD IO stream and C-like function names according to your comment.

May 9 2021, 7:25 AM · Restricted Project
mgartmann updated the diff for D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check.

Extracted STD IO stream and C-like IO function names into vectors.

May 9 2021, 7:21 AM · Restricted Project

Apr 30 2021

mgartmann added a comment to D100972: [clang-tidy] cppcoreguidelines-avoid-non-const-global-variables: add fixes to checks.

Friendly ping, any feedback would be appreciated :)

Apr 30 2021, 5:31 AM · Restricted Project

Apr 28 2021

mgartmann updated the diff for D100972: [clang-tidy] cppcoreguidelines-avoid-non-const-global-variables: add fixes to checks.

Replaced string comparison to check if a character is a space with std::isspace().
Added test case for this scenario.

Apr 28 2021, 5:17 AM · Restricted Project

Apr 25 2021

mgartmann added a comment to D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check.

Friendly ping :)

Apr 25 2021, 11:13 PM · Restricted Project

Apr 22 2021

mgartmann updated the diff for D100972: [clang-tidy] cppcoreguidelines-avoid-non-const-global-variables: add fixes to checks.

Fixed one-off error.

Apr 22 2021, 5:20 AM · Restricted Project
mgartmann updated the diff for D100972: [clang-tidy] cppcoreguidelines-avoid-non-const-global-variables: add fixes to checks.
  • Renamed printCleanedType() to cleanType()
  • Extended cleanType() to also remove (anonymous) from a type
  • Made hasSpaceAfterType() more error-robust.
Apr 22 2021, 4:44 AM · Restricted Project

Apr 21 2021

mgartmann requested review of D100972: [clang-tidy] cppcoreguidelines-avoid-non-const-global-variables: add fixes to checks.
Apr 21 2021, 9:55 AM · Restricted Project

Apr 13 2021

mgartmann added inline comments to D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check.
Apr 13 2021, 11:35 PM · Restricted Project

Apr 7 2021

mgartmann updated the diff for D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check.

Corrected check's entry in list.rst after renaming the check.

Apr 7 2021, 9:20 AM · Restricted Project
mgartmann updated the diff for D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check.
  • Added two new matchers to flag uses of stdio.h/csdtio functions outside of main.
  • Renamed the check to fit those new functionalities.
Apr 7 2021, 2:36 AM · Restricted Project

Apr 1 2021

mgartmann added a comment to D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check.

Is it not wise to also check the c standard library.
So check for function refs to these names in the global or std namespace.
printf, vprintf, puts, putchar, scanf, scanf, getchar and gets
It may be a bit of a pain checking for usages of stdin and stdout due to them being defined as macros.

Apr 1 2021, 6:45 AM · Restricted Project
mgartmann added inline comments to D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check.
Apr 1 2021, 3:17 AM · Restricted Project
mgartmann updated the diff for D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check.

Add isInStdNamespace to matcher so that only global objects in namespace std are matched and add corresponding tests.

Apr 1 2021, 3:12 AM · Restricted Project

Mar 31 2021

mgartmann updated the diff for D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check.

Removed superfluous semicolon in StdStreamObjectsOutsideMainCheck.cpp according to feedback.

Mar 31 2021, 11:38 PM · Restricted Project
mgartmann updated the diff for D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check.

Refactored the code and documentation files according to the feedback received on the first diff.

Mar 31 2021, 2:03 PM · Restricted Project
mgartmann added inline comments to D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check.
Mar 31 2021, 1:55 PM · Restricted Project
mgartmann added a comment to D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check.

I am working on fixing the failing build.

Mar 31 2021, 5:14 AM · Restricted Project
mgartmann requested review of D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check.
Mar 31 2021, 3:09 AM · Restricted Project