Page MenuHomePhabricator

mbs-modular (Mark Shields)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 31 2022, 2:02 PM (12 w, 6 d)

Recent Activity

Sep 21 2022

mbs-modular updated the summary of D133083: [support] Allow TimeProfiler tracing across threads.
Sep 21 2022, 11:56 AM · Restricted Project, Restricted Project
mbs-modular updated the summary of D133083: [support] Allow TimeProfiler tracing across threads.
Sep 21 2022, 11:55 AM · Restricted Project, Restricted Project
mbs-modular removed reviewers for D133083: [support] Allow TimeProfiler tracing across threads: modocache, amonshiz, russell.gallop, aras-p.
Sep 21 2022, 11:53 AM · Restricted Project, Restricted Project
mbs-modular updated the diff for D133083: [support] Allow TimeProfiler tracing across threads.

[support] Allow TimeProfiler tracing across threads

Sep 21 2022, 11:52 AM · Restricted Project, Restricted Project

Sep 15 2022

mbs-modular added a comment to D133153: [support] Prepare TimeProfiler for cross-thread support.
git switch mbs/time_profiler_warmup
git rebase 40ab78
cmake -S llvm -B build -G Ninja -DLLVM_ENABLE_PROJECTS=clang -DLLVM_TARGETS_TO_BUILD=X86 -DCMAKE_BUILD_TYPE=Release -DLLVM_USE_LINKER=lld -DCMAKE_CXX_COMPILER=/usr/bin/clang++ -DCMAKE_C_COMPILER=/usr/bin/clang
cmake --build build
touch clang/lib/Sema/SemaExpr.cpp
cd build
ninja tools/clang/lib/Sema/CMakeFiles/obj.clangSema.dir/SemaExpr.cpp.o -v
Sep 15 2022, 10:51 AM · Restricted Project, Restricted Project, Restricted Project

Sep 14 2022

mbs-modular updated the summary of D133153: [support] Prepare TimeProfiler for cross-thread support.
Sep 14 2022, 6:18 AM · Restricted Project, Restricted Project, Restricted Project
mbs-modular updated the summary of D133153: [support] Prepare TimeProfiler for cross-thread support.
Sep 14 2022, 6:17 AM · Restricted Project, Restricted Project, Restricted Project
mbs-modular updated the diff for D133153: [support] Prepare TimeProfiler for cross-thread support.

[support] Prepare TimeProfiler for cross-thread support

Sep 14 2022, 6:16 AM · Restricted Project, Restricted Project, Restricted Project

Sep 13 2022

mbs-modular added a comment to D133153: [support] Prepare TimeProfiler for cross-thread support.

Thx again, reverted raw_pwrite_stream change, timings look like +3% with -ftime-trace as usual.

Sep 13 2022, 5:15 PM · Restricted Project, Restricted Project, Restricted Project
mbs-modular updated the diff for D133153: [support] Prepare TimeProfiler for cross-thread support.
  • woops, BeginningOfTime must always capture now according to the system
  • Russell's comments
  • Missed two of Russell's comments
  • Project even the default StringRef ctor
  • Revert raw_pwrite_steram change to remove any uncertainty about perf regression.
Sep 13 2022, 5:12 PM · Restricted Project, Restricted Project, Restricted Project
mbs-modular added a comment to D133153: [support] Prepare TimeProfiler for cross-thread support.

Thanks @rriddle

Does the current diff contain all of the intended changes? All of the TimeProfiler changes look NFC.

Yes, this is it, it's supposed to be NFC, and I can't explain @russell.gallop 's claimed regression.
The only mostly-NFC change is I raised the stream type from raw_pwrite_stream to raw_ostream to help the unit tests (trivial as they are).

Sep 13 2022, 1:27 PM · Restricted Project, Restricted Project, Restricted Project

Sep 8 2022

mbs-modular updated the diff for D133153: [support] Prepare TimeProfiler for cross-thread support.
  • woops, BeginningOfTime must always capture now according to the system
  • Russell's comments
  • Missed two of Russell's comments
  • Project even the default StringRef ctor
Sep 8 2022, 2:14 PM · Restricted Project, Restricted Project, Restricted Project
mbs-modular added a comment to D133153: [support] Prepare TimeProfiler for cross-thread support.

friendly ping @russell.gallop

Sep 8 2022, 9:51 AM · Restricted Project, Restricted Project, Restricted Project

Sep 7 2022

mbs-modular added a comment to D133153: [support] Prepare TimeProfiler for cross-thread support.

Afraid I'm out of ideas.

Sep 7 2022, 8:55 PM · Restricted Project, Restricted Project, Restricted Project
mbs-modular added a comment to D133153: [support] Prepare TimeProfiler for cross-thread support.

This is very disturbing!

Sep 7 2022, 11:20 AM · Restricted Project, Restricted Project, Restricted Project

Sep 6 2022

mbs-modular updated the diff for D133153: [support] Prepare TimeProfiler for cross-thread support.
  • Project even the default StringRef ctor
Sep 6 2022, 11:05 AM · Restricted Project, Restricted Project, Restricted Project
mbs-modular added a comment to D133153: [support] Prepare TimeProfiler for cross-thread support.

Thx again @russell.gallop

Sep 6 2022, 10:52 AM · Restricted Project, Restricted Project, Restricted Project
mbs-modular updated the diff for D133153: [support] Prepare TimeProfiler for cross-thread support.
  • woops, BeginningOfTime must always capture now according to the system
  • Russell's comments
  • Missed two of Russell's comments
Sep 6 2022, 10:45 AM · Restricted Project, Restricted Project, Restricted Project

Sep 2 2022

mbs-modular added a comment to D133153: [support] Prepare TimeProfiler for cross-thread support.

Thanks again @russell.gallop, PTAL. BTW am I using arc right? arc diff HEAD~3 --update D133153 seems wrong.

Sep 2 2022, 10:21 AM · Restricted Project, Restricted Project, Restricted Project
mbs-modular added inline comments to D133153: [support] Prepare TimeProfiler for cross-thread support.
Sep 2 2022, 10:14 AM · Restricted Project, Restricted Project, Restricted Project
mbs-modular updated the diff for D133153: [support] Prepare TimeProfiler for cross-thread support.
  • Russell's comments
Sep 2 2022, 10:13 AM · Restricted Project, Restricted Project, Restricted Project

Sep 1 2022

mbs-modular updated the diff for D133153: [support] Prepare TimeProfiler for cross-thread support.
  • Learning arc the hard way.
Sep 1 2022, 3:34 PM · Restricted Project, Restricted Project, Restricted Project
mbs-modular updated the diff for D133153: [support] Prepare TimeProfiler for cross-thread support.
  • woops, BeginningOfTime must always capture now according to the system clock, irrespective of what we use for the profiling clock.
Sep 1 2022, 3:32 PM · Restricted Project, Restricted Project, Restricted Project
mbs-modular abandoned D133162: - woops, BeginningOfTime must always capture now according to the system clock, irrespective of what we use for the profiling clock..
Sep 1 2022, 3:19 PM · Restricted Project, Restricted Project
mbs-modular requested review of D133162: - woops, BeginningOfTime must always capture now according to the system clock, irrespective of what we use for the profiling clock..
Sep 1 2022, 3:18 PM · Restricted Project, Restricted Project
mbs-modular updated the summary of D133153: [support] Prepare TimeProfiler for cross-thread support.
Sep 1 2022, 1:57 PM · Restricted Project, Restricted Project, Restricted Project
mbs-modular updated the summary of D133153: [support] Prepare TimeProfiler for cross-thread support.
Sep 1 2022, 1:56 PM · Restricted Project, Restricted Project, Restricted Project
mbs-modular added reviewers for D133153: [support] Prepare TimeProfiler for cross-thread support: russell.gallop, modocache, amonshiz, aras-p.
Sep 1 2022, 1:56 PM · Restricted Project, Restricted Project, Restricted Project
mbs-modular added a comment to D133083: [support] Allow TimeProfiler tracing across threads.

NFC (mostly!) changes in https://reviews.llvm.org/D133153, will bounce back here after that.

Sep 1 2022, 1:53 PM · Restricted Project, Restricted Project
mbs-modular requested review of D133153: [support] Prepare TimeProfiler for cross-thread support.
Sep 1 2022, 1:52 PM · Restricted Project, Restricted Project, Restricted Project
mbs-modular added a comment to D133083: [support] Allow TimeProfiler tracing across threads.

Does this help with the case @mehdi_amini outlined here: https://reviews.llvm.org/D118550/new/#3323665 ?

If I'm reading correctly that is lamenting the need for each thread to establish and tear down it's own context as a consequence of relying on the TLS profiling context. That's not a concern for us, and the TLS approach seems inevitable given the current push/pop API. A global lock-free ring for all events is probably a better approach, but that's a new impl entirely I think.

Sep 1 2022, 9:41 AM · Restricted Project, Restricted Project

Aug 31 2022

mbs-modular requested review of D133083: [support] Allow TimeProfiler tracing across threads.
Aug 31 2022, 8:07 PM · Restricted Project, Restricted Project