Page MenuHomePhabricator

matthewbauer (Matthew Bauer)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 9 2019, 10:40 AM (44 w, 15 h)

Recent Activity

Apr 17 2019

matthewbauer added inline comments to D60812: Don't error on CMAKE_SYSTEM_NAME=Wasi.
Apr 17 2019, 8:30 AM · Restricted Project
matthewbauer added inline comments to D60812: Don't error on CMAKE_SYSTEM_NAME=Wasi.
Apr 17 2019, 8:30 AM · Restricted Project

Apr 16 2019

matthewbauer created D60812: Don't error on CMAKE_SYSTEM_NAME=Wasi.
Apr 16 2019, 10:18 PM · Restricted Project
matthewbauer added a comment to D60743: Allow building without threads in standalone builds.

Why is this necessary? I just grepped the libc++abi sources, and I see no only two references to _LIBCPP_HAS_NO_THREADS, and they're both in comments (which should be fixed, btw, but that's neither here nor there).

Apr 16 2019, 2:40 PM · Restricted Project
matthewbauer updated the diff for D60743: Allow building without threads in standalone builds.

Added more context for CMakeLists.txt

Apr 16 2019, 8:45 AM · Restricted Project

Apr 15 2019

matthewbauer created D60743: Allow building without threads in standalone builds.
Apr 15 2019, 6:56 PM · Restricted Project

Mar 1 2019

matthewbauer added a comment to D28791: [compiler-rt][crt] Simple crtbegin and crtend implementation.

I was trying to build compiler-rt with WebAssembly and forgot I still had this patched applied. But it looks like it breaks when doing this and things work if you disble crt. You probably just don't want to build crt with WebAssembly targets?

Does WebAssembly build set OS_NAME to "Linux" and architecture to one of x86, x86-64, ARM and ARM64? See config-ix.cmake, specifically this line if (CRT_SUPPORTED_ARCH AND OS_NAME MATCHES "Linux") should ensure that this is only built on Linux and set(ALL_CRT_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64}) should ensure that it's only built for x86, x86-64, ARM and ARM64.

Mar 1 2019, 11:43 AM · Restricted Project, Restricted Project

Feb 28 2019

matthewbauer added a comment to D28791: [compiler-rt][crt] Simple crtbegin and crtend implementation.

I was trying to build compiler-rt with WebAssembly and forgot I still had this patched applied. But it looks like it breaks when doing this and things work if you disble crt. You probably just don't want to build crt with WebAssembly targets?

Feb 28 2019, 11:39 AM · Restricted Project, Restricted Project

Feb 26 2019

matthewbauer added inline comments to D28791: [compiler-rt][crt] Simple crtbegin and crtend implementation.
Feb 26 2019, 12:28 PM · Restricted Project, Restricted Project

Feb 9 2019

Herald added a project to D44248: [clangd][cmake] Provide libatomic when there is no native support for 64bit atomics: Restricted Project.

This appears to be adding atomic on macOS builds, which shouldn't be happening:

Feb 9 2019, 10:46 AM · Restricted Project