Page MenuHomePhabricator

mattbeardsley (Matt Beardsley)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 1 2021, 8:32 PM (6 w, 6 d)

Recent Activity

Tue, Oct 5

mattbeardsley added a comment to D110600: [clang-tidy] Fix add_new_check.py to generate correct list.rst autofix column from relative path.

Works for me! 🙂 I didn't realize you can pull the info automatically from arc. Thanks!

Tue, Oct 5, 9:17 AM · Restricted Project

Mon, Oct 4

mattbeardsley added a comment to D110600: [clang-tidy] Fix add_new_check.py to generate correct list.rst autofix column from relative path.

Thanks! Could you help me commit again when you have time? (same info as here)

Mon, Oct 4, 12:06 PM · Restricted Project

Mon, Sep 27

mattbeardsley requested review of D110600: [clang-tidy] Fix add_new_check.py to generate correct list.rst autofix column from relative path.
Mon, Sep 27, 5:15 PM · Restricted Project

Sep 14 2021

mattbeardsley added a comment to D109210: [clang-tidy] Attach fixit to warning, not note, in add_new_check.py example.

Thanks for your reply and sorry about my very sluggish reply!
I am looking into updating the docs as you suggested, and that got me looking at this doc page. Interestingly, that doc page's version of the add_new_check.py template doesn't have the Note diagnostic. So that got me digging into the history.
It seems like 2 commits are at odds with each other about what the right thing to do is with FixItHints w.r.t. Note vs Warning diagnostics.

Sep 14 2021, 12:13 PM · Restricted Project

Sep 10 2021

mattbeardsley added a comment to D109127: Fix python 2-vs-3 issues in add_new_check.py and rename_check.py.

Thanks! I don't have commit access, I was just reading here what to do:

Prior to obtaining commit access, it is common practice to request that someone with commit access commits on your behalf. When doing so, please provide the name and email address you would like to use in the Author property of the commit.

Sep 10 2021, 3:59 PM · Restricted Project

Sep 3 2021

mattbeardsley added a comment to D109210: [clang-tidy] Attach fixit to warning, not note, in add_new_check.py example.

Ah, and to your direct question:

Sep 3 2021, 3:31 PM · Restricted Project
mattbeardsley added a comment to D109210: [clang-tidy] Attach fixit to warning, not note, in add_new_check.py example.

Uuuh.. I get the sentiment, but this change breaks the very essence of the joke that the default generated code wants to pass on. It also does not showcase that we can emit notes, not just warnings.

How about function %0 is insufficiently awesome, mark it as 'awesome_'! in the warning text? (Note how the fix and the note's text diverged already.)

And so we should come up with a joke for the Note tag.

BTW, the test wasn't checking for the note's message at all?

Sep 3 2021, 3:30 PM · Restricted Project

Sep 2 2021

mattbeardsley requested review of D109210: [clang-tidy] Attach fixit to warning, not note, in add_new_check.py example.
Sep 2 2021, 8:31 PM · Restricted Project
mattbeardsley added a comment to D109127: Fix python 2-vs-3 issues in add_new_check.py and rename_check.py.

No worries! Figured I'd start the conversation with the easy fix, but was fully prepared to hear that we can't let go of python 2 just yet, as much as we may want to :).
Let me know if this fix looks suitable. Thanks for your time!

Sep 2 2021, 1:44 PM · Restricted Project
mattbeardsley updated the diff for D109127: Fix python 2-vs-3 issues in add_new_check.py and rename_check.py.

Reverted python-3-only enforcement, fixed both scripts to work with both python 2 and python 3
(generally based on the guidance here: https://python-future.org/compatible_idioms.html#strings-and-bytes)

Sep 2 2021, 1:42 PM · Restricted Project

Sep 1 2021

mattbeardsley requested review of D109127: Fix python 2-vs-3 issues in add_new_check.py and rename_check.py.
Sep 1 2021, 8:36 PM · Restricted Project