Page MenuHomePhabricator
People maryammo

maryammo (Maryam Moghadas)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 3 2022, 6:09 PM (51 w, 4 h)

Recent Activity
View All

Wed, Mar 22

maryammo added reviewers for D146632: [PowerPC] Fix the xxperm swap requirements: nemanjai, stefanp.
Wed, Mar 22, 7:33 AM · Restricted Project, Restricted Project
maryammo requested review of D146632: [PowerPC] Fix the xxperm swap requirements.
Wed, Mar 22, 7:32 AM · Restricted Project, Restricted Project

Tue, Mar 21

maryammo committed rG155abd0678ab: [PowerPC] Emit warn_deprecated_lax_vec_conv_all warning only for PPC (authored by maryammo).
[PowerPC] Emit warn_deprecated_lax_vec_conv_all warning only for PPC
Tue, Mar 21, 6:51 AM · Restricted Project, Restricted Project
maryammo closed D145506: [PowerPC] Emit warn_deprecated_lax_vec_conv_all warning only for PPC.
Tue, Mar 21, 6:51 AM · Restricted Project, Restricted Project

Mon, Mar 20

maryammo committed rG60b117aa8149: [PowerPC] Adding test coverage for vector compatibility warning (authored by maryammo).
[PowerPC] Adding test coverage for vector compatibility warning
Mon, Mar 20, 10:49 AM · Restricted Project, Restricted Project
maryammo closed D144611: [PowerPC] Adding test coverage for vector compatibility warning.
Mon, Mar 20, 10:48 AM · Restricted Project, Restricted Project

Tue, Mar 7

maryammo added reviewers for D145506: [PowerPC] Emit warn_deprecated_lax_vec_conv_all warning only for PPC: nemanjai, lei, amyk, stefanp.
Tue, Mar 7, 7:31 AM · Restricted Project, Restricted Project
maryammo added a reviewer for D145506: [PowerPC] Emit warn_deprecated_lax_vec_conv_all warning only for PPC: Restricted Project.
Tue, Mar 7, 7:30 AM · Restricted Project, Restricted Project
maryammo requested review of D145506: [PowerPC] Emit warn_deprecated_lax_vec_conv_all warning only for PPC.
Tue, Mar 7, 7:30 AM · Restricted Project, Restricted Project

Feb 23 2023

maryammo added a reviewer for D144611: [PowerPC] Adding test coverage for vector compatibility warning: lei.
Feb 23 2023, 6:45 AM · Restricted Project, Restricted Project

Feb 22 2023

maryammo added reviewers for D144611: [PowerPC] Adding test coverage for vector compatibility warning: nemanjai, amyk, Restricted Project.
Feb 22 2023, 5:37 PM · Restricted Project, Restricted Project
maryammo requested review of D144611: [PowerPC] Adding test coverage for vector compatibility warning.
Feb 22 2023, 5:36 PM · Restricted Project, Restricted Project

Feb 21 2023

maryammo committed rG02a71b05fc67: [PowerPC] Include vector bool and pixel when emitting lax warning (authored by maryammo).
[PowerPC] Include vector bool and pixel when emitting lax warning
Feb 21 2023, 2:26 PM · Restricted Project, Restricted Project
maryammo closed D143210: [PowerPC] Include vector bool and pixel when emitting lax warning.
Feb 21 2023, 2:26 PM · Restricted Project, Restricted Project
maryammo committed rGee815ff2ce8d: [PowerPC] Fix the implicit casting for the emulated intrinsics (authored by maryammo).
[PowerPC] Fix the implicit casting for the emulated intrinsics
Feb 21 2023, 1:45 PM · Restricted Project, Restricted Project
maryammo closed D144293: [PowerPC] Fix the implicit casting for the emulated intrinsics.
Feb 21 2023, 1:45 PM · Restricted Project, Restricted Project
maryammo updated the diff for D144293: [PowerPC] Fix the implicit casting for the emulated intrinsics.

Address review comments

Feb 21 2023, 1:07 PM · Restricted Project, Restricted Project
maryammo added inline comments to D144293: [PowerPC] Fix the implicit casting for the emulated intrinsics.
Feb 21 2023, 1:06 PM · Restricted Project, Restricted Project

Feb 17 2023

maryammo added reviewers for D144293: [PowerPC] Fix the implicit casting for the emulated intrinsics: nemanjai, amyk, stefanp, Restricted Project.
Feb 17 2023, 12:57 PM · Restricted Project, Restricted Project
maryammo requested review of D144293: [PowerPC] Fix the implicit casting for the emulated intrinsics.
Feb 17 2023, 12:54 PM · Restricted Project, Restricted Project

Feb 15 2023

maryammo added inline comments to D143210: [PowerPC] Include vector bool and pixel when emitting lax warning.
Feb 15 2023, 12:27 PM · Restricted Project, Restricted Project

Feb 2 2023

maryammo added reviewers for D143210: [PowerPC] Include vector bool and pixel when emitting lax warning: nemanjai, amyk.
Feb 2 2023, 12:47 PM · Restricted Project, Restricted Project
maryammo requested review of D143210: [PowerPC] Include vector bool and pixel when emitting lax warning.
Feb 2 2023, 12:42 PM · Restricted Project, Restricted Project

Jan 20 2023

maryammo committed rG5b4ed4905017: [PowerPC] Remove the lax warning for explicit casts (authored by maryammo).
[PowerPC] Remove the lax warning for explicit casts
Jan 20 2023, 12:24 PM · Restricted Project, Restricted Project
maryammo closed D142222: [PowerPC] Remove the lax warning for explicit casts.
Jan 20 2023, 12:24 PM · Restricted Project, Restricted Project
maryammo updated the diff for D142222: [PowerPC] Remove the lax warning for explicit casts.

Adding test for template

Jan 20 2023, 9:39 AM · Restricted Project, Restricted Project
maryammo added reviewers for D142222: [PowerPC] Remove the lax warning for explicit casts: nemanjai, stefanp, amyk.
Jan 20 2023, 8:00 AM · Restricted Project, Restricted Project
maryammo requested review of D142222: [PowerPC] Remove the lax warning for explicit casts.
Jan 20 2023, 7:58 AM · Restricted Project, Restricted Project

Jan 13 2023

maryammo added a comment to D141697: [P10] Fix the implementation for BRH.

LGTM

Jan 13 2023, 8:17 AM · Restricted Project, Restricted Project

Dec 1 2022

maryammo committed rGc19f905fed4b: [PowerPC] Implement xscmpeqqp, xscmpgeqp, xscmpgtqp instructions (authored by maryammo).
[PowerPC] Implement xscmpeqqp, xscmpgeqp, xscmpgtqp instructions
Dec 1 2022, 1:02 PM · Restricted Project, Restricted Project
maryammo closed D138592: [PowerPC] Implement xscmpeqqp, xscmpgeqp, xscmpgtqp instructions.
Dec 1 2022, 1:02 PM · Restricted Project, Restricted Project

Nov 29 2022

maryammo committed rG7614ba0a5db8: [PowerPC] Fix vperm codegen (authored by maryammo).
[PowerPC] Fix vperm codegen
Nov 29 2022, 1:47 PM · Restricted Project, Restricted Project
maryammo closed D138736: [PowerPC] Fix vperm codegen.
Nov 29 2022, 1:47 PM · Restricted Project, Restricted Project
maryammo updated the diff for D138736: [PowerPC] Fix vperm codegen.

Address the review comments

Nov 29 2022, 1:40 PM · Restricted Project, Restricted Project
maryammo updated the diff for D138736: [PowerPC] Fix vperm codegen.

Address the review comments

Nov 29 2022, 10:29 AM · Restricted Project, Restricted Project
maryammo added inline comments to D138736: [PowerPC] Fix vperm codegen.
Nov 29 2022, 10:18 AM · Restricted Project, Restricted Project

Nov 25 2022

maryammo added reviewers for D138736: [PowerPC] Fix vperm codegen: stefanp, nemanjai.
Nov 25 2022, 2:14 PM · Restricted Project, Restricted Project
maryammo requested review of D138736: [PowerPC] Fix vperm codegen.
Nov 25 2022, 2:13 PM · Restricted Project, Restricted Project

Nov 23 2022

maryammo committed rG934d5fa2b867: [PowerPC] Exploit xxperm, check for dead vectors and substitute vperm with… (authored by maryammo).
[PowerPC] Exploit xxperm, check for dead vectors and substitute vperm with…
Nov 23 2022, 11:28 AM · Restricted Project, Restricted Project
maryammo closed D133700: [PowerPC] Exploit xxperm, check for dead vectors and substitute vperm with xxperm.
Nov 23 2022, 11:28 AM · Restricted Project, Restricted Project
maryammo added reviewers for D138592: [PowerPC] Implement xscmpeqqp, xscmpgeqp, xscmpgtqp instructions: lei, amyk.
Nov 23 2022, 10:42 AM · Restricted Project, Restricted Project
maryammo requested review of D138592: [PowerPC] Implement xscmpeqqp, xscmpgeqp, xscmpgtqp instructions.
Nov 23 2022, 10:41 AM · Restricted Project, Restricted Project

Nov 21 2022

maryammo committed rGbd68070481d3: [PowerPC] Add new load/store with length instructions to Future CPU. (authored by maryammo).
[PowerPC] Add new load/store with length instructions to Future CPU.
Nov 21 2022, 11:22 AM · Restricted Project, Restricted Project
maryammo closed D136992: [PowerPC] Add new load/store with length instructions to Future CPU..
Nov 21 2022, 11:22 AM · Restricted Project, Restricted Project

Nov 17 2022

maryammo updated the diff for D136992: [PowerPC] Add new load/store with length instructions to Future CPU..

Address review comments and rebase patch to top of main branch

Nov 17 2022, 2:22 PM · Restricted Project, Restricted Project

Nov 16 2022

maryammo updated the diff for D133700: [PowerPC] Exploit xxperm, check for dead vectors and substitute vperm with xxperm.

Unset the hasSideEffects for XXPERM

Nov 16 2022, 12:15 PM · Restricted Project, Restricted Project

Nov 11 2022

maryammo added a comment to D137483: [NFC][PowerPC] Add NFC fixes to PPCInstrinfo.cpp when getting the defined machine instruction..

other than the question regarding DefMI , LGTM.

Nov 11 2022, 10:41 AM · Restricted Project, Restricted Project, Restricted Project

Nov 9 2022

maryammo added a comment to D135859: [Includecleaner] Introduce RefType to ast walking.

@kadircet, this commit causes failure on https://lab.llvm.org/buildbot/#/builders/121 which is possible to reproduce locally, can you please take a look?

Nov 9 2022, 8:48 AM · Restricted Project, Restricted Project

Nov 8 2022

maryammo added a comment to D136723: [include-cleaner] Record main-file macro occurences and includes.

This commit causes build failure on https://lab.llvm.org/buildbot/#/builders/121/builds/24947 :

Nov 8 2022, 1:19 PM · Restricted Project, Restricted Project

Nov 7 2022

maryammo updated the diff for D136992: [PowerPC] Add new load/store with length instructions to Future CPU..

Rebased patch to top of main branch and address the review comments

Nov 7 2022, 6:11 PM · Restricted Project, Restricted Project

Nov 3 2022

maryammo updated the diff for D133700: [PowerPC] Exploit xxperm, check for dead vectors and substitute vperm with xxperm.

Address review comments

Nov 3 2022, 4:01 PM · Restricted Project, Restricted Project

Nov 2 2022

maryammo added inline comments to D133700: [PowerPC] Exploit xxperm, check for dead vectors and substitute vperm with xxperm.
Nov 2 2022, 5:13 PM · Restricted Project, Restricted Project

Nov 1 2022

maryammo added inline comments to D133700: [PowerPC] Exploit xxperm, check for dead vectors and substitute vperm with xxperm.
Nov 1 2022, 4:07 PM · Restricted Project, Restricted Project

Oct 28 2022

maryammo added reviewers for D136992: [PowerPC] Add new load/store with length instructions to Future CPU.: stefanp, lei, amyk.
Oct 28 2022, 3:10 PM · Restricted Project, Restricted Project
maryammo requested review of D136992: [PowerPC] Add new load/store with length instructions to Future CPU..
Oct 28 2022, 3:08 PM · Restricted Project, Restricted Project

Oct 14 2022

maryammo updated the diff for D133700: [PowerPC] Exploit xxperm, check for dead vectors and substitute vperm with xxperm.

Address review comments

Oct 14 2022, 12:59 PM · Restricted Project, Restricted Project

Oct 12 2022

maryammo added inline comments to D133700: [PowerPC] Exploit xxperm, check for dead vectors and substitute vperm with xxperm.
Oct 12 2022, 12:49 PM · Restricted Project, Restricted Project

Sep 26 2022

maryammo updated the diff for D133700: [PowerPC] Exploit xxperm, check for dead vectors and substitute vperm with xxperm.

Address review comments

Sep 26 2022, 10:17 AM · Restricted Project, Restricted Project

Sep 12 2022

maryammo updated the diff for D133700: [PowerPC] Exploit xxperm, check for dead vectors and substitute vperm with xxperm.

NFC

Sep 12 2022, 6:25 PM · Restricted Project, Restricted Project
maryammo updated the diff for D133700: [PowerPC] Exploit xxperm, check for dead vectors and substitute vperm with xxperm.

NFC

Sep 12 2022, 4:39 PM · Restricted Project, Restricted Project
maryammo added reviewers for D133700: [PowerPC] Exploit xxperm, check for dead vectors and substitute vperm with xxperm: nemanjai, stefanp, lei.
Sep 12 2022, 7:32 AM · Restricted Project, Restricted Project
maryammo requested review of D133700: [PowerPC] Exploit xxperm, check for dead vectors and substitute vperm with xxperm.
Sep 12 2022, 7:29 AM · Restricted Project, Restricted Project

Aug 25 2022

Herald added a project to D101605: [PowerPC] Remove extra swap for extract+vperm on LE: Restricted Project.

This patch is functionally incorrect

Aug 25 2022, 7:33 AM · Restricted Project, Restricted Project
maryammo added a comment to rGf7294ac8093a: [PowerPC] Remove extra swap for extract+vperm on LE.
Aug 25 2022, 7:31 AM

Jun 16 2022

maryammo updated the diff for D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions.

Address review comments

Jun 16 2022, 3:47 PM · Restricted Project, Restricted Project

Jun 15 2022

maryammo added inline comments to D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions.
Jun 15 2022, 8:21 PM · Restricted Project, Restricted Project
maryammo added inline comments to D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions.
Jun 15 2022, 8:12 PM · Restricted Project, Restricted Project
maryammo updated the diff for D124093: [PowerPC] Fixing implicit castings in altivec for -fno-lax-vector-conversions.

Updating test cases

Jun 15 2022, 4:45 PM · Restricted Project, Restricted Project, Restricted Project
maryammo updated the diff for D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions.

Fixing unintentional merge from previous commit

Jun 15 2022, 1:27 PM · Restricted Project, Restricted Project
maryammo updated the diff for D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions.

clang-format

Jun 15 2022, 1:12 PM · Restricted Project, Restricted Project
maryammo updated the diff for D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions.

NFC

Jun 15 2022, 1:04 PM · Restricted Project, Restricted Project
maryammo updated the diff for D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions.

NFC

Jun 15 2022, 1:02 PM · Restricted Project, Restricted Project
maryammo updated the diff for D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions.

Address the review comments

Jun 15 2022, 12:53 PM · Restricted Project, Restricted Project
maryammo added inline comments to D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions.
Jun 15 2022, 11:03 AM · Restricted Project, Restricted Project
maryammo added inline comments to D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions.
Jun 15 2022, 10:48 AM · Restricted Project, Restricted Project
maryammo updated the diff for D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions.

Tune the logic to emit warning when at least one of the vectors is altivec one and overloading resolution is done

Jun 15 2022, 7:28 AM · Restricted Project, Restricted Project

May 27 2022

maryammo added reviewers for D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions: nemanjai, lei, amyk, saghir.
May 27 2022, 7:26 AM · Restricted Project, Restricted Project
maryammo updated the diff for D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions.

NFC update

May 27 2022, 7:20 AM · Restricted Project, Restricted Project
maryammo requested review of D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions.
May 27 2022, 7:05 AM · Restricted Project, Restricted Project

May 21 2022

maryammo added a comment to D124093: [PowerPC] Fixing implicit castings in altivec for -fno-lax-vector-conversions.
In D124093#3528639, @amyk wrote:

I was wondering where are the test cases in this patch. Did they get missed when updating the revision?

May 21 2022, 11:24 AM · Restricted Project, Restricted Project, Restricted Project

Apr 26 2022

maryammo added a comment to D124343: [compiler-rt] Use C_STANDARD instead of custom logic for adding -std=c11.
In D124343#3475584, @mstorsjo wrote:
In D124343#3475438, @maryammo wrote:

@mstorsjo, it seems this patch broke the following builds, can you please take a look?

https://lab.llvm.org/buildbot/#/builders/105/builds/24538
https://lab.llvm.org/buildbot/#/builders/121/builds/18755

Sorry about that! I've pushed a revert commit now.

Are you able to figure out why this change broke that configuration?

Apr 26 2022, 3:30 PM · Restricted Project, Restricted Project
maryammo added a comment to D124343: [compiler-rt] Use C_STANDARD instead of custom logic for adding -std=c11.

@mstorsjo, it seems this patch broke the following builds, can you please take a look?

Apr 26 2022, 1:09 PM · Restricted Project, Restricted Project

Apr 25 2022

maryammo updated the diff for D124093: [PowerPC] Fixing implicit castings in altivec for -fno-lax-vector-conversions.

[PowerPC] Address the review comments

Apr 25 2022, 6:03 PM · Restricted Project, Restricted Project, Restricted Project

Apr 21 2022

maryammo added a comment to D123668: [Testing] TestAST, a helper for writing straight-line AST tests.

It seems it breaks the following builds:
https://lab.llvm.org/buildbot/#/builders/121/builds/18618
https://lab.llvm.org/buildbot/#/builders/57/builds/17125

Apr 21 2022, 7:06 PM · Restricted Project, Restricted Project

Apr 20 2022

maryammo updated the diff for D124093: [PowerPC] Fixing implicit castings in altivec for -fno-lax-vector-conversions.

[NFC] Fix the formatting

Apr 20 2022, 3:40 PM · Restricted Project, Restricted Project, Restricted Project
maryammo added reviewers for D124093: [PowerPC] Fixing implicit castings in altivec for -fno-lax-vector-conversions: nemanjai, lei, stefanp, saghir.
Apr 20 2022, 7:56 AM · Restricted Project, Restricted Project, Restricted Project
maryammo requested review of D124093: [PowerPC] Fixing implicit castings in altivec for -fno-lax-vector-conversions.
Apr 20 2022, 7:54 AM · Restricted Project, Restricted Project, Restricted Project

Apr 12 2022

maryammo added a comment to D123300: [Clang] Enable opaque pointers by default.

@nikic, it seems breaking the clang-ppc64le-rhel build

htps://lab.llvm.org/buildbot/#/builders/57/builds/16776

Can you please take a look?

Apr 12 2022, 6:07 PM · Restricted Project, Restricted Project, Restricted Project