Page MenuHomePhabricator
People markmentovai

markmentovai (Mark Mentovai)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 11 2017, 11:27 AM (157 w, 5 d)

Recent Activity
View All

Aug 6 2020

markmentovai added a comment to D85335: [gn] Fix build on macos.

→ https://reviews.llvm.org/D84219

Aug 6 2020, 2:53 PM · Restricted Project
markmentovai updated the diff for D84219: [gn build] mac: use frameworks instead of libs where appropriate.
Aug 6 2020, 2:49 PM · Restricted Project
markmentovai updated the diff for D84219: [gn build] mac: use frameworks instead of libs where appropriate.

Add assertion as discussed

Aug 6 2020, 2:48 PM · Restricted Project

Jul 31 2020

markmentovai added a comment to D84219: [gn build] mac: use frameworks instead of libs where appropriate.

Nico, ping. What do you think about the findings and the options?

Jul 31 2020, 2:25 PM · Restricted Project

Jul 21 2020

markmentovai added a comment to D84219: [gn build] mac: use frameworks instead of libs where appropriate.
In D84219#2164423, @thakis wrote:

Thanks for the patch!

This will break the build with old GNs, right? Should we make this dependent on gn_version to keep both versions working for a while? (As-is, it'll break my mac bot.)

Jul 21 2020, 1:55 PM · Restricted Project

Jul 20 2020

markmentovai updated the diff for D84219: [gn build] mac: use frameworks instead of libs where appropriate.

(full context)

Jul 20 2020, 9:26 PM · Restricted Project
Herald added a project to D84219: [gn build] mac: use frameworks instead of libs where appropriate: Restricted Project.
Jul 20 2020, 9:16 PM · Restricted Project

Aug 23 2019

markmentovai accepted D66633: Breakpad: Add support for parsing STACK WIN records.

LGTM too.

Aug 23 2019, 11:47 AM · Restricted Project

Dec 5 2018

markmentovai added a comment to D55142: Minidump debugging using the native PDB reader.

This seems like a step in the right direction.

Dec 5 2018, 11:55 AM · Restricted Project
markmentovai added inline comments to D55214: Introduce ObjectFileBreakpad.
Dec 5 2018, 7:19 AM

Dec 3 2018

markmentovai added a comment to D55214: Introduce ObjectFileBreakpad.

Very excited to see this work beginning!

Dec 3 2018, 12:43 PM

Oct 29 2018

markmentovai added a comment to D53379: GSYM symbolication format.

I’m glad you’re able to work on this publicly again! I’ve made a pass through just the README.md only at first, just to help nail down the format.

Oct 29 2018, 9:48 AM

Jul 20 2018

markmentovai added a comment to D49579: Support parsing minidump files that are created by Breakpad..

I know, that was a mistake.

Jul 20 2018, 11:03 AM
markmentovai added a comment to D49579: Support parsing minidump files that are created by Breakpad..

This has got to be padding.

Jul 20 2018, 10:52 AM