Changing return type of getExprText to std::optional.

Addressing recent comments.

Addressing comment on VarDecl checks in matcher and early returns.

Addressing the comment on _Generic handling and fixing the machinery to correctly track all DREs.

Rebased and removed spurious changes.

Addressing the recent comments.

Added a new test case.

Updating diff to get rid of white-space changes.

Changing the tests to new format

Addressed some comments. Need to rebase to Artem's changes.

Addressed Erich's comments.

@aaron.ballman: Thanks very much for all the detailed feedback over the past few weeks and for accepting the patch.

Addressed comments on .td file width and placement of notes.

Thank you for the discussion, I think that choice b makes sense to me -- it does mean more markings, but it's also more clear as to why you get a diagnostic and how to repair it.

Thanks for the questions.

Addressed more comments.

Addressing the comments in the new diff.

Addressed the recent comments.

@xazax.hun: Thanks very much for the comments. They are all addressed in the latest diff.

Addressing comments from the review.

Gentle ping.

Thanks very much for the comment and a list of interesting use cases.

Our plan is to first roll out the analysis in the following order:

Attempt to fix build failure.

Apologies about the missing test cases. I had them in the first diff that I uploaded and somehow dropped the file in later diffs.

Addressed all the comments.

Hi Gabor,

Added context.

Cosmetic changes.

1. Added new line at the end of 3 files.
2. Removed an extra space from a file.

Moved the comment to the top of the test.

This update: