- User Since
- May 18 2016, 6:14 AM (186 w, 22 h)
May 27 2019
This patch has now been merged. https://github.com/llvm/llvm-project/commit/bd324fa2273778430a4fdf8371fec5d64d2231bb
May 26 2019
May 14 2019
May 13 2019
Looks good to me :)
Besides my one comment this looks good to me.
Apr 24 2017
Apr 23 2017
Small changes to code due to comments.
Apr 10 2017
Mar 16 2017
Mar 13 2017
Mar 9 2017
Any updates on this?
Mar 1 2017
Looks good for the two tests the are for random_shuffle in llvm libc++.
Last small changes based on comments.
Updated patch according to comments by Ballman.
Feb 27 2017
Minor update to fix spelling mistake.
Feb 26 2017
Made small changes based on comments.
Feb 23 2017
Updated the code based on comments received.
Feb 20 2017
Feb 19 2017
Feb 12 2017
Added comment in CHECK-FIX to ensure the line we are referring to is uniquely identified.
Feb 9 2017
Small change to check.
Minor changes to the lit test.
Feb 8 2017
Jan 23 2017
Looks good to me. Nice touch by solving with implicit.
Jan 12 2017
Looks good to me.
Dec 30 2016
Dec 26 2016
Changes based on comments.
Shortened the ast matcher.
Reviews based on comments. Removed check for suspicious string compare.
Updated according to comments.
Dec 18 2016
Small changes made by suggestions. strCompare is now with uppercase: StrCompare
Dec 15 2016
Updated the matcher to find suggested occurences.
Dec 13 2016
Dec 3 2016
Did as comments suggested: Fixed the description about compare returning -1, 0 or 1. Fixed the ast matcher to only find compare with one argument. Clang-formatted everything. Added a new test (str.compare("foo")) and wrote a FIXME for the fixit.
Dec 1 2016
Fixed broken tests.
Updated according to comments. Still missing fixit.
Nov 30 2016
Trimmed down the ast matcher a little.
Added integerLiteral on both sides of the == operator.
Diff reflecting changes suggested by comments.
Nov 29 2016
Updated per comments
Updated the patch to include changes suggested by comments by JDevlieghere. Other fixes will follow.
Aug 25 2016
Last change - documentation should be fine now.
Aug 24 2016
I have commit access. I can commit it myself :) thanks though.
More suggestions by alexfh fixed.
Fixed suggested by alexfh
Updated the patch as suggested by hokein and alexfh.
May 24 2016
May 23 2016
@alexfh I don't know how I could miss that. But I got my commit access and committed the code myself. Thanks though.
May 21 2016
@Prazek thanks. I will look into it :)
Just curious, as I'm sort of new to this. How long will it take before its merged in?