Page MenuHomePhabricator

madsravn (Mads Ravn)
User

Projects

User does not belong to any projects.

User Details

User Since
May 18 2016, 6:14 AM (186 w, 22 h)

Recent Activity

May 27 2019

madsravn added inline comments to D62404: [clang-tidy] Fix null pointer dereference in readability-identifier-naming.
May 27 2019, 7:31 AM · Restricted Project, Restricted Project, Restricted Project
madsravn added a comment to D61861: DeleteNullPointerCheck now deletes until the end brace of the condition.

This patch has now been merged. https://github.com/llvm/llvm-project/commit/bd324fa2273778430a4fdf8371fec5d64d2231bb

May 27 2019, 12:30 AM · Restricted Project

May 26 2019

madsravn committed rCTE361735: DeleteNullPointerCheck now deletes until the end brace of the condition..
DeleteNullPointerCheck now deletes until the end brace of the condition.
May 26 2019, 9:59 AM
madsravn committed rGbd324fa22737: DeleteNullPointerCheck now deletes until the end brace of the condition. (authored by madsravn).
DeleteNullPointerCheck now deletes until the end brace of the condition.
May 26 2019, 9:59 AM
madsravn committed rL361735: DeleteNullPointerCheck now deletes until the end brace of the condition..
DeleteNullPointerCheck now deletes until the end brace of the condition.
May 26 2019, 9:59 AM

May 14 2019

madsravn added a comment to D61861: DeleteNullPointerCheck now deletes until the end brace of the condition.

Looks good to me :)

Thanks for the review and suggestion, who should I contact now in order to push the patch?

May 14 2019, 1:56 AM · Restricted Project

May 13 2019

madsravn accepted D61861: DeleteNullPointerCheck now deletes until the end brace of the condition.

Looks good to me :)

May 13 2019, 11:45 PM · Restricted Project
madsravn added a comment to D61861: DeleteNullPointerCheck now deletes until the end brace of the condition.

Besides my one comment this looks good to me.

May 13 2019, 11:25 AM · Restricted Project

Apr 24 2017

madsravn committed rL301167: [clang-tidy] New check: modernize-replace-random-shuffle..
[clang-tidy] New check: modernize-replace-random-shuffle.
Apr 24 2017, 2:40 AM
madsravn closed D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle. by committing rL301167: [clang-tidy] New check: modernize-replace-random-shuffle..
Apr 24 2017, 2:40 AM

Apr 23 2017

madsravn added a comment to D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle..

This continues to LGTM; do you need someone to land the patch for you?

Apr 23 2017, 12:34 PM
madsravn updated the diff for D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle..

Small changes to code due to comments.

Apr 23 2017, 4:37 AM

Apr 10 2017

madsravn added a comment to D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle..

Any updates on this?

Have you run it over the test suite on the revision before random_shuffle was removed from libc++?

I can't find any more tests for random_shuffle. I have looked in the SVN log for from december 2014 until now. It works on the three tests currently in trunk.

Try just before r294328.

I can't see any random_shuffle tests in the libc++ repo before r294328 either. I don't know if they aren't there or if I just can't find them. Would you be able to point them out for me with revision and path?

Did you look at the diff from the commit I mentioned? That's the one that removed them.

Apr 10 2017, 9:16 AM

Mar 16 2017

madsravn added a comment to D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle..

Any updates on this?

Have you run it over the test suite on the revision before random_shuffle was removed from libc++?

I can't find any more tests for random_shuffle. I have looked in the SVN log for from december 2014 until now. It works on the three tests currently in trunk.

Try just before r294328.

Mar 16 2017, 8:07 AM

Mar 13 2017

madsravn added a comment to D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle..

Any updates on this?

Have you run it over the test suite on the revision before random_shuffle was removed from libc++?

Mar 13 2017, 5:14 AM

Mar 9 2017

madsravn added a comment to D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle..

Any updates on this?

Mar 9 2017, 6:15 AM

Mar 1 2017

madsravn added a comment to D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle..

Looks good for the two tests the are for random_shuffle in llvm libc++.

Mar 1 2017, 2:21 PM
madsravn added a comment to D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle..

Out of curiosity, have you run this over libc++ or libstdc++ test suites involving std::random_shuffle? If so, were the results acceptable?

Mar 1 2017, 1:42 PM
madsravn updated the diff for D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle..

Last small changes based on comments.

Mar 1 2017, 1:40 PM
madsravn added inline comments to D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle..
Mar 1 2017, 11:57 AM
madsravn added inline comments to D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle..
Mar 1 2017, 11:49 AM
madsravn added inline comments to D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle..
Mar 1 2017, 11:16 AM
madsravn added inline comments to D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle..
Mar 1 2017, 3:26 AM
madsravn updated the diff for D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle..

Updated patch according to comments by Ballman.

Mar 1 2017, 3:21 AM

Feb 27 2017

madsravn updated the diff for D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle..

Minor update to fix spelling mistake.

Feb 27 2017, 12:40 PM

Feb 26 2017

madsravn updated the diff for D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle..

Made small changes based on comments.

Feb 26 2017, 2:02 PM

Feb 23 2017

madsravn added inline comments to D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle..
Feb 23 2017, 12:03 PM
madsravn updated the diff for D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle..

Updated the code based on comments received.

Feb 23 2017, 12:00 PM

Feb 20 2017

madsravn added inline comments to D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle..
Feb 20 2017, 2:42 AM
madsravn added inline comments to D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle..
Feb 20 2017, 2:31 AM
madsravn added inline comments to D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle..
Feb 20 2017, 1:49 AM

Feb 19 2017

madsravn created D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle..
Feb 19 2017, 11:11 AM

Feb 12 2017

madsravn committed rL294913: [clang-tidy] Fix for bug 31838: readability-delete-null-pointer does not work….
[clang-tidy] Fix for bug 31838: readability-delete-null-pointer does not work…
Feb 12 2017, 12:47 PM
madsravn committed rL294912: [clang-tidy] Fix for bug 31838: readability-delete-null-pointer does not work….
[clang-tidy] Fix for bug 31838: readability-delete-null-pointer does not work…
Feb 12 2017, 12:21 PM
madsravn closed D29726: [Clang-tidy] Fix for bug 31838: readability-delete-null-pointer does not work for class members by committing rL294912: [clang-tidy] Fix for bug 31838: readability-delete-null-pointer does not work….
Feb 12 2017, 12:21 PM
madsravn updated the diff for D29726: [Clang-tidy] Fix for bug 31838: readability-delete-null-pointer does not work for class members.

Added comment in CHECK-FIX to ensure the line we are referring to is uniquely identified.

Feb 12 2017, 6:54 AM

Feb 9 2017

madsravn added inline comments to D29726: [Clang-tidy] Fix for bug 31838: readability-delete-null-pointer does not work for class members.
Feb 9 2017, 10:03 AM
madsravn updated the diff for D29726: [Clang-tidy] Fix for bug 31838: readability-delete-null-pointer does not work for class members.

Small change to check.
Minor changes to the lit test.

Feb 9 2017, 10:02 AM

Feb 8 2017

madsravn created D29726: [Clang-tidy] Fix for bug 31838: readability-delete-null-pointer does not work for class members.
Feb 8 2017, 12:11 PM

Jan 23 2017

madsravn added a comment to D29018: [clang-tidy] Ignore implicit functions in performance-unnecessary-value-param.

Looks good to me. Nice touch by solving with implicit.

Jan 23 2017, 5:19 AM

Jan 12 2017

madsravn added a comment to D28614: [clang-tidy] Fix check for trivially copyable types in modernize-pass-by-value.

Looks good to me.

Jan 12 2017, 9:54 AM

Dec 30 2016

madsravn committed rL290766: [clang] Minor fix to libASTMatcherTutorial.
[clang] Minor fix to libASTMatcherTutorial
Dec 30 2016, 1:00 PM
madsravn closed D28180: Fixing small errors in libAST Matcher Tutorial. by committing rL290766: [clang] Minor fix to libASTMatcherTutorial.
Dec 30 2016, 1:00 PM
madsravn retitled D28180: Fixing small errors in libAST Matcher Tutorial. from to Fixing small errors in libAST Matcher Tutorial. .
Dec 30 2016, 10:54 AM
madsravn committed rL290747: [clang-tidy] Add check 'misc-string-compare'..
[clang-tidy] Add check 'misc-string-compare'.
Dec 30 2016, 2:20 AM
madsravn closed D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy by committing rL290747: [clang-tidy] Add check 'misc-string-compare'..
Dec 30 2016, 2:20 AM

Dec 26 2016

madsravn updated the diff for D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy.

Changes based on comments.
Shortened the ast matcher.

Dec 26 2016, 3:31 PM
madsravn added inline comments to D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy.
Dec 26 2016, 3:01 PM
madsravn updated the diff for D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy.

Reviews based on comments. Removed check for suspicious string compare.

Dec 26 2016, 2:03 PM
madsravn added inline comments to D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy.
Dec 26 2016, 11:48 AM
madsravn updated the diff for D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy.

Updated according to comments.

Dec 26 2016, 10:35 AM

Dec 18 2016

madsravn updated the diff for D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy.

Small changes made by suggestions. strCompare is now with uppercase: StrCompare

Dec 18 2016, 9:22 AM

Dec 15 2016

madsravn updated the diff for D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy.

Updated the matcher to find suggested occurences.

Dec 15 2016, 10:14 AM

Dec 13 2016

madsravn updated the diff for D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy.

Updated matcher.

Dec 13 2016, 11:12 AM

Dec 3 2016

madsravn updated the diff for D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy.

Did as comments suggested: Fixed the description about compare returning -1, 0 or 1. Fixed the ast matcher to only find compare with one argument. Clang-formatted everything. Added a new test (str.compare("foo")) and wrote a FIXME for the fixit.

Dec 3 2016, 4:34 AM

Dec 1 2016

madsravn updated the diff for D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy.

Fixed broken tests.

Dec 1 2016, 11:52 AM
madsravn updated the diff for D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy.

Updated according to comments. Still missing fixit.

Dec 1 2016, 11:26 AM

Nov 30 2016

madsravn updated the diff for D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy.

Trimmed down the ast matcher a little.

Nov 30 2016, 11:19 AM
madsravn updated the diff for D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy.

Added integerLiteral on both sides of the == operator.

Nov 30 2016, 8:30 AM
madsravn updated the diff for D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy.

Diff reflecting changes suggested by comments.

Nov 30 2016, 6:14 AM

Nov 29 2016

madsravn updated the diff for D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy.

Updated per comments

Nov 29 2016, 1:06 PM
madsravn updated the diff for D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy.

Updated the patch to include changes suggested by comments by JDevlieghere. Other fixes will follow.

Nov 29 2016, 11:24 AM
madsravn added a comment to D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy.

You might also want to add a few tests cases, for instance the ones you used as examples in the documentation.

Nov 29 2016, 6:52 AM
madsravn retitled D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy from to [clang-tidy] misc-string-compare. Adding a new check to clang-tidy.
Nov 29 2016, 5:57 AM

Aug 25 2016

madsravn committed rL279803: [clang-tidy] Added hh, hxx and hpp to header guard checks..
[clang-tidy] Added hh, hxx and hpp to header guard checks.
Aug 25 2016, 11:08 PM
madsravn closed D20512: [PATCH] Bug 27475 - Request header guard check processes .hpp files as well as .h files by committing rL279803: [clang-tidy] Added hh, hxx and hpp to header guard checks..
Aug 25 2016, 11:08 PM
madsravn updated the diff for D20512: [PATCH] Bug 27475 - Request header guard check processes .hpp files as well as .h files .

Last change - documentation should be fine now.

Aug 25 2016, 8:12 AM

Aug 24 2016

madsravn added inline comments to D20512: [PATCH] Bug 27475 - Request header guard check processes .hpp files as well as .h files .
Aug 24 2016, 1:24 PM
madsravn updated the diff for D20512: [PATCH] Bug 27475 - Request header guard check processes .hpp files as well as .h files .
Aug 24 2016, 1:24 PM
madsravn added a comment to D20512: [PATCH] Bug 27475 - Request header guard check processes .hpp files as well as .h files .

I have commit access. I can commit it myself :) thanks though.

Aug 24 2016, 12:56 PM
madsravn updated the diff for D20512: [PATCH] Bug 27475 - Request header guard check processes .hpp files as well as .h files .

Documentation fix.

Aug 24 2016, 12:55 PM
madsravn updated the diff for D20512: [PATCH] Bug 27475 - Request header guard check processes .hpp files as well as .h files .

More suggestions by alexfh fixed.

Aug 24 2016, 12:14 PM
madsravn updated the diff for D20512: [PATCH] Bug 27475 - Request header guard check processes .hpp files as well as .h files .

Fixed suggested by alexfh

Aug 24 2016, 11:12 AM
madsravn updated the diff for D20512: [PATCH] Bug 27475 - Request header guard check processes .hpp files as well as .h files .

Updated the patch as suggested by hokein and alexfh.

Aug 24 2016, 9:38 AM

May 24 2016

madsravn closed D20510: [PATCH] Fix for bug 27802 misc-macro-parentheses breaks variadic macros.

Code committed.

May 24 2016, 10:39 PM
madsravn committed rL270575: [clang-tidy] modernize-pass-by-value bugfix. Reverting lit-style test.
[clang-tidy] modernize-pass-by-value bugfix. Reverting lit-style test
May 24 2016, 9:15 AM
madsravn committed rL270567: [clang-tidy] modernize-pass-by-value bugfix. Reverting lit-style test.
[clang-tidy] modernize-pass-by-value bugfix. Reverting lit-style test
May 24 2016, 8:20 AM
madsravn committed rL270565: [clang-tidy] modernize-pass-by-value bugfix.
[clang-tidy] modernize-pass-by-value bugfix
May 24 2016, 8:06 AM

May 23 2016

madsravn added a comment to D20365: [PATCH] clang-tidy: Bug 27731 - modernize-pass-by-value suggest using std::move for types that perform copies on move.

@alexfh I don't know how I could miss that. But I got my commit access and committed the code myself. Thanks though.

May 23 2016, 11:01 PM
madsravn committed rL270473: Commiting for http://reviews.llvm.org/D20365.
Commiting for http://reviews.llvm.org/D20365
May 23 2016, 11:33 AM
madsravn closed D20365: [PATCH] clang-tidy: Bug 27731 - modernize-pass-by-value suggest using std::move for types that perform copies on move.

Code committed.

May 23 2016, 11:22 AM
madsravn committed rL270472: Commiting for http://reviews.llvm.org/D20365.
Commiting for http://reviews.llvm.org/D20365
May 23 2016, 11:22 AM
madsravn committed rL270470: Commiting for http://reviews.llvm.org/D20365.
Commiting for http://reviews.llvm.org/D20365
May 23 2016, 11:13 AM
madsravn added inline comments to D20512: [PATCH] Bug 27475 - Request header guard check processes .hpp files as well as .h files .
May 23 2016, 9:21 AM

May 21 2016

madsravn retitled D20512: [PATCH] Bug 27475 - Request header guard check processes .hpp files as well as .h files from to [PATCH] Bug 27475 - Request header guard check processes .hpp files as well as .h files .
May 21 2016, 1:38 PM
madsravn retitled D20510: [PATCH] Fix for bug 27802 misc-macro-parentheses breaks variadic macros from to [PATCH] Fix for bug 27802 misc-macro-parentheses breaks variadic macros.
May 21 2016, 8:24 AM
madsravn added a comment to D20365: [PATCH] clang-tidy: Bug 27731 - modernize-pass-by-value suggest using std::move for types that perform copies on move.

@Prazek thanks. I will look into it :)

May 21 2016, 8:23 AM
madsravn added a comment to D20365: [PATCH] clang-tidy: Bug 27731 - modernize-pass-by-value suggest using std::move for types that perform copies on move.

Just curious, as I'm sort of new to this. How long will it take before its merged in?

May 21 2016, 5:47 AM

May 18 2016

madsravn retitled D20365: [PATCH] clang-tidy: Bug 27731 - modernize-pass-by-value suggest using std::move for types that perform copies on move from to [PATCH] clang-tidy: Bug 27731 - modernize-pass-by-value suggest using std::move for types that perform copies on move.
May 18 2016, 6:20 AM