Page MenuHomePhabricator

m1cha (Michael Zimmermann)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 10 2021, 12:58 PM (27 w, 2 d)

Recent Activity

Jul 31 2021

m1cha added a comment to D106349: [clang-format] respect AfterEnum for enums.

Well it's pretty much exactly the same except for the change in ShouldBreakBeforeBrace.
Somebody with more knowledge about clang-format than me should try to figure out why it's not needed.

Jul 31 2021, 8:38 AM · Restricted Project

Jul 29 2021

m1cha added a comment to D106349: [clang-format] respect AfterEnum for enums.

I don't have commit access. How does that even work? The documentation is very scarce about this but for security reasons I'd expect there to be a very limited set of people with commit access

Jul 29 2021, 1:02 PM · Restricted Project

Jul 25 2021

m1cha updated the diff for D106349: [clang-format] respect AfterEnum for enums.

I've added a note to ReleaseNotes.rst

Jul 25 2021, 12:49 AM · Restricted Project

Jul 23 2021

m1cha added a comment to D106349: [clang-format] respect AfterEnum for enums.

Looks good, could you also add a note in the relasenotes.rst?

Jul 23 2021, 10:16 AM · Restricted Project

Jul 22 2021

m1cha updated the diff for D106349: [clang-format] respect AfterEnum for enums.
  • rebased to main
  • fixed the test IndentAccessModifiers
Jul 22 2021, 5:31 AM · Restricted Project

Jul 20 2021

m1cha added a comment to D106349: [clang-format] respect AfterEnum for enums.

I just noticed that phabricator strips the commit message so here it is:

Jul 20 2021, 1:35 AM · Restricted Project
m1cha requested review of D106349: [clang-format] respect AfterEnum for enums.
Jul 20 2021, 1:30 AM · Restricted Project