Page MenuHomePhabricator

luken-google (Luke Nihlen)
User

Projects

User does not belong to any projects.

User Details

User Since
May 30 2022, 8:50 AM (10 w, 3 d)

Recent Activity

Jun 15 2022

luken-google abandoned D127748: Adds a warning for aligned new in MSVC before C++17.

Probably better to address this in the Driver. See also https://reviews.llvm.org/D127641. I'm going to close this for now and see if we want to revisit after that lands or as part of that change.

Jun 15 2022, 7:06 AM · Restricted Project, Restricted Project

Jun 14 2022

luken-google added a reviewer for D127748: Adds a warning for aligned new in MSVC before C++17: hans.
Jun 14 2022, 8:07 AM · Restricted Project, Restricted Project
luken-google abandoned D127683: Adds a warning for aligned new in MSVC before C++17.

Mistakenly updated change here: https://reviews.llvm.org/D127748

Jun 14 2022, 8:05 AM · Restricted Project, Restricted Project
luken-google requested review of D127748: Adds a warning for aligned new in MSVC before C++17.
Jun 14 2022, 8:03 AM · Restricted Project, Restricted Project

Jun 13 2022

luken-google requested review of D127683: Adds a warning for aligned new in MSVC before C++17.
Jun 13 2022, 12:23 PM · Restricted Project, Restricted Project

Jun 1 2022

luken-google updated the diff for D126664: Expand definition deprecation warning to include constexpr statements..

Squash commit to include original changes.

Jun 1 2022, 7:55 AM · Restricted Project, Restricted Project
luken-google added a comment to D126664: Expand definition deprecation warning to include constexpr statements..

Thanks for the review! I do need someone to commit on my behalf. Please commit with name "Luke Nihlen" and email address "luken@google.com".

Jun 1 2022, 7:35 AM · Restricted Project, Restricted Project
luken-google updated the diff for D126664: Expand definition deprecation warning to include constexpr statements..

Add release note.

Jun 1 2022, 7:32 AM · Restricted Project, Restricted Project

May 30 2022

luken-google added reviewers for D126664: Expand definition deprecation warning to include constexpr statements.: rsmith, thakis.
May 30 2022, 9:22 AM · Restricted Project, Restricted Project
luken-google requested review of D126664: Expand definition deprecation warning to include constexpr statements..
May 30 2022, 9:18 AM · Restricted Project, Restricted Project