Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

lukasza (Łukasz Anforowicz)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 6 2016, 10:12 AM (378 w, 2 d)

Recent Activity

Sep 13 2023

lukasza added a comment to D158532: Anonymous unions should be transparent wrt `[[clang::trivial_abi]]`..

@gribozavr2 - ping?

Sep 13 2023, 4:48 PM · Restricted Project, Restricted Project

Aug 22 2023

lukasza added a comment to D158532: Anonymous unions should be transparent wrt `[[clang::trivial_abi]]`..

The delta from https://reviews.llvm.org/D155895 is in clang/test/SemaCXX/attr-trivial-abi.cpp where 1) a comment has been added above the non-trivial move constructor of the Trivial test helper and 2) test expectations have been tweaked to account for _WIN64 and __MINGW32__ (cargo-culting these conditions from the already-existing tests in the top part of this test file).

Aug 22 2023, 11:00 AM · Restricted Project, Restricted Project
lukasza requested review of D158532: Anonymous unions should be transparent wrt `[[clang::trivial_abi]]`..
Aug 22 2023, 10:57 AM · Restricted Project, Restricted Project

Aug 7 2023

lukasza added a comment to D155895: Anonymous unions should be transparent wrt `[[clang::trivial_abi]]`..

Looks like this breaks tests on windows: http://45.33.8.238/win/82239/step_7.txt

Aug 7 2023, 12:20 PM · Restricted Project, Restricted Project
lukasza updated the diff for D155895: Anonymous unions should be transparent wrt `[[clang::trivial_abi]]`..

More granular usage of #if defined(CLANG_ABI_COMPAT) && ... in tests

Aug 7 2023, 10:53 AM · Restricted Project, Restricted Project

Jul 26 2023

lukasza updated the diff for D155895: Anonymous unions should be transparent wrt `[[clang::trivial_abi]]`..

Rebasing...

Jul 26 2023, 12:47 PM · Restricted Project, Restricted Project
lukasza updated the diff for D155895: Anonymous unions should be transparent wrt `[[clang::trivial_abi]]`..

Added support for -fclang-abi-compat=17

Jul 26 2023, 12:39 PM · Restricted Project, Restricted Project

Jul 24 2023

lukasza added a comment to D155895: Anonymous unions should be transparent wrt `[[clang::trivial_abi]]`..

@lukasza I think you forgot to upload an updated version of the patch.

Jul 24 2023, 9:36 AM · Restricted Project, Restricted Project
lukasza abandoned D156003: Anonymous unions should be transparent wrt `[[clang::trivial_abi]]`..
Jul 24 2023, 9:36 AM · Restricted Project, Restricted Project
lukasza abandoned D156004: s/ #include <queue> / #include "llvm/ADT/SmallVector.h" /.
Jul 24 2023, 9:36 AM · Restricted Project, Restricted Project
lukasza updated the diff for D155895: Anonymous unions should be transparent wrt `[[clang::trivial_abi]]`..

Addressed feedback from @gribozavr2

Jul 24 2023, 9:33 AM · Restricted Project, Restricted Project

Jul 21 2023

lukasza added a comment to D156004: s/ #include <queue> / #include "llvm/ADT/SmallVector.h" /.

https://llvm.org/docs/MyFirstTypoFix.html#updating-your-change told me to run arc diff... not sure if I should abandon the original revision and reupload a cleaned-up fix instead?

Jul 21 2023, 3:44 PM · Restricted Project, Restricted Project
lukasza added a reviewer for D156004: s/ #include <queue> / #include "llvm/ADT/SmallVector.h" /: gribozavr2.
Jul 21 2023, 3:43 PM · Restricted Project, Restricted Project
lukasza added a reviewer for D156003: Anonymous unions should be transparent wrt `[[clang::trivial_abi]]`.: gribozavr2.
Jul 21 2023, 3:43 PM · Restricted Project, Restricted Project
lukasza requested review of D156004: s/ #include <queue> / #include "llvm/ADT/SmallVector.h" /.
Jul 21 2023, 3:39 PM · Restricted Project, Restricted Project
lukasza added inline comments to D155895: Anonymous unions should be transparent wrt `[[clang::trivial_abi]]`..
Jul 21 2023, 3:37 PM · Restricted Project, Restricted Project
lukasza requested review of D156003: Anonymous unions should be transparent wrt `[[clang::trivial_abi]]`..
Jul 21 2023, 3:36 PM · Restricted Project, Restricted Project

Jul 20 2023

lukasza added a reviewer for D155895: Anonymous unions should be transparent wrt `[[clang::trivial_abi]]`.: rsmith.
Jul 20 2023, 3:14 PM · Restricted Project, Restricted Project
lukasza added inline comments to D155895: Anonymous unions should be transparent wrt `[[clang::trivial_abi]]`..
Jul 20 2023, 3:13 PM · Restricted Project, Restricted Project
lukasza retitled D155895: Anonymous unions should be transparent wrt `[[clang::trivial_abi]]`. from git squash commit for trivial-abi-vs-anonymous-unions. to Anonymous unions should be transparent wrt `[[clang::trivial_abi]]`..
Jul 20 2023, 3:06 PM · Restricted Project, Restricted Project
lukasza requested review of D155895: Anonymous unions should be transparent wrt `[[clang::trivial_abi]]`..
Jul 20 2023, 3:05 PM · Restricted Project, Restricted Project

Nov 29 2016

lukasza added inline comments to D27207: Adds hasUnqualifiedDesugaredType to allow matching through type sugar..
Nov 29 2016, 2:26 PM
lukasza added a comment to D27207: Adds hasUnqualifiedDesugaredType to allow matching through type sugar..

I've tried replicating the deep-matching by saying qualType(hasType(hasUnqualifiedDesugaredType(hasDeclaration(... but this doesn't work because hasDeclaration only returns a matcher for a specific type from a subset of subclasses of Type - this is incompatible with expectations of the proposed hasUnqualifiedDesugaredType which takes a Matcher<Type>.

Nov 29 2016, 2:14 PM
lukasza added a comment to D27104: Unify and simplify the behavior of the hasDeclaration matcher..

Do we also need to update the documentation (e.g. to say that ElaboratedType is covered by hasDeclaration)?

Nov 29 2016, 1:58 PM

Nov 28 2016

lukasza added a comment to D27104: Unify and simplify the behavior of the hasDeclaration matcher..

Forcing shallow matching means that unit test below will stop passing after this CL.

Nov 28 2016, 3:21 PM

Oct 31 2016

lukasza added a comment to D26032: [ASTMatcher] Add CXXNewExpr support to hasDeclaration.

FWIW, a non-owner LGTM:

  • CXXNewExpr seems very similar to CallExpr, so it makes sense that hasDeclaration would behave similarily for both of these expressions (i.e. matching the "callee")
  • The issues we've been trying to work through in https://reviews.llvm.org/D24361 mainly revolve around Type and QualType, so I think those issues should not apply to CXXNewExpr matching.
Oct 31 2016, 9:54 AM

Oct 24 2016

lukasza updated the diff for D24361: hasDeclaration(qualType(...)) matcher should unwrap ElaboratedType and TemplateSpecializationType .

Reverted changes in the patch that are not related to the issue of hasDeclaration not matching *anything* in some cases.

Oct 24 2016, 5:05 PM

Oct 3 2016

lukasza added a comment to D24361: hasDeclaration(qualType(...)) matcher should unwrap ElaboratedType and TemplateSpecializationType .

Richard - what are the next steps for this patch?

Oct 3 2016, 2:20 PM

Sep 26 2016

lukasza added inline comments to D24361: hasDeclaration(qualType(...)) matcher should unwrap ElaboratedType and TemplateSpecializationType .
Sep 26 2016, 9:57 AM

Sep 23 2016

lukasza added inline comments to D24361: hasDeclaration(qualType(...)) matcher should unwrap ElaboratedType and TemplateSpecializationType .
Sep 23 2016, 1:55 PM
lukasza updated the diff for D24361: hasDeclaration(qualType(...)) matcher should unwrap ElaboratedType and TemplateSpecializationType .
  • Added test where both TemplateSpecializationType and TypedefType are present and both should match regardless of code order inside HasDeclarationMatcher::matchesSpecialized(const QualType &Node...). Removed significance of order inside this matchesSpecialized method.
Sep 23 2016, 1:54 PM

Sep 16 2016

lukasza added a comment to D24361: hasDeclaration(qualType(...)) matcher should unwrap ElaboratedType and TemplateSpecializationType .

Richard, could you please take a look?

Sep 16 2016, 5:34 PM

Sep 13 2016

lukasza closed D24268: Traversing template paramter lists of DeclaratorDecls and/or TagDecls..
Sep 13 2016, 8:53 AM
lukasza updated D24361: hasDeclaration(qualType(...)) matcher should unwrap ElaboratedType and TemplateSpecializationType .
Sep 13 2016, 8:51 AM
lukasza updated subscribers of D24361: hasDeclaration(qualType(...)) matcher should unwrap ElaboratedType and TemplateSpecializationType .
Sep 13 2016, 8:43 AM

Sep 8 2016

lukasza added a comment to D24361: hasDeclaration(qualType(...)) matcher should unwrap ElaboratedType and TemplateSpecializationType .

I am assuming that the expectation I expressed in the unit test is a valid/correct expectation. I guess this is the first thing to validate/ack in the review :-)

Sep 8 2016, 12:21 PM
lukasza retitled D24361: hasDeclaration(qualType(...)) matcher should unwrap ElaboratedType and TemplateSpecializationType from to hasDeclaration(qualType(...)) matcher should unwrap ElaboratedType and TemplateSpecializationType .
Sep 8 2016, 12:15 PM

Sep 7 2016

lukasza added a comment to D24268: Traversing template paramter lists of DeclaratorDecls and/or TagDecls..

This patch looks great, thank you! Do you have an SVN account or do you need someone to commit this for you?

Sep 7 2016, 12:28 PM

Sep 6 2016

lukasza added inline comments to D24268: Traversing template paramter lists of DeclaratorDecls and/or TagDecls..
Sep 6 2016, 3:47 PM
lukasza updated the diff for D24268: Traversing template paramter lists of DeclaratorDecls and/or TagDecls..

Addressing CR feedbackfrom rsmith@.

Sep 6 2016, 3:47 PM
lukasza added inline comments to D24268: Traversing template paramter lists of DeclaratorDecls and/or TagDecls..
Sep 6 2016, 11:08 AM
lukasza retitled D24268: Traversing template paramter lists of DeclaratorDecls and/or TagDecls. from to Traversing template paramter lists of DeclaratorDecls and/or TagDecls..
Sep 6 2016, 10:27 AM