Page MenuHomePhabricator

llitchev (Lubomir Litchev)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 28 2020, 11:02 AM (73 w, 2 d)

Recent Activity

Jan 11 2021

llitchev abandoned D93625: [NFC] [TEST] Fix the threads.ll for Windows.

That makes sense. If it works and there is no need to verify the tests passes for Windows (with Windows configuration) what we have in master is fine.

Jan 11 2021, 12:44 PM · Restricted Project

Dec 21 2020

llitchev updated the diff for D91556: [OpenMPIRBuilder} Add capturing of parameters to pass to omp::parallel.

Fixed a casing issue with a local var.

Dec 21 2020, 3:57 AM · Restricted Project, Restricted Project, Restricted Project
llitchev requested review of D93625: [NFC] [TEST] Fix the threads.ll for Windows.
Dec 21 2020, 3:18 AM · Restricted Project
llitchev updated the diff for D91556: [OpenMPIRBuilder} Add capturing of parameters to pass to omp::parallel.

Some minor optimizations related to CR.

Dec 21 2020, 2:11 AM · Restricted Project, Restricted Project, Restricted Project
llitchev updated the diff for D91556: [OpenMPIRBuilder} Add capturing of parameters to pass to omp::parallel.

Removed the changes from threads.ll.

Dec 21 2020, 2:04 AM · Restricted Project, Restricted Project, Restricted Project
llitchev added inline comments to D91556: [OpenMPIRBuilder} Add capturing of parameters to pass to omp::parallel.
Dec 21 2020, 1:56 AM · Restricted Project, Restricted Project, Restricted Project
llitchev updated the diff for D91556: [OpenMPIRBuilder} Add capturing of parameters to pass to omp::parallel.

Addressed CR.

Dec 21 2020, 1:55 AM · Restricted Project, Restricted Project, Restricted Project

Dec 14 2020

llitchev updated the diff for D91556: [OpenMPIRBuilder} Add capturing of parameters to pass to omp::parallel.

Added separate tests for Windows for specific tests.

Dec 14 2020, 1:51 PM · Restricted Project, Restricted Project, Restricted Project
llitchev updated the diff for D91556: [OpenMPIRBuilder} Add capturing of parameters to pass to omp::parallel.

Fixed a failing Windows test. The issue is that that the order of the operands for add operation has changed. I cant see how these changes could cause the issue, but it is a failing test that blocks push of this Diff.

Dec 14 2020, 10:32 AM · Restricted Project, Restricted Project, Restricted Project
llitchev updated the diff for D91556: [OpenMPIRBuilder} Add capturing of parameters to pass to omp::parallel.

Merged in master.

Dec 14 2020, 5:25 AM · Restricted Project, Restricted Project, Restricted Project
llitchev retitled D91556: [OpenMPIRBuilder} Add capturing of parameters to pass to omp::parallel from Add capturing of parameters to pass to omp::parallel to [OpenMPIRBuilder} Add capturing of parameters to pass to omp::parallel.
Dec 14 2020, 5:21 AM · Restricted Project, Restricted Project, Restricted Project

Dec 13 2020

llitchev planned changes to D91556: [OpenMPIRBuilder} Add capturing of parameters to pass to omp::parallel.

Needed merges with the latest master.

Dec 13 2020, 4:06 PM · Restricted Project, Restricted Project, Restricted Project
llitchev added inline comments to D91556: [OpenMPIRBuilder} Add capturing of parameters to pass to omp::parallel.
Dec 13 2020, 4:05 PM · Restricted Project, Restricted Project, Restricted Project
llitchev updated the diff for D91556: [OpenMPIRBuilder} Add capturing of parameters to pass to omp::parallel.

Addressed CR feedback.

Dec 13 2020, 4:05 PM · Restricted Project, Restricted Project, Restricted Project

Dec 11 2020

llitchev planned changes to D91556: [OpenMPIRBuilder} Add capturing of parameters to pass to omp::parallel.

I suspect there will be conflicts at this time. Posting the source here, so some of the previous commenters could look at it.

Dec 11 2020, 1:00 PM · Restricted Project, Restricted Project, Restricted Project
llitchev updated the diff for D91556: [OpenMPIRBuilder} Add capturing of parameters to pass to omp::parallel.

Implemented the closure approach in the OMPIRBuilder only.

Dec 11 2020, 12:53 PM · Restricted Project, Restricted Project, Restricted Project
llitchev planned changes to D91556: [OpenMPIRBuilder} Add capturing of parameters to pass to omp::parallel.

Just finished significant testing ofg this with our AI codegen. The fix in https://reviews.llvm.org/D92189 whows some issues with number of arguments passed as varargs. The number of varargs that starts showing problems is different for different HW (it seems different for SpirV, Vulcan, MultiCore). I will update this PR.

Dec 11 2020, 11:41 AM · Restricted Project, Restricted Project, Restricted Project

Dec 1 2020

llitchev added a comment to D92189: [OpenMPIRBuilder] forward arguments as pointers to outlined function.

While only partially related, can you leave a FIXME saying that more than 15 arguments need to be packed in a structure?

Dec 1 2020, 9:10 AM · Restricted Project, Restricted Project, Restricted Project

Nov 28 2020

llitchev accepted D92189: [OpenMPIRBuilder] forward arguments as pointers to outlined function.

This looks fine. Except the failing tests. Once the tests are fixed it should be good to go.

Nov 28 2020, 9:12 AM · Restricted Project, Restricted Project, Restricted Project

Nov 20 2020

llitchev added a comment to D91556: [OpenMPIRBuilder} Add capturing of parameters to pass to omp::parallel.

@jdoerfert That makes sense. I looked at the code and that is LLVMIR, so Ill start moving things over.

Nov 20 2020, 11:14 AM · Restricted Project, Restricted Project, Restricted Project

Nov 18 2020

llitchev added inline comments to D91556: [OpenMPIRBuilder} Add capturing of parameters to pass to omp::parallel.
Nov 18 2020, 1:09 PM · Restricted Project, Restricted Project, Restricted Project
llitchev updated the diff for D91556: [OpenMPIRBuilder} Add capturing of parameters to pass to omp::parallel.

Addressed some CR feedback on this diff.

Nov 18 2020, 1:09 PM · Restricted Project, Restricted Project, Restricted Project

Nov 17 2020

llitchev added inline comments to D91556: [OpenMPIRBuilder} Add capturing of parameters to pass to omp::parallel.
Nov 17 2020, 8:20 PM · Restricted Project, Restricted Project, Restricted Project
llitchev updated the diff for D91556: [OpenMPIRBuilder} Add capturing of parameters to pass to omp::parallel.

Created a small pass to capture omp::ParallelOp parameters.

Nov 17 2020, 8:18 PM · Restricted Project, Restricted Project, Restricted Project

Nov 16 2020

llitchev added inline comments to D91556: [OpenMPIRBuilder} Add capturing of parameters to pass to omp::parallel.
Nov 16 2020, 10:26 PM · Restricted Project, Restricted Project, Restricted Project
llitchev requested review of D91556: [OpenMPIRBuilder} Add capturing of parameters to pass to omp::parallel.
Nov 16 2020, 11:17 AM · Restricted Project, Restricted Project, Restricted Project

Sep 14 2020

llitchev committed rGef7a255c037c: Add support for casting elements in vectors for certain Std dialect type… (authored by llitchev).
Add support for casting elements in vectors for certain Std dialect type…
Sep 14 2020, 7:46 AM
llitchev closed D87410: Add support for casting elements in vectors for certain Std dialect type conversion operations..
Sep 14 2020, 7:45 AM · Restricted Project
llitchev removed reviewers for D87410: Add support for casting elements in vectors for certain Std dialect type conversion operations.: bondhugula, mars1026.
Sep 14 2020, 7:45 AM · Restricted Project

Sep 11 2020

llitchev updated the diff for D87410: Add support for casting elements in vectors for certain Std dialect type conversion operations..

Addressed some CR feedback.

Sep 11 2020, 11:23 AM · Restricted Project
llitchev added a comment to D87410: Add support for casting elements in vectors for certain Std dialect type conversion operations..

Rewritten the title and the summary as well.
The tests are in the StandardToLLVM directory (as the rest of the similar conversion tests). This is not part of the LLVM? Or maybe I am wrong?

Sep 11 2020, 11:19 AM · Restricted Project
llitchev retitled D87410: Add support for casting elements in vectors for certain Std dialect type conversion operations. from Add support for casting of vector types to certain FP/Integer operations to Add support for casting elements in vectors for certain Std dialect type conversion operations..
Sep 11 2020, 11:15 AM · Restricted Project
llitchev committed rG320624784c49: [NFC] Follow up on D87111 - Add an option for unrolling loops up to a factor… (authored by llitchev).
[NFC] Follow up on D87111 - Add an option for unrolling loops up to a factor…
Sep 11 2020, 8:13 AM
llitchev closed D87313: [NFC] Follow up on D87111 - Add an option for unrolling loops up to a factor - CR issues addressed..
Sep 11 2020, 8:13 AM · Restricted Project

Sep 10 2020

llitchev added inline comments to D87410: Add support for casting elements in vectors for certain Std dialect type conversion operations..
Sep 10 2020, 12:24 PM · Restricted Project
llitchev updated the diff for D87410: Add support for casting elements in vectors for certain Std dialect type conversion operations..

Resolved CR feedback - updated docs.

Sep 10 2020, 12:24 PM · Restricted Project
llitchev added a comment to D87313: [NFC] Follow up on D87111 - Add an option for unrolling loops up to a factor - CR issues addressed..

Updated the Title and Summary of the diff as requested.

Sep 10 2020, 10:47 AM · Restricted Project
llitchev retitled D87313: [NFC] Follow up on D87111 - Add an option for unrolling loops up to a factor - CR issues addressed. from Follow up for D87111 - CR issues addressed. to [NFC] Follow up on D87111 - Add an option for unrolling loops up to a factor - CR issues addressed..
Sep 10 2020, 10:46 AM · Restricted Project
llitchev updated the diff for D87313: [NFC] Follow up on D87111 - Add an option for unrolling loops up to a factor - CR issues addressed..

Fixed couple of typos and Diff title/summary issues

Sep 10 2020, 10:42 AM · Restricted Project

Sep 9 2020

llitchev requested review of D87410: Add support for casting elements in vectors for certain Std dialect type conversion operations..
Sep 9 2020, 12:40 PM · Restricted Project

Sep 8 2020

llitchev updated the diff for D87313: [NFC] Follow up on D87111 - Add an option for unrolling loops up to a factor - CR issues addressed..

Some more formatting and squashing commits.

Sep 8 2020, 11:53 AM · Restricted Project
llitchev requested review of D87313: [NFC] Follow up on D87111 - Add an option for unrolling loops up to a factor - CR issues addressed..
Sep 8 2020, 11:43 AM · Restricted Project
llitchev committed rGe2394245eb28: Add an option for unrolling loops up to a factor. (authored by llitchev).
Add an option for unrolling loops up to a factor.
Sep 8 2020, 9:24 AM
llitchev closed D87111: Add an option for unrolling loops up to a factor..
Sep 8 2020, 9:23 AM · Restricted Project

Sep 4 2020

llitchev updated the diff for D87111: Add an option for unrolling loops up to a factor..

For some reason a code was removed in a diagnostic message. Added back.

Sep 4 2020, 2:01 PM · Restricted Project

Sep 3 2020

llitchev requested review of D87111: Add an option for unrolling loops up to a factor..
Sep 3 2020, 1:26 PM · Restricted Project

Jun 12 2020

llitchev added inline comments to D81668: Add a phase that lowers std.tanh to a C runtime call.
Jun 12 2020, 12:35 PM · Restricted Project

Jun 11 2020

llitchev added reviewers for D81668: Add a phase that lowers std.tanh to a C runtime call: ftynse, pifon2a.
Jun 11 2020, 10:27 AM · Restricted Project
llitchev updated the diff for D81668: Add a phase that lowers std.tanh to a C runtime call.

Code formatting changes.

Jun 11 2020, 9:53 AM · Restricted Project
llitchev created D81668: Add a phase that lowers std.tanh to a C runtime call.
Jun 11 2020, 9:19 AM · Restricted Project

Jun 4 2020

llitchev added a comment to D75509: [mlir] Removed TanHOp lowering from ConvertStandardToLLVM since there is no reasonable TanH representation in LLVM..

@pifon2a Thanks! That makes sense.

Jun 4 2020, 6:14 PM · Restricted Project, Restricted Project
Herald added a reviewer for D75509: [mlir] Removed TanHOp lowering from ConvertStandardToLLVM since there is no reasonable TanH representation in LLVM.: ftynse.

Hello! I am confused about the reasoning why this functionality was removed - we certainly need the it. I did coded up pretty much the same change and someone (thanks Laub, Frank) pointed out this diff. What is the general strategy/approach to lower operations that are not intrinsics in the LLVM.

Jun 4 2020, 12:09 PM · Restricted Project, Restricted Project

Jan 29 2020

llitchev updated the diff for D73571: [MLIR] Add the sqrt operation to mlir..

Resolved a merge conflict in LLVMOps.td due to changes coming from master.

Jan 29 2020, 9:11 PM · Restricted Project
llitchev added inline comments to D73571: [MLIR] Add the sqrt operation to mlir..
Jan 29 2020, 1:59 PM · Restricted Project
llitchev updated the diff for D73571: [MLIR] Add the sqrt operation to mlir..

Clean up one more ordinal used for f32 sqrt test.

Jan 29 2020, 1:59 PM · Restricted Project
llitchev updated the diff for D73571: [MLIR] Add the sqrt operation to mlir..

Addressed CR re: test matching rules and use of a temp f64 const.

Jan 29 2020, 1:49 PM · Restricted Project
llitchev added inline comments to D73571: [MLIR] Add the sqrt operation to mlir..
Jan 29 2020, 9:40 AM · Restricted Project
llitchev updated the diff for D73571: [MLIR] Add the sqrt operation to mlir..

Addressed some CR comments re: comments - fixed a type to match an existing type and moved an operation description to a OSD file.

Jan 29 2020, 9:40 AM · Restricted Project

Jan 28 2020

llitchev created D73571: [MLIR] Add the sqrt operation to mlir..
Jan 28 2020, 12:11 PM · Restricted Project