Page MenuHomePhabricator

liuliu (Liu Liu)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 20 2016, 11:16 AM (205 w, 5 d)

Recent Activity

Dec 10 2019

liuliu added a comment to D71226: Also synthesize _cmd and self for properties.

Thanks. Verified in our codebase this patch indeed fixed the crashes!

Dec 10 2019, 2:00 PM · Restricted Project

Dec 9 2019

liuliu added a comment to D71091: Make sure that the implicit arguments for direct methods have been setup.

No problem! I have a custom patch that isn't as nice but get the job done. Let me know when you put new diff out and I can test it on our codebase again.

Dec 9 2019, 1:40 PM · Restricted Project
liuliu added a comment to D71091: Make sure that the implicit arguments for direct methods have been setup.

We don't use PCH :) I arc patched the latest diff, still have that crash. More strangely, I tried this latest diff on previously simplistic test case and it crashes now:

#import <Foundation/Foundation.h>
Dec 9 2019, 11:39 AM · Restricted Project

Dec 6 2019

liuliu added inline comments to D71091: Make sure that the implicit arguments for direct methods have been setup.
Dec 6 2019, 12:06 PM · Restricted Project
liuliu added a comment to D71091: Make sure that the implicit arguments for direct methods have been setup.

With this latest fix applied on top of b220662a45c8067a2ae485ae34c1138d93506df9, in our company's internal code, I still encounter the crash.

Dec 6 2019, 10:23 AM · Restricted Project

Dec 5 2019

liuliu added a comment to D71091: Make sure that the implicit arguments for direct methods have been setup.

Did you mean the linkage issue?

Dec 5 2019, 2:54 PM · Restricted Project