Page MenuHomePhabricator

lionkov (Latchesar Ionkov)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 23 2020, 9:56 AM (46 w, 4 d)

Recent Activity

Sep 14 2020

lionkov updated the diff for D84456: [OpenMP] Refactor memory allocation code for easier support for third party memory libraries.

changes suggested by the reviewers

Sep 14 2020, 2:25 PM · Unknown Object (Project)

Sep 9 2020

lionkov added a comment to D84456: [OpenMP] Refactor memory allocation code for easier support for third party memory libraries.

Any progress on this change?

Sep 9 2020, 6:39 AM · Unknown Object (Project)

Aug 17 2020

lionkov updated the diff for D84456: [OpenMP] Refactor memory allocation code for easier support for third party memory libraries.

Changes suggested by the reviewers.

Aug 17 2020, 10:43 AM · Unknown Object (Project)

Aug 12 2020

lionkov added a comment to D84456: [OpenMP] Refactor memory allocation code for easier support for third party memory libraries.

Other than few formatting changes the instructions from the link didn't provide any information about "full diff". Is that related to arcanist somehow? I can try to figure out how to use it if that'll help. :)

I figured if I give you the link to the start of "how to submit a patch" you would follow the links from there. My bad: https://llvm.org/docs/Phabricator.html#phabricator-request-review-web

That's exactly the instructions I followed to submit my patch. If it is lacking some details, I would like to know how to fix it.

The key difference is:
git diff # gives you short patch
git diff -U999999 # gives you full patch

The full patch should have complete source, as opposed to 3 lines above and below the changes for the short patch.

Aug 12 2020, 7:15 AM · Unknown Object (Project)
lionkov updated the diff for D84456: [OpenMP] Refactor memory allocation code for easier support for third party memory libraries.
Aug 12 2020, 7:14 AM · Unknown Object (Project)
lionkov added a comment to D84456: [OpenMP] Refactor memory allocation code for easier support for third party memory libraries.

Other than few formatting changes the instructions from the link didn't provide any information about "full diff". Is that related to arcanist somehow? I can try to figure out how to use it if that'll help. :)

I figured if I give you the link to the start of "how to submit a patch" you would follow the links from there. My bad: https://llvm.org/docs/Phabricator.html#phabricator-request-review-web

Aug 12 2020, 6:09 AM · Unknown Object (Project)

Aug 11 2020

lionkov added a comment to D84456: [OpenMP] Refactor memory allocation code for easier support for third party memory libraries.

Other than few formatting changes the instructions from the link didn't provide any information about "full diff". Is that related to arcanist somehow? I can try to figure out how to use it if that'll help. :)

Aug 11 2020, 8:23 PM · Unknown Object (Project)
lionkov added a comment to D84456: [OpenMP] Refactor memory allocation code for easier support for third party memory libraries.

Could you please provide full diff so that more context is available around the changes?

Aug 11 2020, 5:21 PM · Unknown Object (Project)
lionkov updated the diff for D84456: [OpenMP] Refactor memory allocation code for easier support for third party memory libraries.

Fixed minor issues reported by Johannes.

Aug 11 2020, 12:21 PM · Unknown Object (Project)
lionkov added a comment to D84456: [OpenMP] Refactor memory allocation code for easier support for third party memory libraries.

Any progress on reviewing this?

Aug 11 2020, 7:33 AM · Unknown Object (Project)

Jul 27 2020

lionkov updated the diff for D84456: [OpenMP] Refactor memory allocation code for easier support for third party memory libraries.

Removed the SICM support, will post that as separate patch once this one is accepted.

Jul 27 2020, 11:13 AM · Unknown Object (Project)

Jul 23 2020

lionkov updated the summary of D84456: [OpenMP] Refactor memory allocation code for easier support for third party memory libraries.
Jul 23 2020, 12:39 PM · Unknown Object (Project)
Herald added a reviewer for D84456: [OpenMP] Refactor memory allocation code for easier support for third party memory libraries: jdoerfert.
Jul 23 2020, 12:39 PM · Unknown Object (Project)