- User Since
- Jan 18 2017, 9:43 AM (166 w, 6 d)
Feb 14 2020
Test cases will be uploaded in another patch when the Clang patch is upstreamed. That Clang patch depends on this (https://reviews.llvm.org/D67833). So I think the order is this patch, clang patch, test patch.
Dec 23 2019
Address Jon's comments
Rebase and rediff with the nfc version
Dec 21 2019
Yes, this is the NFC part of the declare mapper patch. I've tested it. There is not much test in libomptarget though.
Dec 20 2019
Dec 18 2019
Change the function name
Address Alexey's comments to change mapper function size and refactor code
Dec 17 2019
Dec 16 2019
Alexey, thanks for the review
I'll split the patch into 2 later
Rebase and address comments
Nov 25 2019
Thanks for your reviews. Hope this looks better.
Nov 15 2019
Nov 13 2019
Thanks Alexey and Jon for your review. Fixed the issues and rebased
Sep 27 2019
Alexey and George: This is a big decision to make. We need to have most people's consents. I'll send it to the mailing list later.
Sorry, you are right. I didn't think about the case to always clean up the mappers after finishing using it.
Please review when you have time, thanks
Sep 26 2019
Fix mapper type checking
Sep 25 2019
HI Alexey, the ast print test is already there. Because I didn't check the mapper for array type before, such code will always not report any error, and ast print test is correct. Codegen test belongs to the other patch I released. It fits that patch much better.
Sep 24 2019
Without this patch, it cannot recognize array with mapper, for instance, #pragma omp target map(mapper(a),to: arr[0:2]) won't work without this patch.
Sep 20 2019
Aug 5 2019
Fix declare mapper codegen test when the function argument has name attached.
Aug 2 2019
Aug 1 2019
@Meinersbur Hi Michael, could you help me commit this patch? Thanks!
Jul 31 2019
Add a test
Jul 30 2019
Change mapper function argument checking
Jul 29 2019
Thanks Alexey! Could you look into the runtime patch D60972 then?
Ping and rebase
Jul 26 2019
Make emitUDMapperArrayInitOrDel private
Jul 25 2019
Remove virtual from function declaration
Jul 24 2019
Get rid of MSVC requirement of this, and a virtual function
Jul 23 2019
Jul 17 2019
Jun 27 2019
Change the type of size from size_t to int64_t, and rebase
Jun 26 2019
Jun 25 2019
Jun 20 2019
Address Alexey's comments