Rebase

Thanks a lot!

get rid of the from clause part.

Rebase

Thanks for the catch! I also change the name from OMPMappableExprListLocTy to OMPVarListLocTy to be more accurate. We can potentially factorize other varlist clause code with this. But it will be too large for this patch.

Change parameters to const &

Further reduce the number of parameters for map, to, from, use_device, and is_device clauses. Also rebase.

Introduce a structure OMPMappableExprListSizeTy within OMPMappableExprListClause to aggregate all 4 sizes needed by such clause, and thus reduce the number of parameters when creating a map clause. This can also be used by other similar clauses. I'll have another patch to let other clauses to use this structure as well.

Sure I'll add a codegen test with mapper. Thanks!

Hi Alexey,

1. Move mapper related info to OMPMappableExprListClause, so that to and from clauses can utilize the same infrastructure as well (real support for them will be in another patch);
2. Combine the function parameters for declare mapper and declare reduction, to reduce the function parameter number of ActOnOMPVarListClause;
3. Implement ADL for mapper, and remove mapper lookups in SemaLookup.cpp;
4. Didn't combine modifier related info into a structure, because for to and from clauses will only have possible mapper modifier, not close and always;
5. Address typos that Kelvin found;
6. Rebase.

Fix part of Alexey's comments

Hi Alexey,

In D56326#1381229, @Meinersbur wrote:

@lildmh Thanks for the patch. I can commit this patch for you. The tests run fine on my machine. However, for committing on other's behalf, we were asked to make the contributor aware that the contribution will be published under a new license. Are you OK with the new license?

Thanks a lot Alexey!

Hi Alexey,

Address review comments and rebase

Hi Alexey,

Change the type of mapper clause storage from OMPClause ** to MutableArrayRef<OMPClause *>, and rebase

Hi Alexey,

Add a full context diff