Page MenuHomePhabricator

lildmh (Lingda Li)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 18 2017, 9:43 AM (112 w, 5 d)

Recent Activity

Sun, Mar 17

lildmh created D59474: [OpenMP 5.0] Codegen support for user-defined mappers.
Sun, Mar 17, 11:16 AM · Restricted Project, Unknown Object (Project)

Mon, Feb 25

lildmh created D58640: [OpenMP 5.0] Fix argument dependent lookup of user-defined mapper.
Mon, Feb 25, 11:29 AM · Unknown Object (Project)
lildmh created D58638: [OpenMP 5.0] Parsing/sema support for from clause with mapper modifier.
Mon, Feb 25, 10:40 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Fri, Feb 22

lildmh updated the diff for D58523: [OpenMP 5.0] Parsing/sema support for to clause with mapper modifier.

Rebase

Fri, Feb 22, 12:43 PM · Restricted Project, Restricted Project, Unknown Object (Project)
lildmh added a comment to D58523: [OpenMP 5.0] Parsing/sema support for to clause with mapper modifier.

Thanks a lot!

Fri, Feb 22, 12:26 PM · Restricted Project, Restricted Project, Unknown Object (Project)
lildmh added inline comments to D58523: [OpenMP 5.0] Parsing/sema support for to clause with mapper modifier.
Fri, Feb 22, 12:15 PM · Restricted Project, Restricted Project, Unknown Object (Project)
lildmh updated the diff for D58523: [OpenMP 5.0] Parsing/sema support for to clause with mapper modifier.
Fri, Feb 22, 12:15 PM · Restricted Project, Restricted Project, Unknown Object (Project)
lildmh updated the diff for D58523: [OpenMP 5.0] Parsing/sema support for to clause with mapper modifier.

get rid of the from clause part.

Fri, Feb 22, 11:54 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Thu, Feb 21

lildmh updated the diff for D58523: [OpenMP 5.0] Parsing/sema support for to clause with mapper modifier.
Thu, Feb 21, 2:52 PM · Restricted Project, Restricted Project, Unknown Object (Project)
lildmh added inline comments to D58523: [OpenMP 5.0] Parsing/sema support for to clause with mapper modifier.
Thu, Feb 21, 2:23 PM · Restricted Project, Restricted Project, Unknown Object (Project)
lildmh created D58523: [OpenMP 5.0] Parsing/sema support for to clause with mapper modifier.
Thu, Feb 21, 11:32 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Tue, Feb 19

lildmh updated the diff for D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier.

Rebase

Tue, Feb 19, 6:12 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Feb 15 2019

lildmh updated the diff for D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier.

Thanks for the catch! I also change the name from OMPMappableExprListLocTy to OMPVarListLocTy to be more accurate. We can potentially factorize other varlist clause code with this. But it will be too large for this patch.

Feb 15 2019, 1:41 PM · Restricted Project, Restricted Project, Unknown Object (Project)
lildmh updated the diff for D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier.

Change parameters to const &

Feb 15 2019, 12:47 PM · Restricted Project, Restricted Project, Unknown Object (Project)
lildmh added inline comments to D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier.
Feb 15 2019, 11:38 AM · Restricted Project, Restricted Project, Unknown Object (Project)
lildmh updated the diff for D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier.

Further reduce the number of parameters for map, to, from, use_device, and is_device clauses. Also rebase.

Feb 15 2019, 11:37 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Feb 14 2019

lildmh updated the diff for D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier.

Introduce a structure OMPMappableExprListSizeTy within OMPMappableExprListClause to aggregate all 4 sizes needed by such clause, and thus reduce the number of parameters when creating a map clause. This can also be used by other similar clauses. I'll have another patch to let other clauses to use this structure as well.

Feb 14 2019, 1:49 PM · Restricted Project, Restricted Project, Unknown Object (Project)
lildmh added a comment to D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier.

Sure I'll add a codegen test with mapper. Thanks!

Feb 14 2019, 9:58 AM · Restricted Project, Restricted Project, Unknown Object (Project)
lildmh added a comment to D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier.

Hi Alexey,

Feb 14 2019, 9:36 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Feb 13 2019

lildmh updated the diff for D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier.
  1. Move mapper related info to OMPMappableExprListClause, so that to and from clauses can utilize the same infrastructure as well (real support for them will be in another patch);
  2. Combine the function parameters for declare mapper and declare reduction, to reduce the function parameter number of ActOnOMPVarListClause;
  3. Implement ADL for mapper, and remove mapper lookups in SemaLookup.cpp;
  4. Didn't combine modifier related info into a structure, because for to and from clauses will only have possible mapper modifier, not close and always;
  5. Address typos that Kelvin found;
  6. Rebase.
Feb 13 2019, 2:21 PM · Restricted Project, Restricted Project, Unknown Object (Project)
lildmh added a reviewer for D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier: kkwli0.
Feb 13 2019, 6:22 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Feb 12 2019

lildmh added inline comments to D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier.
Feb 12 2019, 10:46 AM · Restricted Project, Restricted Project, Unknown Object (Project)
lildmh added inline comments to D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier.
Feb 12 2019, 10:19 AM · Restricted Project, Restricted Project, Unknown Object (Project)
lildmh added inline comments to D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier.
Feb 12 2019, 9:57 AM · Restricted Project, Restricted Project, Unknown Object (Project)
lildmh updated the diff for D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier.

Fix part of Alexey's comments

Feb 12 2019, 9:24 AM · Restricted Project, Restricted Project, Unknown Object (Project)
lildmh added a comment to D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier.

Hi Alexey,

Feb 12 2019, 9:23 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Feb 11 2019

lildmh updated the diff for D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier.
Feb 11 2019, 2:28 PM · Restricted Project, Restricted Project, Unknown Object (Project)
lildmh created D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier.
Feb 11 2019, 2:12 PM · Restricted Project, Restricted Project, Unknown Object (Project)

Feb 1 2019

lildmh added a comment to D56326: [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive.

@lildmh Thanks for the patch. I can commit this patch for you. The tests run fine on my machine. However, for committing on other's behalf, we were asked to make the contributor aware that the contribution will be published under a new license. Are you OK with the new license?

Feb 1 2019, 11:45 AM · Restricted Project, Unknown Object (Project)
lildmh added a comment to D56326: [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive.

Thanks a lot Alexey!

Feb 1 2019, 7:20 AM · Restricted Project, Unknown Object (Project)
lildmh updated the diff for D56326: [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive.

Hi Alexey,

Feb 1 2019, 6:55 AM · Restricted Project, Unknown Object (Project)

Jan 25 2019

lildmh updated the diff for D56326: [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive.

Address review comments and rebase

Jan 25 2019, 2:00 PM · Restricted Project, Unknown Object (Project)
lildmh added a comment to D56326: [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive.

Hi Alexey,

Jan 25 2019, 2:00 PM · Restricted Project, Unknown Object (Project)
lildmh updated the diff for D56326: [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive.

Change the type of mapper clause storage from OMPClause ** to MutableArrayRef<OMPClause *>, and rebase

Jan 25 2019, 10:40 AM · Restricted Project, Unknown Object (Project)
lildmh added inline comments to D56326: [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive.
Jan 25 2019, 6:42 AM · Restricted Project, Unknown Object (Project)

Jan 24 2019

lildmh added inline comments to D56326: [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive.
Jan 24 2019, 1:58 PM · Restricted Project, Unknown Object (Project)
lildmh added inline comments to D56326: [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive.
Jan 24 2019, 10:44 AM · Restricted Project, Unknown Object (Project)

Jan 11 2019

lildmh added inline comments to D56326: [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive.
Jan 11 2019, 11:38 AM · Restricted Project, Unknown Object (Project)
lildmh added inline comments to D56326: [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive.
Jan 11 2019, 10:09 AM · Restricted Project, Unknown Object (Project)
lildmh updated the diff for D56326: [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive.
Jan 11 2019, 8:43 AM · Restricted Project, Unknown Object (Project)
lildmh added a comment to D56326: [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive.

Hi Alexey,

Jan 11 2019, 8:40 AM · Restricted Project, Unknown Object (Project)

Jan 4 2019

lildmh updated the summary of D56326: [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive.
Jan 4 2019, 11:26 AM · Restricted Project, Unknown Object (Project)
lildmh created D56326: [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive.
Jan 4 2019, 11:11 AM · Restricted Project, Unknown Object (Project)

Jan 18 2017

lildmh updated the diff for D28870: [OpenMP] Add an OpenMP pass for redundant runtime library call removal.

Add a full context diff

Jan 18 2017, 2:03 PM
lildmh created D28870: [OpenMP] Add an OpenMP pass for redundant runtime library call removal.
Jan 18 2017, 1:26 PM