Page MenuHomePhabricator

liadz0rz (Liad Mordekoviz)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 11 2018, 4:15 AM (90 w, 4 h)

Recent Activity

Feb 11 2020

liadz0rz added a comment to D72992: [llvm-objdump] - Add column headers for relocation printing.

Hey,
For the email please user liad.mordekoviz@gmail.com and for the author please use "Liad Mordekoviz",
Again thank you very much for all the kind help!

Feb 11 2020, 8:17 AM · Restricted Project
liadz0rz updated the diff for D72992: [llvm-objdump] - Add column headers for relocation printing.

Fixed failed tests

Feb 11 2020, 12:59 AM · Restricted Project

Feb 2 2020

liadz0rz added a comment to D72992: [llvm-objdump] - Add column headers for relocation printing.

Thank you all for your help with this patch, I do not have permissions to merge, how can I get this merged?

Feb 2 2020, 1:15 AM · Restricted Project

Jan 31 2020

liadz0rz added inline comments to D72992: [llvm-objdump] - Add column headers for relocation printing.
Jan 31 2020, 4:13 AM · Restricted Project
liadz0rz updated the diff for D72992: [llvm-objdump] - Add column headers for relocation printing.

Added local test to rela as well

Jan 31 2020, 4:09 AM · Restricted Project
liadz0rz added inline comments to D72992: [llvm-objdump] - Add column headers for relocation printing.
Jan 31 2020, 1:28 AM · Restricted Project

Jan 30 2020

liadz0rz updated the diff for D72992: [llvm-objdump] - Add column headers for relocation printing.

Fixed file header

Jan 30 2020, 11:46 AM · Restricted Project
liadz0rz updated the diff for D72992: [llvm-objdump] - Add column headers for relocation printing.

Fixed missing newline and aligned values with spaces

Jan 30 2020, 6:49 AM · Restricted Project

Jan 29 2020

liadz0rz updated the diff for D72992: [llvm-objdump] - Add column headers for relocation printing.

Added RELA and removed trailing newline at end of file

Jan 29 2020, 3:49 AM · Restricted Project
liadz0rz updated the diff for D72992: [llvm-objdump] - Add column headers for relocation printing.

Fixed commit message yet again and minimized the YAML for the ELF32 test

Jan 29 2020, 3:12 AM · Restricted Project
liadz0rz updated the summary of D72992: [llvm-objdump] - Add column headers for relocation printing.
Jan 29 2020, 3:12 AM · Restricted Project
liadz0rz updated the diff for D72992: [llvm-objdump] - Add column headers for relocation printing.

Updated commit message

Jan 29 2020, 3:07 AM · Restricted Project
liadz0rz updated the diff for D72992: [llvm-objdump] - Add column headers for relocation printing.

The previous diff was the wrong one

Jan 29 2020, 3:02 AM · Restricted Project
liadz0rz updated the diff for D72992: [llvm-objdump] - Add column headers for relocation printing.

Update formatting and test names

Jan 29 2020, 2:58 AM · Restricted Project

Jan 25 2020

liadz0rz updated the diff for D72992: [llvm-objdump] - Add column headers for relocation printing.

Updated required changes, removed unnecessary additions of --strict-whitespace, I did not change the content of the ELF32 test because there was no conclusive decision to whether I should or shouldn't remove the extra relocations on that test.

Jan 25 2020, 9:22 AM · Restricted Project

Jan 23 2020

liadz0rz added inline comments to D72992: [llvm-objdump] - Add column headers for relocation printing.
Jan 23 2020, 8:37 AM · Restricted Project

Jan 22 2020

liadz0rz added inline comments to D72992: [llvm-objdump] - Add column headers for relocation printing.
Jan 22 2020, 11:45 PM · Restricted Project

Jan 21 2020

liadz0rz updated the diff for D72992: [llvm-objdump] - Add column headers for relocation printing.

Updated with the requested changes and with new tests added and updated

Jan 21 2020, 11:37 AM · Restricted Project
liadz0rz added a comment to D72992: [llvm-objdump] - Add column headers for relocation printing.

I've updated the relocations-elf.test file with the new headers, they seem to recognize the headers quite well, however, the relocations on my machine come out different than the test expects, so the other parts of the test fail...
Are there any requirements for the machine I am running my test on?

I'm not aware of any specific requirements for this test. How are you running the test? Have you remembered to build the other tools in LLVM that it uses? (yaml2obj, llvm-objdump, FileCheck?). What is the output you get when you run the test?

Jan 21 2020, 6:21 AM · Restricted Project

Jan 20 2020

liadz0rz added a comment to D72992: [llvm-objdump] - Add column headers for relocation printing.

Thanks for the patch!

It looks like you haven't run the tests. Please make sure to run the check-all target, to run all the tests. In particular, I expect to see many tests that will fail, because they do not expect the extra line for the headers. Also, please make sure to update the llvm/test/tools/llvm-objdump/elf-relocations.test to check this works. You will need to add a 32-bit test case probably, to show that the 16 versus 8 space padding decision is made correctly. If you need help writing these tests, please let me know, and I'll be happy to help out.

Jan 20 2020, 12:36 PM · Restricted Project
liadz0rz added a comment to D72992: [llvm-objdump] - Add column headers for relocation printing.
Jan 20 2020, 10:44 AM · Restricted Project

Jan 19 2020

liadz0rz created D72992: [llvm-objdump] - Add column headers for relocation printing.
Jan 19 2020, 1:48 AM · Restricted Project

Aug 9 2018

Herald added a reviewer for D42374: [RFC] Add IsFixed field to ISD::ArgFlagsTy: javed.absar.
Aug 9 2018, 1:00 AM

Jul 12 2018

liadz0rz added a comment to D49186: [SelectionDAG] add support for float16 libcalls.

Which targets actually support the libcalls you're adding?

Jul 12 2018, 12:52 AM

Jul 11 2018

liadz0rz created D49186: [SelectionDAG] add support for float16 libcalls.
Jul 11 2018, 7:25 AM