Page MenuHomePhabricator

lewmpk (Lewis Clark)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 27 2019, 11:35 AM (40 w, 4 d)

Recent Activity

Mar 4 2019

lewmpk updated the diff for D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check.

match lock() and unlock() calls by decl

Mar 4 2019, 9:16 AM · Restricted Project

Mar 3 2019

lewmpk added inline comments to D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check.
Mar 3 2019, 4:30 AM · Restricted Project
lewmpk updated the diff for D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check.

added example in docs and explicitly specified types for some variables

Mar 3 2019, 3:04 AM · Restricted Project

Mar 2 2019

lewmpk added inline comments to D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check.
Mar 2 2019, 12:06 PM · Restricted Project
lewmpk updated the diff for D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check.

added support for boost lockable types

Mar 2 2019, 11:58 AM · Restricted Project
lewmpk updated the diff for D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check.

refactor and improved tests

Mar 2 2019, 11:20 AM · Restricted Project

Mar 1 2019

lewmpk updated the diff for D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check.

remove support for try_lock_for and try_lock_until

Mar 1 2019, 7:45 AM · Restricted Project
lewmpk updated the diff for D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check.

support try_lock_for and try_lock_until

Mar 1 2019, 7:40 AM · Restricted Project
lewmpk updated the diff for D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check.

improved tests

Mar 1 2019, 7:29 AM · Restricted Project
lewmpk updated the diff for D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check.

fixed documentation formatting

Mar 1 2019, 7:22 AM · Restricted Project
lewmpk added inline comments to D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check.
Mar 1 2019, 7:17 AM · Restricted Project
lewmpk updated the diff for D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check.

fixed documentation formatting

Mar 1 2019, 7:15 AM · Restricted Project
lewmpk updated the diff for D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check.

fixed documentation again

Mar 1 2019, 7:14 AM · Restricted Project
lewmpk updated the diff for D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check.

fixed documentation

Mar 1 2019, 7:11 AM · Restricted Project
lewmpk updated the diff for D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check.

renamed option for cppcoreguidelines-use-raii-locks

Mar 1 2019, 7:10 AM · Restricted Project
lewmpk updated the diff for D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check.

handle other basiclockable types

Mar 1 2019, 7:03 AM · Restricted Project
lewmpk updated the diff for D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check.

removed unneccesary include

Mar 1 2019, 6:42 AM · Restricted Project
lewmpk updated the diff for D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check.

fixed nested use case

Mar 1 2019, 6:42 AM · Restricted Project
lewmpk added a comment to D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check.

I'll improve the tests :)

Mar 1 2019, 6:24 AM · Restricted Project
lewmpk updated the diff for D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check.

fixed ordering of cppcoreguidelines module checks

Mar 1 2019, 6:13 AM · Restricted Project
lewmpk updated subscribers of D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check.
Mar 1 2019, 4:29 AM · Restricted Project
lewmpk created D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check.
Mar 1 2019, 4:29 AM · Restricted Project

Feb 28 2019

lewmpk abandoned D58764: [clang-tidy] ignore predefined expressions in cppcoreguidelines-pro-bounds-array-to-pointer-decay check.
Feb 28 2019, 7:35 AM · Restricted Project, Restricted Project
lewmpk added a comment to D58731: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions.

I'm happy to land this ASAP but I don't have commit rights

Feb 28 2019, 3:32 AM · Restricted Project, Restricted Project, Restricted Project
lewmpk added a comment to D57087: [clang-tidy] add OverrideMacro to modernize-use-override check.
Feb 28 2019, 3:31 AM · Restricted Project, Restricted Project
lewmpk added a comment to D58764: [clang-tidy] ignore predefined expressions in cppcoreguidelines-pro-bounds-array-to-pointer-decay check.

Okk, it seems that the consensus is that __FUNCTION__ should not be cast to char*. ( I'll research a bit before I pick up a task in the future :) )
I'm happy to abandon this diff - any objections?

Feb 28 2019, 2:47 AM · Restricted Project, Restricted Project
lewmpk created D58764: [clang-tidy] ignore predefined expressions in cppcoreguidelines-pro-bounds-array-to-pointer-decay check.
Feb 28 2019, 2:12 AM · Restricted Project, Restricted Project

Feb 27 2019

lewmpk updated the diff for D58731: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions.

cleaned up documentation

Feb 27 2019, 4:00 PM · Restricted Project, Restricted Project, Restricted Project
lewmpk updated the diff for D58731: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions.
  • fixed tests
  • fixed typo in documentation
Feb 27 2019, 3:42 PM · Restricted Project, Restricted Project, Restricted Project
lewmpk added a comment to D58731: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions.

I'm trying to find a way to run the test. If someone else has already tested it then yes please.

Feb 27 2019, 3:09 PM · Restricted Project, Restricted Project, Restricted Project
lewmpk added a comment to D58731: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions.

thanks for the feedback everyone (and the warm welcome)

Feb 27 2019, 2:51 PM · Restricted Project, Restricted Project, Restricted Project
lewmpk updated the diff for D58731: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions.

addressed comments

Feb 27 2019, 2:49 PM · Restricted Project, Restricted Project, Restricted Project
lewmpk added inline comments to D58731: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions.
Feb 27 2019, 2:19 PM · Restricted Project, Restricted Project, Restricted Project
lewmpk updated the diff for D58731: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions.
  • addressed comments
  • provided tests
  • updated documentation
  • updated release notes
Feb 27 2019, 2:19 PM · Restricted Project, Restricted Project, Restricted Project
lewmpk created D58731: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions.
Feb 27 2019, 11:46 AM · Restricted Project, Restricted Project, Restricted Project