Page MenuHomePhabricator

lero_chris (Chris Dewhurst)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 10 2016, 7:10 AM (196 w, 1 d)

Recent Activity

Nov 1 2016

lero_chris closed D24658: [Sparc][LEON] Optimisation for FDIV / FSQRT leon erratum fix.
Nov 1 2016, 7:02 AM
lero_chris accepted D24658: [Sparc][LEON] Optimisation for FDIV / FSQRT leon erratum fix.
Nov 1 2016, 7:02 AM

Oct 19 2016

lero_chris closed D24665: [Sparc][LEON] Fixes an erratum on UT699 LEON 3 processor changing rounding mode.

Closed. May make small change as per last comment in a subsequent check-in.

Oct 19 2016, 7:03 AM

Oct 18 2016

lero_chris updated the diff for D24665: [Sparc][LEON] Fixes an erratum on UT699 LEON 3 processor changing rounding mode.

Per comments in review, converted this to detect a rounding change only. It issues an error with a message that this is an erratum on the processor that the user will need to handle in a source code change. The unit test tests that the error message is produced.

Oct 18 2016, 7:53 AM

Oct 17 2016

lero_chris updated the diff for D24658: [Sparc][LEON] Optimisation for FDIV / FSQRT leon erratum fix.

Added unit tests which should have been included in the original review.

Oct 17 2016, 1:24 PM
lero_chris abandoned D23456: [Sparc] Leon Errata Fix Passes.

This review has been separated into seperate reviews. Abandoning this as an open review.

Oct 17 2016, 1:49 AM

Oct 7 2016

lero_chris closed D24660: [Sparc][LEON] Erratum fix to replace broken SDIV instruction with SDIVcc..
Oct 7 2016, 2:43 AM

Oct 6 2016

lero_chris updated the diff for D24660: [Sparc][LEON] Erratum fix to replace broken SDIV instruction with SDIVcc..

(Re-) added unit test. Added test to ensure this doesn't change behaviour for unaffected processors.

Oct 6 2016, 2:15 AM
lero_chris updated the diff for D24660: [Sparc][LEON] Erratum fix to replace broken SDIV instruction with SDIVcc..

Indentation in new code caused by Tab usage fixed and replaced with spaces.

Oct 6 2016, 1:43 AM
lero_chris updated the diff for D24660: [Sparc][LEON] Erratum fix to replace broken SDIV instruction with SDIVcc..

Erratum fixed differently, in line with suggestion by Eli Friedman.

Oct 6 2016, 1:41 AM

Oct 5 2016

lero_chris updated the diff for D24660: [Sparc][LEON] Erratum fix to replace broken SDIV instruction with SDIVcc..

Addresses Daniel Cederman's concerns about the integer condition codes potentially being corrupted by marking that the ICC (condition codes) are changed by the SDIV instruction when the erratum fix is switched on. This will prevent the compiler from inserting this instruction in between the condition codes being set and later, being used.

Oct 5 2016, 9:27 AM

Sep 28 2016

lero_chris added a comment to D24658: [Sparc][LEON] Optimisation for FDIV / FSQRT leon erratum fix.

If nobody has any comments, I'll check this in tomorrow: 29th Sept, as this has now been on review for two weeks.

Sep 28 2016, 12:40 AM

Sep 22 2016

lero_chris added a reviewer for D24665: [Sparc][LEON] Fixes an erratum on UT699 LEON 3 processor changing rounding mode: dcederman.
Sep 22 2016, 7:01 AM
lero_chris added a reviewer for D24662: [Sparc][LEON] Hardware erratum fix: Insert NOPs around double precision instructions: dcederman.
Sep 22 2016, 7:01 AM
lero_chris added a reviewer for D24660: [Sparc][LEON] Erratum fix to replace broken SDIV instruction with SDIVcc.: dcederman.
Sep 22 2016, 7:00 AM
lero_chris added a reviewer for D24658: [Sparc][LEON] Optimisation for FDIV / FSQRT leon erratum fix: dcederman.
Sep 22 2016, 7:00 AM

Sep 16 2016

lero_chris retitled D24665: [Sparc][LEON] Fixes an erratum on UT699 LEON 3 processor changing rounding mode from to [Sparc][LEON] Fixes an erratum on UT699 LEON 3 processor changing rounding mode.
Sep 16 2016, 7:02 AM
lero_chris retitled D24662: [Sparc][LEON] Hardware erratum fix: Insert NOPs around double precision instructions from to [Sparc][LEON] Hardware erratum fix: Insert NOPs around double precision instructions.
Sep 16 2016, 6:13 AM
lero_chris retitled D24660: [Sparc][LEON] Erratum fix to replace broken SDIV instruction with SDIVcc. from to [Sparc][LEON] Erratum fix to replace broken SDIV instruction with SDIVcc..
Sep 16 2016, 5:07 AM
lero_chris added reviewers for D24658: [Sparc][LEON] Optimisation for FDIV / FSQRT leon erratum fix: jyknight, jacob_hansen.
Sep 16 2016, 4:35 AM
lero_chris retitled D24658: [Sparc][LEON] Optimisation for FDIV / FSQRT leon erratum fix from to [Sparc][LEON] Optimisation for FDIV / FSQRT leon erratum fix.
Sep 16 2016, 4:34 AM

Sep 5 2016

lero_chris added a comment to D23456: [Sparc] Leon Errata Fix Passes.

Hi, The formatting changes that were *entirely* unrelated to the code updates have been removed. As part of the review process, I also removed all the inline ASM code,m as requested by James Knight. Otherwise, the changes are all specifically to do with the updated passes, except some very small changes to comments and formatting *entirely in and around code that has been changed as part of this update*.

Sep 5 2016, 5:54 AM

Sep 2 2016

lero_chris updated the diff for D23456: [Sparc] Leon Errata Fix Passes.

Removed the IgnoreZeroFlag erratum fix pass containing "wr %g0, 1, %psr" as this pass does not have any effect.

Sep 2 2016, 8:51 AM

Sep 1 2016

lero_chris added a comment to D23456: [Sparc] Leon Errata Fix Passes.

Addresses some of the review comments.

Sep 1 2016, 1:13 PM
lero_chris updated the diff for D23456: [Sparc] Leon Errata Fix Passes.

Update to reviewed code to address comments.

Sep 1 2016, 1:08 PM

Aug 12 2016

lero_chris updated the diff for D23456: [Sparc] Leon Errata Fix Passes.

Removed change to length of supported atomics for LEON processors. Should have always been 32 bit and the previous change wasn't necessary in SparcISelLowering.cpp

Aug 12 2016, 10:55 AM
lero_chris retitled D23456: [Sparc] Leon Errata Fix Passes from to [Sparc] Leon Errata Fix Passes.
Aug 12 2016, 10:49 AM
lero_chris abandoned D21960: [Sparc] Leon errata fixes passes..

Abandoned.

Aug 12 2016, 8:13 AM
lero_chris added a comment to D21960: [Sparc] Leon errata fixes passes..

Hi Daniel. Nobody was commenting and I need to get this checked-in as I won't be around for three weeks now. You commented at *exactly* the same time as I did the check-in. Otherwise, I had addressed all the review comments.

I'll look at the comments and make any necessary changes when I am next at work.

This is not OK. You have ignored two requests for a revert in a row now. I have reverted all of this in r278511.

Aug 12 2016, 8:13 AM
lero_chris updated the diff for D21960: [Sparc] Leon errata fixes passes..

Removed RestoreExecAddress and FillDataCache passes as these will have no effect.

Aug 12 2016, 8:01 AM
lero_chris abandoned D23334: [Sparc][Leon] Speed optimisation to reduce double floating-point instructions to singles..

Review abandoned.

Aug 12 2016, 5:29 AM
lero_chris added a comment to D23334: [Sparc][Leon] Speed optimisation to reduce double floating-point instructions to singles..

We have discussed this with our customers. We have agreed that this pass does not make sense here and we will therefore cancel this change.

Aug 12 2016, 5:29 AM
lero_chris added a comment to D21960: [Sparc] Leon errata fixes passes..

Hi Daniel. Nobody was commenting and I need to get this checked-in as I won't be around for three weeks now. You commented at *exactly* the same time as I did the check-in. Otherwise, I had addressed all the review comments.

Aug 12 2016, 4:30 AM
lero_chris added a comment to D23334: [Sparc][Leon] Speed optimisation to reduce double floating-point instructions to singles..

We were asked to write this optimisation, but we'll revert and ask our customers if they still want this as the point made by James Knight has distinct point. This review may ultimately be cancelled entirely.

Aug 12 2016, 3:36 AM

Aug 11 2016

lero_chris added a comment to D21960: [Sparc] Leon errata fixes passes..

Addressing review comments.

Aug 11 2016, 1:06 PM
lero_chris updated the diff for D21960: [Sparc] Leon errata fixes passes..

Modified some unit tests that were using inline assembler tests to work without this to reflect the non-use of inline assembler in the modified passes.

Aug 11 2016, 1:02 PM
lero_chris updated the diff for D23334: [Sparc][Leon] Speed optimisation to reduce double floating-point instructions to singles..

Added missing unit test and changed command-line invocation. Also added warning message when this optimisation is switched on.

Aug 11 2016, 10:11 AM

Aug 9 2016

lero_chris updated the diff for D21960: [Sparc] Leon errata fixes passes..

Removed change to CMakeLists.txt that was relevant to a different change and inadvertently added to this review.

Aug 9 2016, 2:59 PM
lero_chris updated the diff for D21960: [Sparc] Leon errata fixes passes..

Addressing issues in previous review.

Aug 9 2016, 2:57 PM
lero_chris retitled D23334: [Sparc][Leon] Speed optimisation to reduce double floating-point instructions to singles. from to [Sparc][Leon] Speed optimisation to reduce double floating-point instructions to singles..
Aug 9 2016, 2:46 PM

Jul 8 2016

lero_chris reopened D21960: [Sparc] Leon errata fixes passes..

Re-opened to address latest comments.

Jul 8 2016, 9:31 AM
lero_chris updated the diff for D21960: [Sparc] Leon errata fixes passes..

Further updates to address some review comments.

Jul 8 2016, 7:02 AM
lero_chris updated the diff for D21960: [Sparc] Leon errata fixes passes..

Update to address change recommended by comments. Small formatting changes. Missing unit tests added.

Jul 8 2016, 3:59 AM

Jul 4 2016

lero_chris added a reviewer for D21960: [Sparc] Leon errata fixes passes.: jacob_hansen.
Jul 4 2016, 1:56 AM

Jul 3 2016

lero_chris updated D21960: [Sparc] Leon errata fixes passes..
Jul 3 2016, 11:20 AM
lero_chris retitled D21960: [Sparc] Leon errata fixes passes. from to [Sparc] Leon errata fixes passes..
Jul 3 2016, 11:17 AM

Jun 28 2016

lero_chris accepted D21806: [SPARC] Implement shouldExtI32* hooks..
Jun 28 2016, 4:07 PM

Jun 24 2016

lero_chris accepted D21683: [Sparc] Allow LEON cpu models to be selected with -mcpu.
Jun 24 2016, 7:49 AM

Jun 16 2016

lero_chris accepted D21029: Support expanding partial-word cmpxchg to full-word cmpxchg in AtomicExpandPass..
Jun 16 2016, 8:29 AM

Jun 8 2016

lero_chris closed D20955: [Sparc] Complex return value ABI compliance..
Jun 8 2016, 7:41 AM
lero_chris updated the diff for D20955: [Sparc] Complex return value ABI compliance..

Small change removing unnecessary class qualifier.

Jun 8 2016, 7:41 AM

Jun 7 2016

lero_chris updated the diff for D20955: [Sparc] Complex return value ABI compliance..

Updated code in accordance with feedback.

Jun 7 2016, 6:43 AM

Jun 3 2016

lero_chris retitled D20955: [Sparc] Complex return value ABI compliance. from to [Sparc] Complex return value ABI compliance..
Jun 3 2016, 4:06 AM

May 23 2016

lero_chris closed D20353: [Sparc][LEON] Erratum fix. Insert NOP after LD or LDF instruction.

Closed and committed after modifications applying to comments and no further activity.

May 23 2016, 3:59 AM
lero_chris accepted D20353: [Sparc][LEON] Erratum fix. Insert NOP after LD or LDF instruction.
May 23 2016, 3:59 AM

May 20 2016

lero_chris updated the diff for D20353: [Sparc][LEON] Erratum fix. Insert NOP after LD or LDF instruction.

Micor formatting changes and removal of commented-out code.

May 20 2016, 2:26 AM
lero_chris updated the diff for D20353: [Sparc][LEON] Erratum fix. Insert NOP after LD or LDF instruction.
  • Changes to feature lists on processors to correct mistakes in which processors need errata fixes.
  • Changes to getSubtargetImpl to be consistent with the implementation in, e.g. the ARM backend.
May 20 2016, 2:17 AM
lero_chris accepted D20419: [Sparc] Add software float option -msoft-float.
May 20 2016, 2:13 AM

May 18 2016

lero_chris retitled D20353: [Sparc][LEON] Erratum fix. Insert NOP after LD or LDF instruction from to [Sparc][LEON] Erratum fix. Insert NOP after LD or LDF instruction.
May 18 2016, 12:53 AM
lero_chris closed D19265: [Sparc] Add Soft Float support.
May 18 2016, 12:51 AM

May 16 2016

lero_chris closed D20098: [Sparc][LEON] Add LEON-specific CASA instruction..

Tests are working. CASA instruction is available as inline ASM and a small change will allow full atomics behaviour for LEON processors when the AtomicExpandPass is completed.

May 16 2016, 1:09 AM
lero_chris accepted D20098: [Sparc][LEON] Add LEON-specific CASA instruction..
May 16 2016, 1:08 AM
lero_chris updated the diff for D20098: [Sparc][LEON] Add LEON-specific CASA instruction..

To avoid regressions in areas of code being worked on by James Knight, I've removed the section of code that will enable atomics for LEON processors.

May 16 2016, 12:57 AM

May 13 2016

lero_chris added a comment to D20098: [Sparc][LEON] Add LEON-specific CASA instruction..

Query ability to get this code checked-into the trunk by commenting-out lines that will regress atomics behaviour (temporarily)

May 13 2016, 8:26 AM

May 12 2016

lero_chris closed D19359: Sparc itineraries support, with LEON3 and LEON4 itineraries added.

Closing, due to lack on new comments. Changes are working as planned.

May 12 2016, 12:31 PM
lero_chris accepted D19359: Sparc itineraries support, with LEON3 and LEON4 itineraries added.
May 12 2016, 12:31 PM

May 10 2016

lero_chris updated the diff for D20098: [Sparc][LEON] Add LEON-specific CASA instruction..

Typos fixed in updated code.

May 10 2016, 1:12 PM
lero_chris updated the diff for D20098: [Sparc][LEON] Add LEON-specific CASA instruction..

Adjustments in line with comments made.

May 10 2016, 1:09 PM
lero_chris added inline comments to D20098: [Sparc][LEON] Add LEON-specific CASA instruction..
May 10 2016, 12:39 PM
lero_chris updated the diff for D20098: [Sparc][LEON] Add LEON-specific CASA instruction..

Combined the two ATOMIC_CMP_SWAP legalisation commands into one.

May 10 2016, 6:48 AM
lero_chris added a reviewer for D20098: [Sparc][LEON] Add LEON-specific CASA instruction.: jyknight.
May 10 2016, 6:04 AM
lero_chris retitled D20098: [Sparc][LEON] Add LEON-specific CASA instruction. from to [Sparc][LEON] Add LEON-specific CASA instruction..
May 10 2016, 6:04 AM

May 9 2016

lero_chris updated the diff for D19359: Sparc itineraries support, with LEON3 and LEON4 itineraries added.

Added unit tests covering changing instruction ordering due to different itineraries for LEON processors.

May 9 2016, 9:03 AM
lero_chris updated the diff for D19911: [Sparc][LEON] Add UMAC and SMAC instruction support for Sparc LEON subtargets.

Modified errors in coded unit tests.

May 9 2016, 2:48 AM

May 4 2016

lero_chris updated the diff for D19368: Allow Sparc back-end to take the address of a function (or other global object).

Unit tests to go with this change.

May 4 2016, 5:14 AM
lero_chris added a reviewer for D19911: [Sparc][LEON] Add UMAC and SMAC instruction support for Sparc LEON subtargets: jyknight.
May 4 2016, 3:56 AM
lero_chris retitled D19911: [Sparc][LEON] Add UMAC and SMAC instruction support for Sparc LEON subtargets from to [Sparc][LEON] Add UMAC and SMAC instruction support for Sparc LEON subtargets.
May 4 2016, 3:56 AM

May 3 2016

lero_chris added a reviewer for D19359: Sparc itineraries support, with LEON3 and LEON4 itineraries added: jyknight.
May 3 2016, 8:30 AM
lero_chris set the repository for D19798: [Sparc] __builtin_setjmp / __builtin_longjmp implementation for 32-bit Sparc. to rL LLVM.
May 3 2016, 3:19 AM
lero_chris updated the diff for D19798: [Sparc] __builtin_setjmp / __builtin_longjmp implementation for 32-bit Sparc..

Made some code modifications, mostly in comments, plus removing redundant code that accidentally made the last check-in.

May 3 2016, 3:18 AM

May 2 2016

lero_chris retitled D19798: [Sparc] __builtin_setjmp / __builtin_longjmp implementation for 32-bit Sparc. from to [Sparc] __builtin_setjmp / __builtin_longjmp implementation for 32-bit Sparc..
May 2 2016, 2:47 AM

Apr 22 2016

lero_chris closed D19368: Allow Sparc back-end to take the address of a function (or other global object).
Apr 22 2016, 1:14 AM

Apr 21 2016

lero_chris retitled D19368: Allow Sparc back-end to take the address of a function (or other global object) from to Allow Sparc back-end to take the address of a function (or other global object).
Apr 21 2016, 8:36 AM
lero_chris added a reviewer for D19359: Sparc itineraries support, with LEON3 and LEON4 itineraries added: jacob_hansen.
Apr 21 2016, 8:29 AM
lero_chris accepted D19265: [Sparc] Add Soft Float support.
Apr 21 2016, 8:28 AM
lero_chris retitled D19359: Sparc itineraries support, with LEON3 and LEON4 itineraries added from to Sparc itineraries support, with LEON3 and LEON4 itineraries added.
Apr 21 2016, 5:14 AM

Mar 22 2016

lero_chris closed D17960: Sparc Add previously unsupported conditional testing for co-processor and traps..

Closed, as well embedded into the codebase at this time.

Mar 22 2016, 3:34 AM
lero_chris accepted D17960: Sparc Add previously unsupported conditional testing for co-processor and traps..
Mar 22 2016, 3:34 AM

Mar 8 2016

lero_chris retitled D17960: Sparc Add previously unsupported conditional testing for co-processor and traps. from to Sparc Add previously unsupported conditional testing for co-processor and traps..
Mar 8 2016, 7:15 AM

Mar 7 2016

lero_chris closed D17133: Sparc back-end: Addition of missing registers and associated instructions..

Checked-in as revision 262135

Mar 7 2016, 5:52 AM

Feb 17 2016

lero_chris updated the diff for D17133: Sparc back-end: Addition of missing registers and associated instructions..

Made amendments following feedback: (1) Added disassembler tests. (2) Moved new FP instruction to correct test file (3) Changed "CoPro" to "Coproc" in both code and filenames. (4) Small white-space formatting changes.

Feb 17 2016, 10:43 AM

Feb 12 2016

lero_chris updated the diff for D17133: Sparc back-end: Addition of missing registers and associated instructions..

Made modifications to code per comments from jyknight.

Feb 12 2016, 2:50 AM

Feb 11 2016

lero_chris retitled D17133: Sparc back-end: Addition of missing registers and associated instructions. from to Sparc back-end: Addition of missing registers..
Feb 11 2016, 2:50 AM

Feb 10 2016

lero_chris retitled D17074: Sparc back-end. Repair of incorrect floating-point condition encodings. from to Sparc back-end. Repair of incorrect floating-point condition encodings..
Feb 10 2016, 7:39 AM