Page MenuHomePhabricator

lbianc (Leonardo Bianconi)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 28 2017, 5:31 AM (107 w, 1 d)

Recent Activity

Apr 30 2018

lbianc added a comment to D44437: Avoid GEP when creating a breakpoint.

ping

Apr 30 2018, 5:42 AM

Apr 16 2018

lbianc added a comment to D44437: Avoid GEP when creating a breakpoint.

Thank you for bearing with me. This looks fine to me now, but I think Greg or Jim should take one more look at the final result.

Apr 16 2018, 5:24 AM

Apr 11 2018

lbianc updated the diff for D44437: Avoid GEP when creating a breakpoint.

Cheking target architecture to run ppc64-call-functtion.test

Apr 11 2018, 4:53 AM

Apr 10 2018

lbianc added inline comments to D44437: Avoid GEP when creating a breakpoint.
Apr 10 2018, 10:36 AM

Apr 9 2018

lbianc updated the diff for D44437: Avoid GEP when creating a breakpoint.
  • Added assembly test case with debug information.
  • Modified refactor of breakpoint address calculation.
Apr 9 2018, 11:54 AM

Apr 6 2018

lbianc added inline comments to D44437: Avoid GEP when creating a breakpoint.
Apr 6 2018, 11:38 AM

Apr 5 2018

lbianc added inline comments to D44437: Avoid GEP when creating a breakpoint.
Apr 5 2018, 7:04 AM

Apr 4 2018

lbianc added a comment to D44437: Avoid GEP when creating a breakpoint.
  • Added test case in lldb-test breakpoint.
  • Code refactored and ComputeBreakpointAddress function created.
Apr 4 2018, 5:54 AM
lbianc updated the diff for D44437: Avoid GEP when creating a breakpoint.
  • Created function to calculate breakpoint address.
  • Added test case in lldb-test
Apr 4 2018, 5:50 AM

Apr 2 2018

lbianc added a comment to D44437: Avoid GEP when creating a breakpoint.

I have added a new test case inside the TestMiBreak.py which is the file where we found the issue, and using the LLDB-mi I can disable the skip prologue, where the code can be tested.

Apr 2 2018, 12:54 PM
lbianc updated the diff for D44437: Avoid GEP when creating a breakpoint.

Modified as requested and added a new test case.

Apr 2 2018, 12:29 PM

Mar 27 2018

lbianc added a comment to D44437: Avoid GEP when creating a breakpoint.

ping

Mar 27 2018, 10:00 AM

Mar 20 2018

lbianc added a comment to D44472: Add and fix some tests for PPC64.

Yes, I'm running Linux and this test was not working for me, so as discussion above, it was separated to be executed on non Linux and Windows, but the variable number got wrong. Sorry for that.

Mar 20 2018, 11:38 AM
lbianc added a comment to D44472: Add and fix some tests for PPC64.

@davide Let me know if you need that I change it on my diff or any other help.

Mar 20 2018, 11:32 AM
lbianc added a comment to D44472: Add and fix some tests for PPC64.

@davide, I think the error is the variable number, as this is the only command in the test case, could you just change from

Mar 20 2018, 11:31 AM
lbianc added a comment to D44472: Add and fix some tests for PPC64.

@davide Are you sure this is the correct patch? This one was not merged yet.
Could you give more details about the issue? Is it related with one of our changes?

Mar 20 2018, 11:02 AM

Mar 16 2018

lbianc added a comment to D44101: Fix some tests for PPC64le architecture.

@labath Could you please commit this change?

Mar 16 2018, 12:04 PM
lbianc updated the summary of D44101: Fix some tests for PPC64le architecture.
Mar 16 2018, 12:01 PM

Mar 14 2018

lbianc added a comment to D44437: Avoid GEP when creating a breakpoint.

I would remove all of the "need_adjust_break_address" and just always call that function in the architecture? Or only call it if m_skip_prologue is true? Seems like this logic should always happen. Seems like magic to only adjust the breakpoint address if the prologue byte size is zero or we aren't skipping the prologue. Feel free to pass any extra args down into AdjustBreakpointAddress() if needed (like m_skip_prologue or prologue_byte_size).

Mar 14 2018, 7:30 AM

Mar 13 2018

lbianc updated subscribers of D44437: Avoid GEP when creating a breakpoint.
Mar 13 2018, 9:09 AM
lbianc created D44437: Avoid GEP when creating a breakpoint.
Mar 13 2018, 9:07 AM

Mar 6 2018

lbianc updated the diff for D44101: Fix some tests for PPC64le architecture.

Reverted changes of
packages/Python/lldbsuite/test/tools/lldb-mi/breakpoint/main.cpp.

Mar 6 2018, 10:54 AM
lbianc added a comment to D44101: Fix some tests for PPC64le architecture.

If you need to force something to use a global entry point you might be able to switch this test to use a shared library that contains that function. This would then require that the global entry point is used?

Mar 6 2018, 10:47 AM
lbianc added a comment to D44101: Fix some tests for PPC64le architecture.

However, this looks like a different story. I don't think that whoever created the skip-prologue option even knew local entry points exist, but I think he would be surprised by the behavior you have here. And I am certain that I, as a user, would be very surprised (and upset) if setting skip-prologue=false would cause my breakpoints to not get hit in some (not so infrequent) conditions. So in light of the different entry points on ppc, I think we should read the "skip-prologue" option as "stop as early as possible" (while still making sure that you stop!), and treat this as a bug and not something that should be hacked around.

Mar 6 2018, 10:22 AM
lbianc added a comment to D44101: Fix some tests for PPC64le architecture.

About the environ symbol issue, I'm going to move to a separate test method in the same test file, is it ok?

Mar 6 2018, 6:11 AM

Mar 5 2018

lbianc updated subscribers of D44101: Fix some tests for PPC64le architecture.
Mar 5 2018, 11:25 AM
lbianc created D44101: Fix some tests for PPC64le architecture.
Mar 5 2018, 11:21 AM

Dec 14 2017

lbianc added a comment to D40846: Add branch flag on branch instructions.
Dec 14 2017, 9:44 AM

Dec 11 2017

lbianc added a comment to D40846: Add branch flag on branch instructions.

@nemanjai, I still don't have permissions for committing, so could you commit this?
Thanks!

Dec 11 2017, 2:16 AM

Dec 6 2017

lbianc updated the diff for D40846: Add branch flag on branch instructions.

Moving flag set to parent

Dec 6 2017, 4:02 AM
lbianc added inline comments to D40846: Add branch flag on branch instructions.
Dec 6 2017, 2:22 AM

Dec 5 2017

lbianc created D40846: Add branch flag on branch instructions.
Dec 5 2017, 11:00 AM