ping

Thank you for bearing with me. This looks fine to me now, but I think Greg or Jim should take one more look at the final result.

Cheking target architecture to run ppc64-call-functtion.test

• Added assembly test case with debug information.
• Modified refactor of breakpoint address calculation.

• Added test case in lldb-test breakpoint.
• Code refactored and ComputeBreakpointAddress function created.

• Created function to calculate breakpoint address.
• Added test case in lldb-test

I have added a new test case inside the TestMiBreak.py which is the file where we found the issue, and using the LLDB-mi I can disable the skip prologue, where the code can be tested.

Modified as requested and added a new test case.

ping

Yes, I'm running Linux and this test was not working for me, so as discussion above, it was separated to be executed on non Linux and Windows, but the variable number got wrong. Sorry for that.

@davide Let me know if you need that I change it on my diff or any other help.

@davide, I think the error is the variable number, as this is the only command in the test case, could you just change from

@davide Are you sure this is the correct patch? This one was not merged yet.
Could you give more details about the issue? Is it related with one of our changes?

@labath Could you please commit this change?

I would remove all of the "need_adjust_break_address" and just always call that function in the architecture? Or only call it if m_skip_prologue is true? Seems like this logic should always happen. Seems like magic to only adjust the breakpoint address if the prologue byte size is zero or we aren't skipping the prologue. Feel free to pass any extra args down into AdjustBreakpointAddress() if needed (like m_skip_prologue or prologue_byte_size).

Reverted changes of
packages/Python/lldbsuite/test/tools/lldb-mi/breakpoint/main.cpp.

If you need to force something to use a global entry point you might be able to switch this test to use a shared library that contains that function. This would then require that the global entry point is used?

However, this looks like a different story. I don't think that whoever created the skip-prologue option even knew local entry points exist, but I think he would be surprised by the behavior you have here. And I am certain that I, as a user, would be very surprised (and upset) if setting skip-prologue=false would cause my breakpoints to not get hit in some (not so infrequent) conditions. So in light of the different entry points on ppc, I think we should read the "skip-prologue" option as "stop as early as possible" (while still making sure that you stop!), and treat this as a bug and not something that should be hacked around.

About the environ symbol issue, I'm going to move to a separate test method in the same test file, is it ok?

@nemanjai, I still don't have permissions for committing, so could you commit this?
Thanks!

Moving flag set to parent