Page MenuHomePhabricator
People laszlo-luminous

laszlo-luminous (Laszlo Kindrat)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 15 2022, 11:56 AM (58 w, 3 d)

Recent Activity
View All

Mar 15 2022

laszlo-luminous added a comment to D119895: [mlir] Fix --convert-func-to-llvm=emit-c-wrappers argument and result attribute handling.

@mehdi_amini @ftynse Could you please help with committing this? Thanks!

Mar 15 2022, 5:47 AM · Restricted Project, Restricted Project

Mar 9 2022

laszlo-luminous added a comment to D119895: [mlir] Fix --convert-func-to-llvm=emit-c-wrappers argument and result attribute handling.

@ftynse ping

Mar 9 2022, 6:41 AM · Restricted Project, Restricted Project

Mar 8 2022

laszlo-luminous updated the diff for D119895: [mlir] Fix --convert-func-to-llvm=emit-c-wrappers argument and result attribute handling.

Update with changes due to new func dialect

Mar 8 2022, 12:28 PM · Restricted Project, Restricted Project

Mar 3 2022

laszlo-luminous added a comment to D119895: [mlir] Fix --convert-func-to-llvm=emit-c-wrappers argument and result attribute handling.

@ftynse Thanks for the review! I don't think I have permissions to commit, could you please help with that?

Mar 3 2022, 3:46 PM · Restricted Project, Restricted Project
laszlo-luminous updated the diff for D119895: [mlir] Fix --convert-func-to-llvm=emit-c-wrappers argument and result attribute handling.

Rebased on main.

Mar 3 2022, 3:42 PM · Restricted Project, Restricted Project

Mar 2 2022

Herald added a project to D119895: [mlir] Fix --convert-func-to-llvm=emit-c-wrappers argument and result attribute handling: Restricted Project.

Is there anything else I should fix on this?

Mar 2 2022, 8:27 AM · Restricted Project, Restricted Project

Feb 25 2022

laszlo-luminous updated the diff for D119895: [mlir] Fix --convert-func-to-llvm=emit-c-wrappers argument and result attribute handling.

Accidentally removed some tests, now they are back.

Feb 25 2022, 3:55 PM · Restricted Project, Restricted Project
laszlo-luminous updated the diff for D119895: [mlir] Fix --convert-func-to-llvm=emit-c-wrappers argument and result attribute handling.

fixed error message to start with lowercase

Feb 25 2022, 3:50 PM · Restricted Project, Restricted Project
laszlo-luminous added inline comments to D119895: [mlir] Fix --convert-func-to-llvm=emit-c-wrappers argument and result attribute handling.
Feb 25 2022, 3:46 PM · Restricted Project, Restricted Project
laszlo-luminous added a comment to D119895: [mlir] Fix --convert-func-to-llvm=emit-c-wrappers argument and result attribute handling.

I think I addressed all points, see my inline comment about checking for FuncOpInterface.

Feb 25 2022, 11:56 AM · Restricted Project, Restricted Project
laszlo-luminous updated the diff for D119895: [mlir] Fix --convert-func-to-llvm=emit-c-wrappers argument and result attribute handling.

Moved the llvm.struct_attrs attribute to the dialect, and added verifiers with tests.

Feb 25 2022, 11:46 AM · Restricted Project, Restricted Project

Feb 24 2022

laszlo-luminous added a comment to D119895: [mlir] Fix --convert-func-to-llvm=emit-c-wrappers argument and result attribute handling.

Ah okay, I misunderstood and thought you meant more unit tests by verification...

Feb 24 2022, 3:55 PM · Restricted Project, Restricted Project
laszlo-luminous added a comment to D119895: [mlir] Fix --convert-func-to-llvm=emit-c-wrappers argument and result attribute handling.

@ftynse I'm happy to add more verification and tests. Do you have any suggestions what they should cover?

Feb 24 2022, 11:16 AM · Restricted Project, Restricted Project

Feb 15 2022

laszlo-luminous updated the diff for D119895: [mlir] Fix --convert-func-to-llvm=emit-c-wrappers argument and result attribute handling.

Updated patch with context, and removed some trailing whitespaces

Feb 15 2022, 3:58 PM · Restricted Project, Restricted Project
laszlo-luminous requested review of D119895: [mlir] Fix --convert-func-to-llvm=emit-c-wrappers argument and result attribute handling.
Feb 15 2022, 2:47 PM · Restricted Project, Restricted Project