- User Since
- Feb 15 2022, 11:56 AM (58 w, 3 d)
Mar 15 2022
@mehdi_amini @ftynse Could you please help with committing this? Thanks!
Mar 9 2022
Mar 8 2022
Update with changes due to new func dialect
Mar 3 2022
@ftynse Thanks for the review! I don't think I have permissions to commit, could you please help with that?
Rebased on main.
Mar 2 2022
Is there anything else I should fix on this?
Feb 25 2022
Accidentally removed some tests, now they are back.
fixed error message to start with lowercase
I think I addressed all points, see my inline comment about checking for FuncOpInterface.
Moved the llvm.struct_attrs attribute to the dialect, and added verifiers with tests.
Feb 24 2022
Ah okay, I misunderstood and thought you meant more unit tests by verification...
@ftynse I'm happy to add more verification and tests. Do you have any suggestions what they should cover?
Feb 15 2022
Updated patch with context, and removed some trailing whitespaces