- User Since
- May 3 2018, 8:32 AM (163 w, 2 d)
Oct 25 2018
Oct 24 2018
Oct 19 2018
Oct 2 2018
Thanks for the clarification. Is there any way to manually close the review?
I committed this as r342894 but for some reason the review didn't complete. Apologies, the last LLVM commits I did were pre-phabricator so it seems I messed up somewhere. Any pointers appreciated.
Sep 24 2018
Sep 20 2018
Updated patch with ruiu's suggestions. Also added a test for the warning emitted when an unknown /debugtype option is used.
Updated patch based on suggestions from ruiu
Moved/inlined parsing and diagnostic code into the specialized parse functions to (hopefully) simplify the calls in LinkerDriver::link().
Sep 12 2018
Sep 5 2018
Renamed DebugGeneration enum (name was based on MSDN description of /debug argument) to DebugKind. Flattened the argument handling code to be a little clearer.
Aug 28 2018
Aug 11 2018
Generalized /debug handling based on suggestion from ruiu.
Aug 7 2018
Jul 17 2018
May 16 2018
Also: Just noticed that response files aren't being expanded inline in the stored command-line (as per MSVC link.exe). I'll open a bug for it.
May 14 2018
A few issues. On the DOS command-line I can shoehorn in some escaped double-quotes using /manifestuac:"level='asInvoker' uiAccess=""false""" and still generate a PDB. However:
May 11 2018
Hi All, What's the consensus on the additional checks? I can try and add support for the theoretical corner cases but without being able to construct test cases I'm not sure how useful it'd be.
May 8 2018
May 7 2018
Extracted implementation to a quote() function.