Page MenuHomePhabricator

lantictac (Will Wilson)
User

Projects

User does not belong to any projects.

User Details

User Since
May 3 2018, 8:32 AM (118 w, 1 d)

Recent Activity

Oct 25 2018

lantictac committed rL345258: [ms] Prevent explicit constructor name lookup if scope is missing.
[ms] Prevent explicit constructor name lookup if scope is missing
Oct 25 2018, 4:47 AM
lantictac committed rC345258: [ms] Prevent explicit constructor name lookup if scope is missing.
[ms] Prevent explicit constructor name lookup if scope is missing
Oct 25 2018, 4:47 AM
lantictac closed D53441: [ms] Prevent explicit constructor name lookup if scope is missing.
Oct 25 2018, 4:47 AM · Restricted Project

Oct 24 2018

lantictac added a reviewer for D53441: [ms] Prevent explicit constructor name lookup if scope is missing: rnk.
Oct 24 2018, 3:59 AM · Restricted Project

Oct 19 2018

lantictac created D53441: [ms] Prevent explicit constructor name lookup if scope is missing.
Oct 19 2018, 9:56 AM · Restricted Project

Oct 2 2018

lantictac added a comment to D50404: [lld-link] Generalize handling of /debug and /debug:{none,full,fastlink,ghash,symtab}.

Thanks for the clarification. Is there any way to manually close the review?

Oct 2 2018, 12:30 PM · Restricted Project, lld
lantictac added a comment to D50404: [lld-link] Generalize handling of /debug and /debug:{none,full,fastlink,ghash,symtab}.

I committed this as r342894 but for some reason the review didn't complete. Apologies, the last LLVM commits I did were pre-phabricator so it seems I messed up somewhere. Any pointers appreciated.

Oct 2 2018, 12:04 PM · Restricted Project, lld

Sep 24 2018

lantictac committed rLLD342894: [lld-link] Generalize handling of /debug and /debug:{none,full,fastlink,ghash….
[lld-link] Generalize handling of /debug and /debug:{none,full,fastlink,ghash…
Sep 24 2018, 8:31 AM
lantictac committed rL342894: [lld-link] Generalize handling of /debug and /debug:{none,full,fastlink,ghash….
[lld-link] Generalize handling of /debug and /debug:{none,full,fastlink,ghash…
Sep 24 2018, 8:31 AM

Sep 20 2018

lantictac updated the diff for D50404: [lld-link] Generalize handling of /debug and /debug:{none,full,fastlink,ghash,symtab}.

Updated patch with ruiu's suggestions. Also added a test for the warning emitted when an unknown /debugtype option is used.

Sep 20 2018, 2:57 PM · Restricted Project, lld
lantictac updated the diff for D50404: [lld-link] Generalize handling of /debug and /debug:{none,full,fastlink,ghash,symtab}.

Updated patch based on suggestions from ruiu

Sep 20 2018, 10:05 AM · Restricted Project, lld
lantictac updated the diff for D50404: [lld-link] Generalize handling of /debug and /debug:{none,full,fastlink,ghash,symtab}.

Moved/inlined parsing and diagnostic code into the specialized parse functions to (hopefully) simplify the calls in LinkerDriver::link().

Sep 20 2018, 8:58 AM · Restricted Project, lld

Sep 12 2018

lantictac added a comment to D50404: [lld-link] Generalize handling of /debug and /debug:{none,full,fastlink,ghash,symtab}.

Ping

Sep 12 2018, 8:36 AM · Restricted Project, lld

Sep 5 2018

lantictac added inline comments to D50404: [lld-link] Generalize handling of /debug and /debug:{none,full,fastlink,ghash,symtab}.
Sep 5 2018, 9:18 AM · Restricted Project, lld
lantictac updated the diff for D50404: [lld-link] Generalize handling of /debug and /debug:{none,full,fastlink,ghash,symtab}.

Renamed DebugGeneration enum (name was based on MSDN description of /debug argument) to DebugKind. Flattened the argument handling code to be a little clearer.

Sep 5 2018, 9:13 AM · Restricted Project, lld

Aug 28 2018

lantictac added a comment to D50404: [lld-link] Generalize handling of /debug and /debug:{none,full,fastlink,ghash,symtab}.

Ping

Aug 28 2018, 3:19 PM · Restricted Project, lld

Aug 11 2018

lantictac updated the diff for D50404: [lld-link] Generalize handling of /debug and /debug:{none,full,fastlink,ghash,symtab}.

Generalized /debug handling based on suggestion from ruiu.

Aug 11 2018, 3:10 AM · Restricted Project, lld

Aug 7 2018

lantictac created D50404: [lld-link] Generalize handling of /debug and /debug:{none,full,fastlink,ghash,symtab}.
Aug 7 2018, 12:45 PM · Restricted Project, lld

Jul 17 2018

lantictac added a comment to D46427: [PDB] Quote linker arguments containing spaces (mimic MSVC).

Also: Just noticed that response files aren't being expanded inline in the stored command-line (as per MSVC link.exe). I'll open a bug for it.

Second that.
Would be nice to expand response files. Did you open a bug for this/are you working on this?

Jul 17 2018, 8:17 AM · lld

May 16 2018

lantictac added a comment to D46427: [PDB] Quote linker arguments containing spaces (mimic MSVC).

Also: Just noticed that response files aren't being expanded inline in the stored command-line (as per MSVC link.exe). I'll open a bug for it.

May 16 2018, 2:55 PM · lld

May 14 2018

lantictac added a comment to D46427: [PDB] Quote linker arguments containing spaces (mimic MSVC).

A few issues. On the DOS command-line I can shoehorn in some escaped double-quotes using /manifestuac:"level='asInvoker' uiAccess=""false""" and still generate a PDB. However:

May 14 2018, 7:41 AM · lld

May 11 2018

lantictac added inline comments to D46427: [PDB] Quote linker arguments containing spaces (mimic MSVC).
May 11 2018, 11:14 AM · lld
lantictac added a comment to D46427: [PDB] Quote linker arguments containing spaces (mimic MSVC).

Hi All, What's the consensus on the additional checks? I can try and add support for the theoretical corner cases but without being able to construct test cases I'm not sure how useful it'd be.

May 11 2018, 10:49 AM · lld

May 8 2018

lantictac added inline comments to D46427: [PDB] Quote linker arguments containing spaces (mimic MSVC).
May 8 2018, 11:38 AM · lld

May 7 2018

lantictac updated the diff for D46427: [PDB] Quote linker arguments containing spaces (mimic MSVC).

Extracted implementation to a quote() function.

May 7 2018, 3:54 PM · lld
lantictac added inline comments to D46427: [PDB] Quote linker arguments containing spaces (mimic MSVC).
May 7 2018, 3:03 PM · lld

May 4 2018

lantictac created D46427: [PDB] Quote linker arguments containing spaces (mimic MSVC).
May 4 2018, 6:01 AM · lld