In D144911#4156484, @tra wrote:

I assume the patch is ready for review. At least that's what phabricator says. LMK if you're still working on it.

Adding the smoke tests for f8e5m2 and f6e4m3 types

In D140088#4005160, @arsenm wrote:

In D140088#4005153, @arsenm wrote:

In D140088#4005142, @kushanam wrote:

In D140088#4005134, @arsenm wrote:

Tests still missing

Hi @arsenm, I looked at the existing tests and got an assumption that the existing way to test those, is to have the codegen pipeline supporting the datatype in the "Target" level. That is something I am working on for the follow up patch and thought then I could add the tests. If you could give me a pointer to the existing tests that I might have missed, I would add them. Thank you in advance!

All of the IR changes are testable without codegen support. Needs some tests in test/Assembler, test/Bitcode, test/Verifier, and some constant folding tests in test/Transforms/InstSimplify. See 8c24f33158d81d5f4b0c5d27c2f07396f0f1484b which added bfloat (although this includes far fewer tests than I would have liked to see. For example it's missing the all important bitcode compatibility tests)

I think I covered all the bases for testing an IR change in D139902. This is a bit broader as it's a type

In D140088#4005134, @arsenm wrote:

Tests still missing

Addressing review commnents, adding funtionality to pass the MLIR tests

addressing the "Comments mention f16 vectors (should be f8)" comment

Sorry, the issue was with my amend. Resubmitted the patch..

add dealloc alias check to bufferization
Traverse the cloneOp for aliases to find the alloc op

In D131797#3730232, @frgossen wrote:

It's still failing the linter
You can likely just run git-clang-format HEAD~1 to fix this.

add dealloc alias check to bufferization
Traverse the cloneOp for aliases to find the alloc op

add dealloc alias check to bufferization
Traverse the cloneOp for aliases to find the alloc op

add dealloc alias check to bufferization
Traverse the cloneOp for aliases to find the alloc op

add dealloc alias check to bufferization
Traverse the cloneOp for aliases to find the alloc op

Moved to D131740

Add dealloc alias check to bufferization
Traverse the cloneOp for aliases to find the alloc op

add dealloc alias check to bufferization
Traverse the cloneOp for aliases to find the alloc op

Add dealloc alias check to bufferization
Traverse the cloneOp for aliases to find the alloc op

CC @frgossen for review.