Page MenuHomePhabricator

ksvladimir (Volodymyr Kuznetsov)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 3 2014, 9:07 AM (263 w, 15 h)

Recent Activity

Jun 23 2015

ksvladimir added inline comments to D10598: SafeStack documentation improvements.
Jun 23 2015, 2:52 PM
ksvladimir updated the diff for D10598: SafeStack documentation improvements.

Fixed a typo Integirty -> Integrity

Jun 23 2015, 2:52 PM
ksvladimir added a comment to D10598: SafeStack documentation improvements.

Thanks a lot for the review! No, I do not have commit access, please feel free to commit on my behalf.

Jun 23 2015, 2:50 PM
ksvladimir added a comment to D10598: SafeStack documentation improvements.

Thanks for the comments! I've addressed them in the updated patch.

Jun 23 2015, 4:46 AM
ksvladimir updated the diff for D10598: SafeStack documentation improvements.

Addressed feedback by jfb:

Jun 23 2015, 4:43 AM

Jun 22 2015

ksvladimir added a comment to D10598: SafeStack documentation improvements.

Updated to include the cfe-commits list as a subscriber.

Jun 22 2015, 5:11 AM
ksvladimir added a comment to D10600: Update SafeStack TODO in the safestack.cc.

Updated to include the cfe-commits list as a subscriber.

Jun 22 2015, 5:10 AM
ksvladimir retitled D10600: Update SafeStack TODO in the safestack.cc from to Update SafeStack TODO in the safestack.cc.
Jun 22 2015, 5:08 AM
ksvladimir updated subscribers of D10598: SafeStack documentation improvements.
Jun 22 2015, 3:58 AM
ksvladimir retitled D10598: SafeStack documentation improvements from to SafeStack documentation improvements.
Jun 22 2015, 3:58 AM

May 30 2015

ksvladimir added a comment to D6094: Protection against stack-based memory corruption errors using SafeStack.

Both dynamic and static leaks verifiers are great ideas! In practice, it might also be useful to have a pass that looks for all uses of known ways to leak the stack pointer in the IR, i.e., frameaddr-like intrinsics, gcroot, inline asm that accesses %rsp, etc. This wouldn't be as future proof as binary verifiers, but might be easier to implement and use.

May 30 2015, 11:50 PM

May 23 2015

ksvladimir added inline comments to D6096: Protection against stack-based memory corruption errors using SafeStack: compiler-rt runtime support library.
May 23 2015, 5:15 AM

May 19 2015

ksvladimir added inline comments to D6094: Protection against stack-based memory corruption errors using SafeStack.
May 19 2015, 10:09 PM
ksvladimir added inline comments to D6096: Protection against stack-based memory corruption errors using SafeStack: compiler-rt runtime support library.
May 19 2015, 4:05 PM
ksvladimir added inline comments to D6095: Protection against stack-based memory corruption errors using SafeStack: Clang command line option and function attribute.
May 19 2015, 3:51 PM

Apr 24 2015

ksvladimir added a comment to D6094: Protection against stack-based memory corruption errors using SafeStack.

Peter, thank you for helping with the patches! The updated patches also include minor bugfixes, cleanup and improved documentation. We also prepared a few more patches to submit separately, which enable applying SafeStack to shared libraries, support ucontext API and sigaltstack, and implement some platform-specific performance improvements.

Apr 24 2015, 6:00 AM

Nov 14 2014

ksvladimir updated the diff for D6095: Protection against stack-based memory corruption errors using SafeStack: Clang command line option and function attribute.

Fixed symbol naming on Mac.

Nov 14 2014, 9:54 PM
ksvladimir updated the diff for D6096: Protection against stack-based memory corruption errors using SafeStack: compiler-rt runtime support library.

Simplified safestack public symbol names.

Nov 14 2014, 10:17 AM
ksvladimir updated the diff for D6095: Protection against stack-based memory corruption errors using SafeStack: Clang command line option and function attribute.

Added documentation for the no_safe_stack attribute. Simplified safestack public symbol names.

Nov 14 2014, 10:16 AM
ksvladimir updated the diff for D6094: Protection against stack-based memory corruption errors using SafeStack.

Simplified safestack public symbol names.

Nov 14 2014, 10:14 AM

Nov 12 2014

ksvladimir updated the diff for D6096: Protection against stack-based memory corruption errors using SafeStack: compiler-rt runtime support library.

Added tests for the safestack runtime support library.

Nov 12 2014, 2:34 AM
ksvladimir updated the diff for D6095: Protection against stack-based memory corruption errors using SafeStack: Clang command line option and function attribute.

Added tests for attribute((no_safe_stack)).

Nov 12 2014, 2:34 AM

Nov 10 2014

ksvladimir updated the diff for D6096: Protection against stack-based memory corruption errors using SafeStack: compiler-rt runtime support library.

Move mmap's #ifdef out of the functions to improve readability.

Nov 10 2014, 9:47 AM
ksvladimir updated the diff for D6095: Protection against stack-based memory corruption errors using SafeStack: Clang command line option and function attribute.

Added unittests for the -fsafe-stack and -fno-safe-stack options in clang and -fstack-protector 4 option in clang-cc1.

Nov 10 2014, 9:45 AM

Nov 4 2014

ksvladimir added a comment to D6096: Protection against stack-based memory corruption errors using SafeStack: compiler-rt runtime support library.

You can find the detailed changelog since the previous submission in our repo: https://github.com/cpi-llvm/compiler-rt/commits/safestack-r221153

Nov 4 2014, 1:43 PM
ksvladimir added a comment to D6095: Protection against stack-based memory corruption errors using SafeStack: Clang command line option and function attribute.

You can find the detailed changelog since the previous submission in our repo: https://github.com/cpi-llvm/clang/commits/safestack-r221153

Nov 4 2014, 1:43 PM
ksvladimir added a comment to D6094: Protection against stack-based memory corruption errors using SafeStack.

You can find the detailed changelog since the previous submission in our repo: https://github.com/cpi-llvm/llvm/commits/safestack-r221153

Nov 4 2014, 1:43 PM
ksvladimir updated the diff for D6096: Protection against stack-based memory corruption errors using SafeStack: compiler-rt runtime support library.

Addresses comments on the previous submission.

Nov 4 2014, 11:20 AM
ksvladimir updated the diff for D6095: Protection against stack-based memory corruption errors using SafeStack: Clang command line option and function attribute.

Addresses comments on the previous submission.

Nov 4 2014, 11:20 AM
ksvladimir updated the diff for D6094: Protection against stack-based memory corruption errors using SafeStack.

Addresses comments on the previous submission.

Nov 4 2014, 11:20 AM
ksvladimir added a comment to D6094: Protection against stack-based memory corruption errors using SafeStack.

Yes, running SafeStack with opt would certainly simplify debugging.
However, we want to apply the SafeStack transformation as the very last
step before code generation, to make sure that it operate on the final
stack layout. Doing so earlier might prevent some other optimizations from
succeeding (as it e.g., complicates the alias analysis, breaks mem2reg
pass, etc.) or might force the SafeStack pass move more objects to the
unsafe stack than necessary (e.g., if the operations on such objects that
the SafeStack considered potentially unsafe are actually later optimized
away). In principle, in some pathological cases, it might even break
correctness, e.g., if the SafeStack decides to keep some object on the
normal stack, but the subsequent optimization or instrumentation passes add
potentially unsafe operations on such objects.

Nov 4 2014, 3:06 AM

Nov 3 2014

ksvladimir added a comment to D6096: Protection against stack-based memory corruption errors using SafeStack: compiler-rt runtime support library.

Hi David,

Nov 3 2014, 10:52 AM
ksvladimir retitled D6096: Protection against stack-based memory corruption errors using SafeStack: compiler-rt runtime support library from to Protection against stack-based memory corruption errors using SafeStack: compiler-rt runtime support library.
Nov 3 2014, 9:44 AM
ksvladimir retitled D6095: Protection against stack-based memory corruption errors using SafeStack: Clang command line option and function attribute from to Protection against stack-based memory corruption errors using SafeStack: Clang command line option and function attribute.
Nov 3 2014, 9:41 AM
ksvladimir retitled D6094: Protection against stack-based memory corruption errors using SafeStack from to Protection against stack-based memory corruption errors using SafeStack.
Nov 3 2014, 9:35 AM