Page MenuHomePhabricator

kromanenkov (Kirill Romanenkov)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 6 2016, 2:44 AM (137 w, 3 h)

Recent Activity

Dec 3 2017

kromanenkov added a comment to D40715: [analyser] different.LabelInsideSwitch checker implementation.

A few comments.

Dec 3 2017, 7:26 AM · Restricted Project

Nov 9 2017

kromanenkov accepted D39800: [analyzer] pr34404: Fix a crash on pointers to members in nested anonymous structures..
Nov 9 2017, 12:31 PM
kromanenkov added a comment to D39800: [analyzer] pr34404: Fix a crash on pointers to members in nested anonymous structures..

@NoQ Do we need to change a DeclaratorDecl field in PointerToMember SVal to something more common, like ValueDecl, to support IndirectFieldDecl as well?
Of course in another patch, this one LGTM.

Nov 9 2017, 9:02 AM

Apr 11 2017

kromanenkov added inline comments to D31887: [clangd] Add documentation page.
Apr 11 2017, 4:03 AM · Restricted Project

Jan 10 2017

kromanenkov accepted D28033: [analyzer] Treat pointers to static member functions as function pointers.

Looks good to me, apart from a very small cavil introduced in not even your code. Thanks for not leaving pointers to static member functions out of account!

Jan 10 2017, 6:10 AM

Dec 15 2016

kromanenkov updated the diff for D25475: [analyzer] Add a new SVal to support pointer-to-member operations..

Fix issues pointed by @dcoughlin and rebase patch on master.

Dec 15 2016, 9:19 AM

Dec 14 2016

kromanenkov updated the diff for D25475: [analyzer] Add a new SVal to support pointer-to-member operations..

Thanks for your comments, Devin! You were right about the list of path specifiers construction order, so i fix it. Now the base specifier list is being used for figuring out the correct subobject field. Also this diff changes fallthrough behavior in some cases and renames functions with 'cons' prefix.

Dec 14 2016, 2:11 AM

Dec 13 2016

kromanenkov added inline comments to D25475: [analyzer] Add a new SVal to support pointer-to-member operations..
Dec 13 2016, 5:05 AM
kromanenkov added inline comments to D25475: [analyzer] Add a new SVal to support pointer-to-member operations..
Dec 13 2016, 4:19 AM

Nov 29 2016

kromanenkov added inline comments to D25475: [analyzer] Add a new SVal to support pointer-to-member operations..
Nov 29 2016, 6:45 AM
kromanenkov updated the diff for D25475: [analyzer] Add a new SVal to support pointer-to-member operations..

Thanks for your comments, Artem! Make function name less ambiguous. Also I take liberty to update analogical function name.

Nov 29 2016, 6:38 AM

Nov 28 2016

kromanenkov added a comment to D25475: [analyzer] Add a new SVal to support pointer-to-member operations..

ping

Nov 28 2016, 3:07 AM

Nov 18 2016

kromanenkov added a comment to D25475: [analyzer] Add a new SVal to support pointer-to-member operations..

ping

Nov 18 2016, 5:48 AM

Nov 7 2016

kromanenkov updated the diff for D25475: [analyzer] Add a new SVal to support pointer-to-member operations..

According to dcoughlin suggestion PointerToMember SVal is now modeled as a PointerUnion of DeclaratorDecl and bump pointer-allocated object stored DeclaratorDecl and immutable linked list of CXXBaseSpecifiers.

Nov 7 2016, 8:48 AM

Oct 24 2016

kromanenkov added inline comments to D25475: [analyzer] Add a new SVal to support pointer-to-member operations..
Oct 24 2016, 6:24 AM

Oct 18 2016

kromanenkov updated the diff for D25475: [analyzer] Add a new SVal to support pointer-to-member operations..

Null pointer-to-member dereference is now modeled as UndefinedVal. Fixing this also releases us from loading from nonloc SVal.
I delete an assertion suppression in ExprEngine::performTrivialCopy because I can't reproduce its violation.

Oct 18 2016, 9:22 AM

Oct 14 2016

kromanenkov added inline comments to D25475: [analyzer] Add a new SVal to support pointer-to-member operations..
Oct 14 2016, 12:40 PM

Oct 11 2016

kromanenkov retitled D25475: [analyzer] Add a new SVal to support pointer-to-member operations. from to [analyzer] Add a new SVal to support pointer-to-member operations..
Oct 11 2016, 7:19 AM