Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

People kiwixz

kiwixz (kiwixz)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 25 2020, 5:27 PM (187 w, 3 d)

Recent Activity
View All

May 10 2023

kiwixz added a comment to D146520: [clang-tidy] Fix checks filter with warnings-as-errors.

Ping.

May 10 2023, 12:43 PM · Restricted Project, Restricted Project

Apr 9 2023

kiwixz added a comment to D146520: [clang-tidy] Fix checks filter with warnings-as-errors.

I'm not sure how to test this, is there any check dependency we can rely on with hardcoded tests ?

Apr 9 2023, 7:10 PM · Restricted Project, Restricted Project

Mar 25 2023

kiwixz added a comment to D146520: [clang-tidy] Fix checks filter with warnings-as-errors.

Your understanding is correct, I'm currently just trying to hide them at the end (warnings-as-errors or not).
This is how it worked until 5d12b13b0b26bc58b02ee23c369da8b83240cceb (present in LLVM 16) which inadvertently bypass the filters with warnings-as-errors.

Mar 25 2023, 6:28 AM · Restricted Project, Restricted Project
kiwixz updated the summary of D146520: [clang-tidy] Fix checks filter with warnings-as-errors.
Mar 25 2023, 6:13 AM · Restricted Project, Restricted Project

Mar 21 2023

kiwixz requested review of D146520: [clang-tidy] Fix checks filter with warnings-as-errors.
Mar 21 2023, 5:44 AM · Restricted Project, Restricted Project

Mar 8 2021

kiwixz abandoned D88668: [CUDA] Add support for 11.1.

Fixed in a much proper way in D89832. Thanks @tra!

Mar 8 2021, 1:36 AM · Restricted Project

Oct 1 2020

kiwixz added a comment to D88668: [CUDA] Add support for 11.1.
In D88668#2306393, @jlebar wrote:

It looks like 11.1 doesn't have a version.txt file

Yikes, this is a problem if we can't tell the difference between CUDA versions!

Oct 1 2020, 9:21 AM · Restricted Project
kiwixz requested review of D88668: [CUDA] Add support for 11.1.
Oct 1 2020, 9:12 AM · Restricted Project