Page MenuHomePhabricator

khuey (Kyle Huey)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 6 2023, 6:23 PM (16 w, 4 d)

Recent Activity

Tue, May 23

khuey added a comment to D143463: [X86] Use the CFA when appropriate for better variable locations around calls..

Just to confirm my understanding, this should have no interaction with the shrink-wrapping optimisation pass because there shouldn't be any stack-stored variables before frame setup occurs, yes?

Tue, May 23, 6:50 PM · Restricted Project, Restricted Project
khuey added inline comments to D143463: [X86] Use the CFA when appropriate for better variable locations around calls..
Tue, May 23, 2:43 PM · Restricted Project, Restricted Project

Sun, May 21

khuey added a comment to D143463: [X86] Use the CFA when appropriate for better variable locations around calls..

I filed https://github.com/llvm/llvm-project/issues/62840 and https://github.com/llvm/llvm-project/issues/62841 on the LLDB issues.

Sun, May 21, 12:17 PM · Restricted Project, Restricted Project
khuey requested review of D143463: [X86] Use the CFA when appropriate for better variable locations around calls..
Sun, May 21, 11:26 AM · Restricted Project, Restricted Project
khuey updated the diff for D143463: [X86] Use the CFA when appropriate for better variable locations around calls..

Revert back to the heuristic based approach for using the CFA only when it affects correctness.

Sun, May 21, 11:26 AM · Restricted Project, Restricted Project
khuey reopened D143463: [X86] Use the CFA when appropriate for better variable locations around calls..
Sun, May 21, 10:59 AM · Restricted Project, Restricted Project

Wed, May 17

khuey added a comment to D143463: [X86] Use the CFA when appropriate for better variable locations around calls..

So this is actually a case of what I said earlier about there possibly being old tools out there that don't know how to cope with CFI. Turns out one of them is this "frame diagnose" feature in lldb.

Wed, May 17, 8:31 AM · Restricted Project, Restricted Project

Tue, May 16

khuey added a comment to D143463: [X86] Use the CFA when appropriate for better variable locations around calls..

Yeah, that gets some of the lldb-api tests to run.

Tue, May 16, 8:38 AM · Restricted Project, Restricted Project
khuey added a comment to D143463: [X86] Use the CFA when appropriate for better variable locations around calls..

Even after enabling and building lldb make check-lldb-api says all the tests are unsupported.

Tue, May 16, 5:49 AM · Restricted Project, Restricted Project

Mon, May 15

khuey added a comment to D143463: [X86] Use the CFA when appropriate for better variable locations around calls..

Or maybe I need to explicitly enable lldb first ... I don't see an lldb binary in my build.

Mon, May 15, 6:21 PM · Restricted Project, Restricted Project
khuey added a comment to D143463: [X86] Use the CFA when appropriate for better variable locations around calls..

How do I run these tests? make check either doesn't include them, or they pass on my machine.

Mon, May 15, 6:16 PM · Restricted Project, Restricted Project
khuey added a comment to D143463: [X86] Use the CFA when appropriate for better variable locations around calls..

Poke. If nobody else is going to review this can someone land it?

Mon, May 15, 6:52 AM · Restricted Project, Restricted Project

Apr 17 2023

khuey added a comment to D143463: [X86] Use the CFA when appropriate for better variable locations around calls..

Thanks. I don't have commit access so after whoever else you want to look at it is satisfied someone will need to land this :)

Apr 17 2023, 2:32 PM · Restricted Project, Restricted Project

Apr 14 2023

khuey requested review of D143463: [X86] Use the CFA when appropriate for better variable locations around calls..

Other than dbg-baseptr.ll, the test changes are all adjusting for the slightly larger DW_AT_frame_base value.

Apr 14 2023, 3:08 PM · Restricted Project, Restricted Project
khuey updated the diff for D143463: [X86] Use the CFA when appropriate for better variable locations around calls..

Use the CFA as the DWARF frame base whenever it's present.

Apr 14 2023, 3:06 PM · Restricted Project, Restricted Project

Apr 13 2023

khuey planned changes to D143463: [X86] Use the CFA when appropriate for better variable locations around calls..
Apr 13 2023, 1:02 PM · Restricted Project, Restricted Project
khuey added a comment to D143463: [X86] Use the CFA when appropriate for better variable locations around calls..

I'm happy to update this to do 1 + 2 + 3 too, it's not hard.

Apr 13 2023, 11:34 AM · Restricted Project, Restricted Project

Apr 12 2023

khuey added a comment to D143463: [X86] Use the CFA when appropriate for better variable locations around calls..

Very reasonable, but if GCC is already using the CFA unconditionally it seems likely that implies a pretty good support base?

Apr 12 2023, 4:26 PM · Restricted Project, Restricted Project

Apr 11 2023

khuey added inline comments to D143463: [X86] Use the CFA when appropriate for better variable locations around calls..
Apr 11 2023, 9:17 PM · Restricted Project, Restricted Project
khuey added a comment to D143463: [X86] Use the CFA when appropriate for better variable locations around calls..

As a bit of a side-note, I think X86 always maintains a "precise CFA" to refer to, but that may not always be true (see https://reviews.llvm.org/D14948).

Apr 11 2023, 9:12 PM · Restricted Project, Restricted Project

Apr 10 2023

khuey added a comment to D143463: [X86] Use the CFA when appropriate for better variable locations around calls..

Poke again? This has been sitting for two months now.

Apr 10 2023, 8:55 PM · Restricted Project, Restricted Project

Feb 21 2023

khuey added a comment to D143463: [X86] Use the CFA when appropriate for better variable locations around calls..

Pretty sure those test failures aren't me.

Feb 21 2023, 7:03 AM · Restricted Project, Restricted Project

Feb 6 2023

khuey requested review of D143463: [X86] Use the CFA when appropriate for better variable locations around calls..
Feb 6 2023, 10:18 PM · Restricted Project, Restricted Project