Page MenuHomePhabricator

khazem (Kareem Khazem)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 18 2016, 5:05 PM (167 w, 6 d)

Recent Activity

Dec 16 2016

khazem retitled D27854: [analyzer] Add check for mutex acquisition during interrupt context in Magenta kernel from to [analyzer] Add check for mutex acquisition during interrupt context in Magenta kernel.
Dec 16 2016, 9:39 AM

Nov 30 2016

khazem added a comment to D26753: ASTImporter: improve support for C++ templates.

Sorry for the late comment, but one of the tests that this introduces is breaking on my end:

Nov 30 2016, 11:00 AM

Nov 28 2016

khazem added a child revision for D26753: ASTImporter: improve support for C++ templates: D27181: [ASTImporter] Support for importing UsingDecl and UsingShadowDecl.
Nov 28 2016, 6:08 PM
khazem updated D27181: [ASTImporter] Support for importing UsingDecl and UsingShadowDecl.
Nov 28 2016, 6:08 PM
khazem retitled D27181: [ASTImporter] Support for importing UsingDecl and UsingShadowDecl from to [ASTImporter] Support for importing UsingDecl and UsingShadowDecl.
Nov 28 2016, 6:05 PM

Nov 27 2016

khazem updated the diff for D26904: [astimporter] Support importing CXXDependentScopeMemberExpr and FunctionTemplateDecl.

Thanks for the comments, Aleksei!

Nov 27 2016, 9:44 PM

Nov 23 2016

khazem added a comment to D26328: [ASTImporter] Added ability to import AtomicType nodes.

Thanks, Gábor! Please do commit this (it's currently Thanksgiving week in the US).

Nov 23 2016, 7:29 AM

Nov 22 2016

khazem updated D27033: [ASTImporter] Support importing UnresolvedLookupExpr nodes.
Nov 22 2016, 8:04 PM
khazem added a child revision for D26904: [astimporter] Support importing CXXDependentScopeMemberExpr and FunctionTemplateDecl: D27033: [ASTImporter] Support importing UnresolvedLookupExpr nodes.
Nov 22 2016, 8:04 PM
khazem retitled D27033: [ASTImporter] Support importing UnresolvedLookupExpr nodes from to [ASTImporter] Support importing UnresolvedLookupExpr nodes.
Nov 22 2016, 8:02 PM

Nov 21 2016

khazem updated subscribers of D26904: [astimporter] Support importing CXXDependentScopeMemberExpr and FunctionTemplateDecl.
Nov 21 2016, 12:33 PM
khazem retitled D26904: [astimporter] Support importing CXXDependentScopeMemberExpr and FunctionTemplateDecl from to [astimporter] Support importing CXXDependentScopeMemberExpr and FunctionTemplateDecl.
Nov 21 2016, 1:22 AM

Nov 16 2016

khazem added a comment to D26753: ASTImporter: improve support for C++ templates.

Thanks very much for this patch! It certainly fixes the infinite recursion issue on our codebase. It LGTM, but I'd like to add a test case before landing it.

Nov 16 2016, 10:49 AM
khazem updated subscribers of D26753: ASTImporter: improve support for C++ templates.
Nov 16 2016, 10:25 AM

Nov 9 2016

khazem added a comment to D26340: [analyzer] Add SpinLockChecker for the Magenta kernel.

Devin, based on Artem's review of the other checker that I have posted [1] I am wondering about merging both this SpinLockChecker and the MutexChecker into PthreadLockChecker. Do you think it is still worth landing this SpinLockChecker, or do you suppose that abandoning this patch and working on merging all the checkers would be a good idea? I've noted how the checkers might be merged in my reply to Artem: [2].

Nov 9 2016, 12:30 PM
khazem added a comment to D26342: [analyzer] Add MutexChecker for the Magenta kernel.

Thanks for the detailed review Artem!

Nov 9 2016, 12:27 PM

Nov 8 2016

khazem updated the diff for D26340: [analyzer] Add SpinLockChecker for the Magenta kernel.

If a double-lock or double-release is detected, path notes are now emitted on the _first_ lock or release event. Also updated the tests to check for these notes.

Nov 8 2016, 3:23 PM
khazem updated the diff for D26340: [analyzer] Add SpinLockChecker for the Magenta kernel.

The strings for Spin{Unl,L}ockFuncName and LockErrorCategory are now initialized when constructing a SpinLockChecker object rather than being static globals, in order to avoid adverse effects on startup time.

Nov 8 2016, 3:21 PM
khazem added a comment to D26340: [analyzer] Add SpinLockChecker for the Magenta kernel.

Good to meet you too, thanks for the useful comments and pointers to helpful examples! I'm going to update the diff twice: the first one to address your first two comments, and the second one to address your last two.

Nov 8 2016, 3:19 PM

Nov 7 2016

khazem added a comment to D26328: [ASTImporter] Added ability to import AtomicType nodes.

Thank you Sean! I've asked Petr Hosek to commit this change.

Nov 7 2016, 11:03 AM

Nov 6 2016

khazem updated the diff for D26340: [analyzer] Add SpinLockChecker for the Magenta kernel.

Minor edit, the list of libraries in CMakeLists.txt is now in alphabetical order.

Nov 6 2016, 8:11 PM
khazem updated subscribers of D26340: [analyzer] Add SpinLockChecker for the Magenta kernel.
Nov 6 2016, 8:07 PM
khazem updated subscribers of D26342: [analyzer] Add MutexChecker for the Magenta kernel.
Nov 6 2016, 8:06 PM
khazem updated subscribers of D26328: [ASTImporter] Added ability to import AtomicType nodes.
Nov 6 2016, 8:06 PM
khazem retitled D26342: [analyzer] Add MutexChecker for the Magenta kernel from to [analyzer] Add MutexChecker for the Magenta kernel.
Nov 6 2016, 8:02 PM
khazem retitled D26340: [analyzer] Add SpinLockChecker for the Magenta kernel from to [analyzer] Add SpinLockChecker for the Magenta kernel.
Nov 6 2016, 6:32 PM

Nov 5 2016

khazem retitled D26328: [ASTImporter] Added ability to import AtomicType nodes from to [ASTImporter] Added ability to import AtomicType nodes.
Nov 5 2016, 8:34 PM

Oct 28 2016

khazem updated the diff for D26105: Allow CaseStmt to be initialized with a SubStmt.

(added more context)

Oct 28 2016, 4:24 PM
khazem retitled D26105: Allow CaseStmt to be initialized with a SubStmt from to Allow CaseStmt to be initialized with a SubStmt.
Oct 28 2016, 4:16 PM

Oct 3 2016

khazem abandoned D24878: ASTImporter: expressions, pt.2.
Oct 3 2016, 8:14 AM

Sep 25 2016

khazem updated subscribers of D24807: [Serialization] ArrayTypeTraitExpr: serialize sub-expression to avoid keeping it undefined.
Sep 25 2016, 6:25 PM

Sep 23 2016

khazem added a comment to D24878: ASTImporter: expressions, pt.2.

This diff is a continuation of https://reviews.llvm.org/D14326, which was accepted for inclusion but has not been merged in for the past couple of months.

Sep 23 2016, 1:08 PM
khazem reclaimed D24878: ASTImporter: expressions, pt.2.
Sep 23 2016, 1:05 PM
khazem abandoned D24878: ASTImporter: expressions, pt.2.
Sep 23 2016, 12:46 PM
khazem retitled D24878: ASTImporter: expressions, pt.2 from to ASTImporter: expressions, pt.2.
Sep 23 2016, 12:45 PM
khazem abandoned D24876: Minor update to rebase cleanly on master.
Sep 23 2016, 12:41 PM
khazem retitled D24876: Minor update to rebase cleanly on master from to Minor update to rebase cleanly on master.
Sep 23 2016, 12:36 PM
khazem added a comment to D14326: ASTImporter: expressions, pt.2.

I'm updating this patch so that it rebases cleanly onto master, as this patch hasn't been updated for a couple of months...

Sep 23 2016, 12:33 PM

Sep 18 2016

khazem updated subscribers of D14326: ASTImporter: expressions, pt.2.
Sep 18 2016, 5:06 PM