Page MenuHomePhabricator

khasanovaa (Aliia Khasanova)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 28 2022, 6:13 AM (10 w, 1 d)

Recent Activity

Mon, Nov 21

khasanovaa committed rG399638f98cdc: Merge kDynamicSize and kDynamicSentinel into one constant. (authored by khasanovaa).
Merge kDynamicSize and kDynamicSentinel into one constant.
Mon, Nov 21, 5:02 AM · Restricted Project, Restricted Project, Restricted Project
khasanovaa closed D138282: Merge kDynamicSize and kDynamicSentinel into one constant..
Mon, Nov 21, 5:02 AM · Restricted Project, Restricted Project, Restricted Project
khasanovaa updated the diff for D138282: Merge kDynamicSize and kDynamicSentinel into one constant..

Resolving merge conflicts

Mon, Nov 21, 2:59 AM · Restricted Project, Restricted Project, Restricted Project

Fri, Nov 18

khasanovaa updated the diff for D138282: Merge kDynamicSize and kDynamicSentinel into one constant..

Resolving comments

Fri, Nov 18, 10:02 AM · Restricted Project, Restricted Project, Restricted Project
khasanovaa requested review of D138282: Merge kDynamicSize and kDynamicSentinel into one constant..
Fri, Nov 18, 3:02 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Nov 17

khasanovaa committed rG9729b6930b41: [mlir] Make kDynamicSize equal to kDynamicOffsetAndStride. (authored by khasanovaa).
[mlir] Make kDynamicSize equal to kDynamicOffsetAndStride.
Thu, Nov 17, 1:37 AM · Restricted Project, Restricted Project
khasanovaa closed D134807: Make kDynamicSize equal to kDynamicStrideOrOffset.
Thu, Nov 17, 1:37 AM · Restricted Project, Restricted Project, Restricted Project
khasanovaa updated the diff for D134807: Make kDynamicSize equal to kDynamicStrideOrOffset.

rebase

Thu, Nov 17, 1:19 AM · Restricted Project, Restricted Project, Restricted Project

Oct 21 2022

khasanovaa added a comment to D134807: Make kDynamicSize equal to kDynamicStrideOrOffset.

We've submitted all changes that do not break tests (mostly -1 -> kDynamicSize).

Oct 21 2022, 1:01 AM · Restricted Project, Restricted Project, Restricted Project
khasanovaa updated the diff for D134807: Make kDynamicSize equal to kDynamicStrideOrOffset.

Rebase

Oct 21 2022, 12:59 AM · Restricted Project, Restricted Project, Restricted Project

Oct 20 2022

khasanovaa committed rGfb4cedcc1e0f: [mlir][nfc] Clean-up usage of kDynamicSize. (authored by khasanovaa).
[mlir][nfc] Clean-up usage of kDynamicSize.
Oct 20 2022, 6:55 AM · Restricted Project, Restricted Project, Restricted Project
khasanovaa closed D136327: [mlir][nfc] Clean-up usage of kDynamicSize..
Oct 20 2022, 6:55 AM · Restricted Project, Restricted Project, Restricted Project
khasanovaa updated the diff for D136327: [mlir][nfc] Clean-up usage of kDynamicSize..

Update format.

Oct 20 2022, 5:40 AM · Restricted Project, Restricted Project, Restricted Project
khasanovaa updated the diff for D136327: [mlir][nfc] Clean-up usage of kDynamicSize..

Addressed the comments.

Oct 20 2022, 4:53 AM · Restricted Project, Restricted Project, Restricted Project
khasanovaa requested review of D136327: [mlir][nfc] Clean-up usage of kDynamicSize..
Oct 20 2022, 2:54 AM · Restricted Project, Restricted Project, Restricted Project

Oct 14 2022

khasanovaa added a comment to D134807: Make kDynamicSize equal to kDynamicStrideOrOffset.

@clementval @kiranchandramohan @jeanPerier, it looks like my patch did not actually solve all problems. Could you please take a look? It is quite an important PR.

With the following changes, I see that all tests pass. But not sure whether the replacements have happened at all places.

diff --git a/flang/include/flang/Optimizer/Dialect/FIRTypes.td b/flang/include/flang/Optimizer/Dialect/FIRTypes.td
index f179071f1943..0d06e1d118ea 100644
--- a/flang/include/flang/Optimizer/Dialect/FIRTypes.td
+++ b/flang/include/flang/Optimizer/Dialect/FIRTypes.td
@@ -128,7 +128,7 @@ def fir_CharacterType : FIR_Type<"Character", "char"> {
     static constexpr LenType singleton() { return 1; }
 
     /// Character has a LEN value which is not a compile-time known constant.
-    static constexpr LenType unknownLen() { return -1; }
+    static constexpr LenType unknownLen() { return mlir::ShapedType::kDynamicSize; }
 
     /// Character LEN is a runtime value.
     bool hasDynamicLen() { return getLen() == unknownLen(); }
diff --git a/flang/lib/Optimizer/Transforms/AffinePromotion.cpp b/flang/lib/Optimizer/Transforms/AffinePromotion.cpp
index ae152cf3a524..92f38d73790e 100644
--- a/flang/lib/Optimizer/Transforms/AffinePromotion.cpp
+++ b/flang/lib/Optimizer/Transforms/AffinePromotion.cpp
@@ -410,7 +410,7 @@ createAffineOps(mlir::Value arrayRef, mlir::PatternRewriter &rewriter) {
   auto affineApply = rewriter.create<mlir::AffineApplyOp>(acoOp.getLoc(),
                                                           affineMap, indexArgs);
   auto arrayElementType = coordinateArrayElement(acoOp);
-  auto newType = mlir::MemRefType::get({-1}, arrayElementType);
+  auto newType = mlir::MemRefType::get({mlir::ShapedType::kDynamicSize}, arrayElementType);
   auto arrayConvert = rewriter.create<fir::ConvertOp>(acoOp.getLoc(), newType,
                                                       acoOp.getMemref());
   return std::make_pair(affineApply, arrayConvert);
Oct 14 2022, 3:32 AM · Restricted Project, Restricted Project, Restricted Project
khasanovaa updated the diff for D134807: Make kDynamicSize equal to kDynamicStrideOrOffset.

[flang] Use ShapedType::kDynamicSize instead of -1

Oct 14 2022, 2:50 AM · Restricted Project, Restricted Project, Restricted Project

Oct 13 2022

khasanovaa updated the diff for D134807: Make kDynamicSize equal to kDynamicStrideOrOffset.

Rebasing

Oct 13 2022, 12:11 AM · Restricted Project, Restricted Project, Restricted Project

Oct 11 2022

khasanovaa updated the diff for D134807: Make kDynamicSize equal to kDynamicStrideOrOffset.

Replace magic constants with KDynamicSize in python

Oct 11 2022, 5:52 AM · Restricted Project, Restricted Project, Restricted Project

Sep 28 2022

khasanovaa requested review of D134807: Make kDynamicSize equal to kDynamicStrideOrOffset.
Sep 28 2022, 6:23 AM · Restricted Project, Restricted Project, Restricted Project