User Details
User Details
- User Since
- Jan 5 2021, 10:36 AM (7 w, 6 d)
Jan 14 2021
Jan 14 2021
kevinpeizner added a comment to D94557: [ARM] Fixed incorrect lowering when using GNUEABI (libgcc) and 16bit floats.
Would it be better to default to EABI symbols and conditionally use GNU symbols based on the target? I can certain switch to that approach, but I didn't go that way initially since this code block implies GNU symbols should be the default:
// In EABI, these functions have an __aeabi_ prefix, but in GNUEABI they have // a __gnu_ prefix (which is the default). if (Subtarget->isTargetAEABI()) { static const struct { const RTLIB::Libcall Op; const char * const Name; const CallingConv::ID CC; } LibraryCalls[] = { { RTLIB::FPROUND_F32_F16, "__aeabi_f2h", CallingConv::ARM_AAPCS }, { RTLIB::FPROUND_F64_F16, "__aeabi_d2h", CallingConv::ARM_AAPCS }, { RTLIB::FPEXT_F16_F32, "__aeabi_h2f", CallingConv::ARM_AAPCS }, };
Jan 14 2021, 4:59 PM · Restricted Project
kevinpeizner added a comment to D94557: [ARM] Fixed incorrect lowering when using GNUEABI (libgcc) and 16bit floats.
Jan 14 2021, 4:45 PM · Restricted Project
Jan 13 2021
Jan 13 2021
kevinpeizner added inline comments to D94557: [ARM] Fixed incorrect lowering when using GNUEABI (libgcc) and 16bit floats.
Jan 13 2021, 11:36 AM · Restricted Project
kevinpeizner added inline comments to D94557: [ARM] Fixed incorrect lowering when using GNUEABI (libgcc) and 16bit floats.
Jan 13 2021, 9:15 AM · Restricted Project
kevinpeizner updated the diff for D94557: [ARM] Fixed incorrect lowering when using GNUEABI (libgcc) and 16bit floats.
Updated patch with diff -U9999
Jan 13 2021, 8:54 AM · Restricted Project
Jan 12 2021
Jan 12 2021
kevinpeizner requested review of D94557: [ARM] Fixed incorrect lowering when using GNUEABI (libgcc) and 16bit floats.
Jan 12 2021, 2:44 PM · Restricted Project