Page MenuHomePhabricator

kernigh (George Koehler)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 5 2019, 12:19 PM (87 w, 14 h)

Recent Activity

Sat, Nov 14

kernigh updated the diff for D90329: [PowerPC] Fix va_arg in C++, Objective-C on 32-bit ELF targets.

I have updated the diff to use bool isInt = !Ty->isFloatingType(); and bool isIndirect = isAggregateTypeForABI(Ty);. This removes both calls to Ty->isAggregateType(). This fixes some C++ types, because aren't aggregates in the C++ language, but do become aggregates in the ABI. The new test ppc32-varargs-method.cpp checks a pointer to a member function, and passes only with both the isInt and isIndirect changes.

Sat, Nov 14, 6:08 PM · Restricted Project

Thu, Nov 5

kernigh added inline comments to D90329: [PowerPC] Fix va_arg in C++, Objective-C on 32-bit ELF targets.
Thu, Nov 5, 12:09 PM · Restricted Project

Nov 4 2020

kernigh added inline comments to D90329: [PowerPC] Fix va_arg in C++, Objective-C on 32-bit ELF targets.
Nov 4 2020, 6:21 PM · Restricted Project

Oct 28 2020

kernigh added a comment to D90329: [PowerPC] Fix va_arg in C++, Objective-C on 32-bit ELF targets.

I'm using this TargetInfo.cpp diff in clang 10.0.1 on OpenBSD/macppc to build GNUstep. For me, it fixes the build of gnustep-gui. I rebuilt libobjc2, gnustep-make, and gnustep-base before building gnustep-gui.

Oct 28 2020, 5:12 PM · Restricted Project
kernigh requested review of D90329: [PowerPC] Fix va_arg in C++, Objective-C on 32-bit ELF targets.
Oct 28 2020, 12:00 PM · Restricted Project

May 28 2020

kernigh added a comment to D80469: Add OpenBSD support in lib/tsan/go/buildgo.sh.

@qbit, if you use git clang-format, it should format only the code around your diff (https://llvm.org/docs/Contributing.html#how-to-submit-a-patch). On OpenBSD, pkg_add llvm installs clang-format.

May 28 2020, 5:05 PM · Restricted Project

Jan 23 2020

kernigh created D73290: [PowerPC] Add clang -msvr4-struct-return for 32-bit ELF.
Jan 23 2020, 1:24 PM · Restricted Project

Apr 16 2019

kernigh added a comment to D60335: Use -fomit-frame-pointer when optimizing PowerPC code.

I'm stuck. I didn't put a test in this patch because I can't run the tests yet. So far, I can build a clang executable but can't build the rest of the project. I won't run the tests without a complete build, and I won't edit the tests without running them.

Apr 16 2019, 2:55 PM · Restricted Project

Apr 5 2019

kernigh created D60335: Use -fomit-frame-pointer when optimizing PowerPC code.
Apr 5 2019, 12:50 PM · Restricted Project