Page MenuHomePhabricator

kbaladurin (Konstantin Baladurin)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 28 2017, 3:26 AM (116 w, 1 d)

Recent Activity

Nov 28 2018

kbaladurin added a comment to D49379: lldbsuite: ignore decoding errors in _encoded_write.

What is the status? Thank you!

It looks like we signed off on your change, so you're free to commit it. :)

Nov 28 2018, 11:47 PM · Restricted Project
kbaladurin added a comment to D49379: lldbsuite: ignore decoding errors in _encoded_write.

What is the status? Thank you!

Nov 28 2018, 6:57 AM · Restricted Project

Jul 17 2018

kbaladurin added a comment to D49379: lldbsuite: ignore decoding errors in _encoded_write.

Thank you for comments, I've updated patch. I agree that it is not complete solution, maybe better to make all tests unicode safe.

I've been debating this with myself yesterday. In the case you encountered, the issue is that the c string we read from the inferior is not valid utf8. This is kind of a problem because it means that it can corrupt subsequent lldb output (most likely the closing " character).

One possibility here would be to do the replacement character substitution directly when printing out strings read from inferior memory. However, I couldn't decide for myself whether I want my debugger to mess with these strings or not...

Jul 17 2018, 8:12 AM · Restricted Project
kbaladurin updated the diff for D49379: lldbsuite: ignore decoding errors in _encoded_write.

Thank you for comments, I've updated patch. I agree that it is not complete solution, maybe better to make all tests unicode safe.

Jul 17 2018, 6:03 AM · Restricted Project

Jul 16 2018

kbaladurin created D49379: lldbsuite: ignore decoding errors in _encoded_write.
Jul 16 2018, 8:05 AM · Restricted Project

May 2 2018

kbaladurin added a comment to D44998: ObjectFileELF: Add support for arbitrarily named code sections.

Thank you very much!

May 2 2018, 11:03 PM · Restricted Project

Apr 27 2018

kbaladurin added a comment to D44998: ObjectFileELF: Add support for arbitrarily named code sections.

Yes, as I haven't commit access. Thank you!

Apr 27 2018, 4:27 AM · Restricted Project
Herald added a reviewer for D44998: ObjectFileELF: Add support for arbitrarily named code sections: javed.absar.

Is it ready to commit?

Apr 27 2018, 3:53 AM · Restricted Project

Apr 3 2018

Herald added a reviewer for D44998: ObjectFileELF: Add support for arbitrarily named code sections: espindola.
Apr 3 2018, 1:28 AM · Restricted Project

Apr 2 2018

kbaladurin added inline comments to D44998: ObjectFileELF: Add support for arbitrarily named code sections.
Apr 2 2018, 9:03 AM · Restricted Project
kbaladurin updated the diff for D44998: ObjectFileELF: Add support for arbitrarily named code sections.

@davide thank you! I've updated diff. Yes, I need somebody to commit this, as I haven't commit access.

Apr 2 2018, 8:24 AM · Restricted Project
kbaladurin updated the diff for D44998: ObjectFileELF: Add support for arbitrarily named code sections.

Thank you! I've extended lldb-test utility to dump section type:

Showing 6 sections
  Index: 0
  Type: regular
  Name: 
  VM size: 0
  File size: 0
Apr 2 2018, 1:56 AM · Restricted Project

Mar 30 2018

kbaladurin added a comment to D44998: ObjectFileELF: Add support for arbitrarily named code sections.

Thank you! What is more preferable add python or lit test?

Mar 30 2018, 6:53 AM · Restricted Project

Mar 28 2018

kbaladurin created D44998: ObjectFileELF: Add support for arbitrarily named code sections.
Mar 28 2018, 1:25 PM · Restricted Project