Page MenuHomePhabricator

kawashima-fj (KAWASHIMA Takahiro)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 16 2019, 8:11 AM (55 w, 4 d)

Fujitsu

Recent Activity

May 21 2020

kawashima-fj committed rGac2c5af67f03: [OPENMP] Fix mixture of omp and clang pragmas (authored by hishiguro).
[OPENMP] Fix mixture of omp and clang pragmas
May 21 2020, 9:06 PM
kawashima-fj closed D79921: [OPENMP] Fix mixture of omp and clang pragmas.
May 21 2020, 9:06 PM · Restricted Project

May 12 2020

kawashima-fj committed rG272bc25bc140: [LoopReroll] Fix rerolling loop with use outside the loop (authored by kawashima-fj).
[LoopReroll] Fix rerolling loop with use outside the loop
May 12 2020, 9:33 PM
kawashima-fj committed rG7d4167430c41: [gcov] Fix simultaneous .gcda creation/lock (authored by kawashima-fj).
[gcov] Fix simultaneous .gcda creation/lock
May 12 2020, 9:33 PM
kawashima-fj closed D79549: [LoopReroll] Fix rerolling loop with use outside the loop.
May 12 2020, 9:33 PM · Restricted Project
kawashima-fj closed D79556: [gcov] Fix simultaneous .gcda creation/lock.
May 12 2020, 9:33 PM · Restricted Project

May 8 2020

kawashima-fj added a comment to D79549: [LoopReroll] Fix rerolling loop with use outside the loop.

Could you take another look at the testcase for 34760 in particular? That seems similar enough that it should get fixed at the same time.

May 8 2020, 11:04 PM · Restricted Project
kawashima-fj added a comment to D79549: [LoopReroll] Fix rerolling loop with use outside the loop.

I think there are four loop-reroll issues currently open in Bugzilla:

https://bugs.llvm.org/show_bug.cgi?id=34029
https://bugs.llvm.org/show_bug.cgi?id=42267
https://bugs.llvm.org/show_bug.cgi?id=34760
https://bugs.llvm.org/show_bug.cgi?id=41696

Could you check which ones this patch fixes?

May 8 2020, 1:01 AM · Restricted Project
kawashima-fj updated the diff for D79549: [LoopReroll] Fix rerolling loop with use outside the loop.

Comment is added.

May 8 2020, 1:01 AM · Restricted Project

May 7 2020

kawashima-fj added a comment to D54599: [Profile] Avoid race condition when dumping GCDA files..

I wonder if https://reviews.llvm.org/D76206 didn't fix this too

May 7 2020, 1:07 AM
kawashima-fj created D79556: [gcov] Fix simultaneous .gcda creation/lock.
May 7 2020, 1:07 AM · Restricted Project

May 6 2020

kawashima-fj created D79549: [LoopReroll] Fix rerolling loop with use outside the loop.
May 6 2020, 10:08 PM · Restricted Project

Apr 28 2020

kawashima-fj committed rG89f6a2376e6b: [gcov][test] Work around PR45673 - NFC (authored by kawashima-fj).
[gcov][test] Work around PR45673 - NFC
Apr 28 2020, 4:47 AM

Mar 31 2020

kawashima-fj committed rG9180c14fe4d7: Fix simultaneous .gcda creation (authored by kawashima-fj).
Fix simultaneous .gcda creation
Mar 31 2020, 6:46 PM
kawashima-fj closed D76206: [gcov] Fix simultaneous .gcda creation.
Mar 31 2020, 6:46 PM · Restricted Project

Mar 23 2020

kawashima-fj updated the diff for D76206: [gcov] Fix simultaneous .gcda creation.

Thanks. I updated the patch to inverted the conditions (if (fd != -1) {).

Mar 23 2020, 11:57 PM · Restricted Project
kawashima-fj added a comment to D76206: [gcov] Fix simultaneous .gcda creation.

Ping.

Mar 23 2020, 4:21 AM · Restricted Project

Mar 17 2020

kawashima-fj added a comment to D75594: [AArch64] Add support for Fujitsu A64FX.

Yes, https://github.com/fujitsu/A64FX contains the official microarchitecture information of A64FX. I wanted to include the URL in the Git commit message but the disclosure was not ready for it at the time.

Can you do it at the next commit opportunity as this reference manual should be broadly read by the Arm developer community?

Mar 17 2020, 7:27 PM · Restricted Project, Restricted Project
kawashima-fj added a comment to D75594: [AArch64] Add support for Fujitsu A64FX.

Yes, https://github.com/fujitsu/A64FX contains the official microarchitecture information of A64FX. I wanted to include the URL in the Git commit message but the disclosure was not ready for it at the time.

Mar 17 2020, 5:18 PM · Restricted Project, Restricted Project

Mar 16 2020

kawashima-fj added a comment to D76206: [gcov] Fix simultaneous .gcda creation.

The failure of the pre-merge check is the following clang-tidy warning. I modified only indentation of the line, and compiler-rt does not follow variable naming rules in the LLVM coding standard. So it does not have a problem.

Mar 16 2020, 3:53 AM · Restricted Project

Mar 15 2020

kawashima-fj created D76206: [gcov] Fix simultaneous .gcda creation.
Mar 15 2020, 6:48 PM · Restricted Project

Mar 9 2020

kawashima-fj committed rGc8cd1a994d28: [AArch64] Add support for Fujitsu A64FX (authored by kawashima-fj).
[AArch64] Add support for Fujitsu A64FX
Mar 9 2020, 3:44 AM
kawashima-fj closed D75594: [AArch64] Add support for Fujitsu A64FX.
Mar 9 2020, 3:44 AM · Restricted Project, Restricted Project

Mar 5 2020

kawashima-fj updated the diff for D75594: [AArch64] Add support for Fujitsu A64FX.

@huntergr @dmgreen Thanks for your reviews.

Mar 5 2020, 5:29 AM · Restricted Project, Restricted Project

Mar 4 2020

kawashima-fj updated the diff for D75594: [AArch64] Add support for Fujitsu A64FX.

An unnecessary comment line is removed and indentation is aligned.

Mar 4 2020, 12:39 AM · Restricted Project, Restricted Project

Mar 3 2020

kawashima-fj created D75594: [AArch64] Add support for Fujitsu A64FX.
Mar 3 2020, 11:33 PM · Restricted Project, Restricted Project

Jan 10 2020

kawashima-fj added a comment to D71688: [AArch64] Add -mtls-size option for ELF targets.

Thanks for review.

Jan 10 2020, 1:47 AM · Restricted Project, Restricted Project

Jan 7 2020

kawashima-fj updated the diff for D71688: [AArch64] Add -mtls-size option for ELF targets.

Thanks for a suggestion. I looked around the code and found that the suggested AArch64TargetMachine constructor is the best place because other option values are set there. The updated patch moved the maximum value setting code to that constructor.

Jan 7 2020, 8:01 PM · Restricted Project, Restricted Project
kawashima-fj added a comment to D71688: [AArch64] Add -mtls-size option for ELF targets.

Apologies for the delay in responding, just come back from vacation. I've checked the implementation against GCC and it looks like it will give the same behaviour. I've got one minor suggestion surrounding the clamping of TLSSize to its maximum value. It looks like it would only need to be done once, is there a convenient place, such as AArch64TargetMachine where it can be done once?

Jan 7 2020, 5:50 AM · Restricted Project, Restricted Project

Dec 19 2019

kawashima-fj added a comment to D71688: [AArch64] Add -mtls-size option for ELF targets.

This is the same as gcc? Sounds good.

Dec 19 2019, 1:05 AM · Restricted Project, Restricted Project

Dec 18 2019

kawashima-fj updated the diff for D71688: [AArch64] Add -mtls-size option for ELF targets.

Directory prefixes were deleted by git show --no-prefix in the previous diff. It is corrected now.

Dec 18 2019, 10:44 PM · Restricted Project, Restricted Project
kawashima-fj created D71688: [AArch64] Add -mtls-size option for ELF targets.
Dec 18 2019, 10:24 PM · Restricted Project, Restricted Project