Page MenuHomePhabricator

kawashima-fj (KAWASHIMA Takahiro)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 16 2019, 8:11 AM (105 w, 1 d)

Fujitsu

Recent Activity

Apr 23 2021

kawashima-fj closed D88395: [LoopReroll] Fix rerolling loop with extra instructions.

Pushed to the main branch. I'm sorry, I forgot to add Differential Revision: line. The commit is d9a9c992d190dd6645ea911b66cf0cadba0dadc3 .

Apr 23 2021, 12:39 AM · Restricted Project

Apr 22 2021

kawashima-fj committed rGd9a9c992d190: [LoopReroll] Fix rerolling loop with extra instructions (authored by kawashima-fj).
[LoopReroll] Fix rerolling loop with extra instructions
Apr 22 2021, 11:42 PM
kawashima-fj updated the diff for D88395: [LoopReroll] Fix rerolling loop with extra instructions.

@Meinersbur Thanks for your review. I've updated the patch. Correction of LLVM_DEBUG message and adding test patterns.

Apr 22 2021, 10:58 PM · Restricted Project

Apr 7 2021

kawashima-fj updated the diff for D88395: [LoopReroll] Fix rerolling loop with extra instructions.

@Meinersbur I'm sorry for being late. I updated the patch. Please review again.

Apr 7 2021, 9:29 PM · Restricted Project

Mar 31 2021

kawashima-fj committed rG5fac7c60467c: [GVN] Propagate llvm.access.group metadata of loads (authored by kawashima-fj).
[GVN] Propagate llvm.access.group metadata of loads
Mar 31 2021, 6:02 PM
kawashima-fj committed rG565b28f57b55: [GVN][NFC] Pre-commit test for D93503 (authored by kawashima-fj).
[GVN][NFC] Pre-commit test for D93503
Mar 31 2021, 6:02 PM
kawashima-fj closed D93503: [GVN] Propagate llvm.access.group metadata of loads.
Mar 31 2021, 6:01 PM · Restricted Project

Mar 30 2021

kawashima-fj added a comment to D93503: [GVN] Propagate llvm.access.group metadata of loads.

@fhahn Ping. I addressed your comment.

Mar 30 2021, 7:43 AM · Restricted Project

Feb 18 2021

kawashima-fj added a comment to D93503: [GVN] Propagate llvm.access.group metadata of loads.

@fhahn Ping. Could you confirm?

Feb 18 2021, 6:54 AM · Restricted Project

Feb 12 2021

kawashima-fj added a comment to D88395: [LoopReroll] Fix rerolling loop with extra instructions.

@Meinersbur Thanks for your review. I'll update the patch.

Feb 12 2021, 5:01 AM · Restricted Project

Feb 1 2021

kawashima-fj added a comment to D93503: [GVN] Propagate llvm.access.group metadata of loads.

@fhahn Ping. Could you confirm?

Feb 1 2021, 4:19 AM · Restricted Project

Jan 22 2021

kawashima-fj added a comment to D93503: [GVN] Propagate llvm.access.group metadata of loads.

Ping.
@fhahn @asbirlea Is this OK?

Jan 22 2021, 7:29 PM · Restricted Project

Jan 15 2021

kawashima-fj closed D75594: [AArch64] Add support for Fujitsu A64FX.

Yes, https://github.com/fujitsu/A64FX contains the official microarchitecture information of A64FX. I wanted to include the URL in the Git commit message but the disclosure was not ready for it at the time.

Can you do it at the next commit opportunity as this reference manual should be broadly read by the Arm developer community?

Jan 15 2021, 4:32 AM · Restricted Project, Restricted Project
kawashima-fj committed rGb54337070b19: [AArch64] Add Fujitsu A64FX scheduling model (authored by kawashima-fj).
[AArch64] Add Fujitsu A64FX scheduling model
Jan 15 2021, 12:21 AM
kawashima-fj closed D93791: [AArch64] Add Fujitsu A64FX scheduling model.
Jan 15 2021, 12:20 AM · Restricted Project
kawashima-fj added a comment to D93503: [GVN] Propagate llvm.access.group metadata of loads.

I'm sorry for the late response. I (and my colleague) updated the test.

Jan 15 2021, 12:00 AM · Restricted Project

Jan 14 2021

kawashima-fj updated the diff for D93503: [GVN] Propagate llvm.access.group metadata of loads.

Update test.

Jan 14 2021, 11:55 PM · Restricted Project

Jan 6 2021

kawashima-fj added a comment to D93503: [GVN] Propagate llvm.access.group metadata of loads.

This seems reasonable to me, as we should only reduce the number of loads executed during PRE. If they are in the same loop, the metadata should stay valid, as we do not access any additional locations.

Would it be possible to add a simple test case where we move a load from a sub-loop into a parent loop?

Jan 6 2021, 5:50 PM · Restricted Project
kawashima-fj updated the diff for D93503: [GVN] Propagate llvm.access.group metadata of loads.

Simplify the test code.

Jan 6 2021, 5:38 PM · Restricted Project
kawashima-fj added a comment to D93791: [AArch64] Add Fujitsu A64FX scheduling model.

Thanks for reviews! I'll commit this next week unless other new comment is posted.

Jan 6 2021, 4:35 PM · Restricted Project

Jan 5 2021

kawashima-fj added a comment to D93503: [GVN] Propagate llvm.access.group metadata of loads.

Ping.
Can anyone review? Is there an appropriate reviewer?

Jan 5 2021, 4:11 AM · Restricted Project

Jan 4 2021

kawashima-fj added a comment to D93791: [AArch64] Add Fujitsu A64FX scheduling model.

Is there a way to specify the maximum or even the set of supported SIMD-widths for SVE cores?

Jan 4 2021, 8:01 PM · Restricted Project
kawashima-fj added inline comments to D93791: [AArch64] Add Fujitsu A64FX scheduling model.
Jan 4 2021, 7:57 PM · Restricted Project
kawashima-fj updated the diff for D93791: [AArch64] Add Fujitsu A64FX scheduling model.

Remove WriteID512 and update comment.

Jan 4 2021, 7:51 PM · Restricted Project

Dec 25 2020

kawashima-fj added a comment to D93503: [GVN] Propagate llvm.access.group metadata of loads.

Ping.
I know many people are on holiday this week. If you have time, please review this patch. I'm on holiday from tomorrow.

Dec 25 2020, 12:36 AM · Restricted Project

Dec 23 2020

kawashima-fj updated the diff for D93791: [AArch64] Add Fujitsu A64FX scheduling model.

@yutsumi Thanks. Good catch. I've addressed your comment.

Dec 23 2020, 8:36 PM · Restricted Project
kawashima-fj requested review of D93791: [AArch64] Add Fujitsu A64FX scheduling model.
Dec 23 2020, 6:25 PM · Restricted Project

Dec 17 2020

kawashima-fj requested review of D93503: [GVN] Propagate llvm.access.group metadata of loads.
Dec 17 2020, 5:29 PM · Restricted Project

Dec 14 2020

kawashima-fj added a comment to D88395: [LoopReroll] Fix rerolling loop with extra instructions.

Ping.

Dec 14 2020, 7:09 PM · Restricted Project

Nov 16 2020

kawashima-fj added a comment to D88395: [LoopReroll] Fix rerolling loop with extra instructions.

Ping.
Can anyone review this fix?

Nov 16 2020, 5:41 PM · Restricted Project

Nov 3 2020

kawashima-fj updated subscribers of D88395: [LoopReroll] Fix rerolling loop with extra instructions.

Ping.

Nov 3 2020, 5:44 PM · Restricted Project

Oct 20 2020

kawashima-fj added a comment to D88395: [LoopReroll] Fix rerolling loop with extra instructions.

Ping.

Oct 20 2020, 3:38 AM · Restricted Project

Oct 5 2020

kawashima-fj added a comment to D88395: [LoopReroll] Fix rerolling loop with extra instructions.

Ping.
I know many of LLVM developers are busy with the developer's meeting now. When someone has time, please review.

Oct 5 2020, 4:49 AM · Restricted Project

Sep 28 2020

kawashima-fj added a comment to D88395: [LoopReroll] Fix rerolling loop with extra instructions.

clang-format reported a format error DenseSet<Instruction*> -> DenseSet<Instruction *> (space before *). However, other three places in the same function (and many places in other functions) have the same format. Should I change all places? only my change?, or keep all them unchanged?

Sep 28 2020, 6:02 PM · Restricted Project
kawashima-fj requested review of D88395: [LoopReroll] Fix rerolling loop with extra instructions.
Sep 28 2020, 12:25 AM · Restricted Project

May 21 2020

kawashima-fj committed rGac2c5af67f03: [OPENMP] Fix mixture of omp and clang pragmas (authored by hishiguro).
[OPENMP] Fix mixture of omp and clang pragmas
May 21 2020, 9:06 PM
kawashima-fj closed D79921: [OPENMP] Fix mixture of omp and clang pragmas.
May 21 2020, 9:06 PM · Restricted Project

May 12 2020

kawashima-fj committed rG272bc25bc140: [LoopReroll] Fix rerolling loop with use outside the loop (authored by kawashima-fj).
[LoopReroll] Fix rerolling loop with use outside the loop
May 12 2020, 9:33 PM
kawashima-fj committed rG7d4167430c41: [gcov] Fix simultaneous .gcda creation/lock (authored by kawashima-fj).
[gcov] Fix simultaneous .gcda creation/lock
May 12 2020, 9:33 PM
kawashima-fj closed D79549: [LoopReroll] Fix rerolling loop with use outside the loop.
May 12 2020, 9:33 PM · Restricted Project
kawashima-fj closed D79556: [gcov] Fix simultaneous .gcda creation/lock.
May 12 2020, 9:33 PM · Restricted Project

May 8 2020

kawashima-fj added a comment to D79549: [LoopReroll] Fix rerolling loop with use outside the loop.

Could you take another look at the testcase for 34760 in particular? That seems similar enough that it should get fixed at the same time.

May 8 2020, 11:04 PM · Restricted Project
kawashima-fj added a comment to D79549: [LoopReroll] Fix rerolling loop with use outside the loop.

I think there are four loop-reroll issues currently open in Bugzilla:

https://bugs.llvm.org/show_bug.cgi?id=34029
https://bugs.llvm.org/show_bug.cgi?id=42267
https://bugs.llvm.org/show_bug.cgi?id=34760
https://bugs.llvm.org/show_bug.cgi?id=41696

Could you check which ones this patch fixes?

May 8 2020, 1:01 AM · Restricted Project
kawashima-fj updated the diff for D79549: [LoopReroll] Fix rerolling loop with use outside the loop.

Comment is added.

May 8 2020, 1:01 AM · Restricted Project

May 7 2020

kawashima-fj added a comment to D54599: [Profile] Avoid race condition when dumping GCDA files..

I wonder if https://reviews.llvm.org/D76206 didn't fix this too

May 7 2020, 1:07 AM
kawashima-fj created D79556: [gcov] Fix simultaneous .gcda creation/lock.
May 7 2020, 1:07 AM · Restricted Project

May 6 2020

kawashima-fj created D79549: [LoopReroll] Fix rerolling loop with use outside the loop.
May 6 2020, 10:08 PM · Restricted Project

Apr 28 2020

kawashima-fj committed rG89f6a2376e6b: [gcov][test] Work around PR45673 - NFC (authored by kawashima-fj).
[gcov][test] Work around PR45673 - NFC
Apr 28 2020, 4:47 AM

Mar 31 2020

kawashima-fj committed rG9180c14fe4d7: Fix simultaneous .gcda creation (authored by kawashima-fj).
Fix simultaneous .gcda creation
Mar 31 2020, 6:46 PM
kawashima-fj closed D76206: [gcov] Fix simultaneous .gcda creation.
Mar 31 2020, 6:46 PM · Restricted Project

Mar 23 2020

kawashima-fj updated the diff for D76206: [gcov] Fix simultaneous .gcda creation.

Thanks. I updated the patch to inverted the conditions (if (fd != -1) {).

Mar 23 2020, 11:57 PM · Restricted Project
kawashima-fj added a comment to D76206: [gcov] Fix simultaneous .gcda creation.

Ping.

Mar 23 2020, 4:21 AM · Restricted Project

Mar 17 2020

kawashima-fj added a comment to D75594: [AArch64] Add support for Fujitsu A64FX.

Yes, https://github.com/fujitsu/A64FX contains the official microarchitecture information of A64FX. I wanted to include the URL in the Git commit message but the disclosure was not ready for it at the time.

Can you do it at the next commit opportunity as this reference manual should be broadly read by the Arm developer community?

Mar 17 2020, 7:27 PM · Restricted Project, Restricted Project
kawashima-fj added a comment to D75594: [AArch64] Add support for Fujitsu A64FX.

Yes, https://github.com/fujitsu/A64FX contains the official microarchitecture information of A64FX. I wanted to include the URL in the Git commit message but the disclosure was not ready for it at the time.

Mar 17 2020, 5:18 PM · Restricted Project, Restricted Project

Mar 16 2020

kawashima-fj added a comment to D76206: [gcov] Fix simultaneous .gcda creation.

The failure of the pre-merge check is the following clang-tidy warning. I modified only indentation of the line, and compiler-rt does not follow variable naming rules in the LLVM coding standard. So it does not have a problem.

Mar 16 2020, 3:53 AM · Restricted Project

Mar 15 2020

kawashima-fj created D76206: [gcov] Fix simultaneous .gcda creation.
Mar 15 2020, 6:48 PM · Restricted Project

Mar 9 2020

kawashima-fj committed rGc8cd1a994d28: [AArch64] Add support for Fujitsu A64FX (authored by kawashima-fj).
[AArch64] Add support for Fujitsu A64FX
Mar 9 2020, 3:44 AM
kawashima-fj closed D75594: [AArch64] Add support for Fujitsu A64FX.
Mar 9 2020, 3:44 AM · Restricted Project, Restricted Project

Mar 5 2020

kawashima-fj updated the diff for D75594: [AArch64] Add support for Fujitsu A64FX.

@huntergr @dmgreen Thanks for your reviews.

Mar 5 2020, 5:29 AM · Restricted Project, Restricted Project

Mar 4 2020

kawashima-fj updated the diff for D75594: [AArch64] Add support for Fujitsu A64FX.

An unnecessary comment line is removed and indentation is aligned.

Mar 4 2020, 12:39 AM · Restricted Project, Restricted Project

Mar 3 2020

kawashima-fj created D75594: [AArch64] Add support for Fujitsu A64FX.
Mar 3 2020, 11:33 PM · Restricted Project, Restricted Project

Jan 10 2020

kawashima-fj added a comment to D71688: [AArch64] Add -mtls-size option for ELF targets.

Thanks for review.

Jan 10 2020, 1:47 AM · Restricted Project, Restricted Project

Jan 7 2020

kawashima-fj updated the diff for D71688: [AArch64] Add -mtls-size option for ELF targets.

Thanks for a suggestion. I looked around the code and found that the suggested AArch64TargetMachine constructor is the best place because other option values are set there. The updated patch moved the maximum value setting code to that constructor.

Jan 7 2020, 8:01 PM · Restricted Project, Restricted Project
kawashima-fj added a comment to D71688: [AArch64] Add -mtls-size option for ELF targets.

Apologies for the delay in responding, just come back from vacation. I've checked the implementation against GCC and it looks like it will give the same behaviour. I've got one minor suggestion surrounding the clamping of TLSSize to its maximum value. It looks like it would only need to be done once, is there a convenient place, such as AArch64TargetMachine where it can be done once?

Jan 7 2020, 5:50 AM · Restricted Project, Restricted Project

Dec 19 2019

kawashima-fj added a comment to D71688: [AArch64] Add -mtls-size option for ELF targets.

This is the same as gcc? Sounds good.

Dec 19 2019, 1:05 AM · Restricted Project, Restricted Project

Dec 18 2019

kawashima-fj updated the diff for D71688: [AArch64] Add -mtls-size option for ELF targets.

Directory prefixes were deleted by git show --no-prefix in the previous diff. It is corrected now.

Dec 18 2019, 10:44 PM · Restricted Project, Restricted Project
kawashima-fj created D71688: [AArch64] Add -mtls-size option for ELF targets.
Dec 18 2019, 10:24 PM · Restricted Project, Restricted Project