Page MenuHomePhabricator

kateinoigakukun (Yuta Saito)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 22 2019, 5:15 PM (38 w, 6 d)

Recent Activity

Apr 16 2020

kateinoigakukun added a comment to D77384: [WebAssembly] Support single-floating-point immediate value.

@sunfish Could you take a look again?

Apr 16 2020, 12:02 AM · Restricted Project

Apr 10 2020

kateinoigakukun updated the diff for D77384: [WebAssembly] Support single-floating-point immediate value.
Apr 10 2020, 8:01 AM · Restricted Project
kateinoigakukun updated the diff for D77384: [WebAssembly] Support single-floating-point immediate value.
Apr 10 2020, 7:24 AM · Restricted Project

Apr 9 2020

kateinoigakukun updated the diff for D77384: [WebAssembly] Support single-floating-point immediate value.
Apr 9 2020, 7:36 PM · Restricted Project

Apr 4 2020

kateinoigakukun added a comment to D77384: [WebAssembly] Support single-floating-point immediate value.

I couldn't reproduce the failure of opt-bisect-legacy-pass-manager.ll on my x86_64 host. I can't figure out why the test suite failed.

Apr 4 2020, 7:42 PM · Restricted Project
kateinoigakukun updated the diff for D77384: [WebAssembly] Support single-floating-point immediate value.
Apr 4 2020, 6:38 PM · Restricted Project
kateinoigakukun updated the diff for D77384: [WebAssembly] Support single-floating-point immediate value.

Fix for failing test cases

Apr 4 2020, 9:32 AM · Restricted Project

Apr 3 2020

kateinoigakukun created D77384: [WebAssembly] Support single-floating-point immediate value.
Apr 3 2020, 5:52 AM · Restricted Project

Mar 19 2020

kateinoigakukun added a comment to D76049: [WebAssembly] Support swiftself and swifterror for WebAssembly target.

Thanks for reviewing! Can you merge this patch?

Mar 19 2020, 6:07 PM · Restricted Project
kateinoigakukun added a comment to D76049: [WebAssembly] Support swiftself and swifterror for WebAssembly target.

I think the calling convention should be documented since it is basically the core of the swift ABI (even if you don't want to consider it stable yet). So at minimum there should be more explanation in the commit message and there should probably be a doc about the Swift ABI in https://github.com/WebAssembly/tool-conventions/ like there is for C.

Mar 19 2020, 3:11 AM · Restricted Project
kateinoigakukun updated the summary of D76049: [WebAssembly] Support swiftself and swifterror for WebAssembly target.
Mar 19 2020, 2:39 AM · Restricted Project
kateinoigakukun updated the diff for D76049: [WebAssembly] Support swiftself and swifterror for WebAssembly target.

Add test cases for direct function call and add more explanation

Mar 19 2020, 2:39 AM · Restricted Project

Mar 17 2020

kateinoigakukun added inline comments to D76049: [WebAssembly] Support swiftself and swifterror for WebAssembly target.
Mar 17 2020, 7:27 PM · Restricted Project
kateinoigakukun updated the diff for D76049: [WebAssembly] Support swiftself and swifterror for WebAssembly target.
Mar 17 2020, 7:27 PM · Restricted Project
kateinoigakukun updated the diff for D76049: [WebAssembly] Support swiftself and swifterror for WebAssembly target.

Remove unnecessary logic around WebAssemblyExplicitLocals and added some test cases

Mar 17 2020, 6:56 PM · Restricted Project

Mar 16 2020

kateinoigakukun added a comment to D76049: [WebAssembly] Support swiftself and swifterror for WebAssembly target.

I think the full diff still has not been uploaded yet; everywhere says "Context not available". Could you use arc diff to upload the diff?

Mar 16 2020, 5:17 AM · Restricted Project
kateinoigakukun updated the diff for D76049: [WebAssembly] Support swiftself and swifterror for WebAssembly target.

Fix typo

Mar 16 2020, 5:17 AM · Restricted Project
kateinoigakukun created D76222: Fix typo.
Mar 16 2020, 5:17 AM · Restricted Project
kateinoigakukun abandoned D76222: Fix typo.
Mar 16 2020, 5:17 AM · Restricted Project

Mar 13 2020

kateinoigakukun added a comment to D76049: [WebAssembly] Support swiftself and swifterror for WebAssembly target.

Here is Swift calling convention docs and there is description about swiftself and swifterror.

Mar 13 2020, 7:26 PM · Restricted Project
kateinoigakukun updated the diff for D76049: [WebAssembly] Support swiftself and swifterror for WebAssembly target.
Mar 13 2020, 7:26 PM · Restricted Project
kateinoigakukun updated the diff for D76049: [WebAssembly] Support swiftself and swifterror for WebAssembly target.
Mar 13 2020, 7:26 PM · Restricted Project
kateinoigakukun updated the diff for D76049: [WebAssembly] Support swiftself and swifterror for WebAssembly target.

Fix english syntax

Mar 13 2020, 9:06 AM · Restricted Project

Mar 12 2020

kateinoigakukun updated the diff for D76049: [WebAssembly] Support swiftself and swifterror for WebAssembly target.

Upload diff using arc

Mar 12 2020, 9:11 PM · Restricted Project
kateinoigakukun updated the diff for D76049: [WebAssembly] Support swiftself and swifterror for WebAssembly target.
Mar 12 2020, 3:03 AM · Restricted Project
kateinoigakukun added reviewers for D76049: [WebAssembly] Support swiftself and swifterror for WebAssembly target: sbc100, sunfish.
Mar 12 2020, 1:36 AM · Restricted Project
kateinoigakukun created D76049: [WebAssembly] Support swiftself and swifterror for WebAssembly target.
Mar 12 2020, 1:36 AM · Restricted Project

Mar 11 2020

kateinoigakukun updated the diff for D74531: [WebAssembly] Emit PCH __clang_ast in custom section.
Mar 11 2020, 9:50 PM · Restricted Project

Feb 20 2020

kateinoigakukun added a comment to D74531: [WebAssembly] Emit PCH __clang_ast in custom section.

My colleague pointed out that one way to archive padding in the binary format would be to create a synthetic custom section that precedes that one you want to align. Its kind of horrible, but wasm files were not designed to used memory mapped like this.

Feb 20 2020, 7:37 PM · Restricted Project
kateinoigakukun added a comment to D74531: [WebAssembly] Emit PCH __clang_ast in custom section.

Could you take a look again?

Feb 20 2020, 4:06 AM · Restricted Project

Feb 17 2020

kateinoigakukun updated the diff for D74531: [WebAssembly] Emit PCH __clang_ast in custom section.
Feb 17 2020, 3:49 PM · Restricted Project

Feb 16 2020

kateinoigakukun added inline comments to D74531: [WebAssembly] Emit PCH __clang_ast in custom section.
Feb 16 2020, 8:43 PM · Restricted Project

Feb 13 2020

kateinoigakukun added reviewers for D74531: [WebAssembly] Emit PCH __clang_ast in custom section: dschuff, uweigand.
Feb 13 2020, 1:44 AM · Restricted Project
kateinoigakukun created D74531: [WebAssembly] Emit PCH __clang_ast in custom section.
Feb 13 2020, 1:44 AM · Restricted Project

Jan 24 2020

kateinoigakukun added a comment to D71823: Support Swift calling convention for WebAssembly targets.

Could you merge this?

Jan 24 2020, 4:26 AM · Restricted Project, Restricted Project

Jan 22 2020

kateinoigakukun added a comment to D71823: Support Swift calling convention for WebAssembly targets.

Sorry we left this dangling for so long. This little change looks fine; I guess you must be in the process of porting swift to wasm? Do you have any more detailed plans for that written down anywhere, or a prototype you can show?

Jan 22 2020, 3:21 PM · Restricted Project, Restricted Project

Jan 11 2020

kateinoigakukun added inline comments to D71823: Support Swift calling convention for WebAssembly targets.
Jan 11 2020, 7:29 PM · Restricted Project, Restricted Project

Jan 10 2020

kateinoigakukun added a reviewer for D71823: Support Swift calling convention for WebAssembly targets: sunfish.
Jan 10 2020, 10:44 PM · Restricted Project, Restricted Project
kateinoigakukun added a reviewer for D71823: Support Swift calling convention for WebAssembly targets: uweigand.
Jan 10 2020, 10:34 PM · Restricted Project, Restricted Project
kateinoigakukun added a reviewer for D71823: Support Swift calling convention for WebAssembly targets: aschwaighofer.
Jan 10 2020, 10:34 PM · Restricted Project, Restricted Project

Dec 22 2019

kateinoigakukun updated the diff for D71823: Support Swift calling convention for WebAssembly targets.
Dec 22 2019, 5:45 PM · Restricted Project, Restricted Project
kateinoigakukun created D71823: Support Swift calling convention for WebAssembly targets.
Dec 22 2019, 5:26 PM · Restricted Project, Restricted Project