Page MenuHomePhabricator

kasper81 (kasper)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 13 2021, 12:24 PM (62 w, 5 d)

Recent Activity

Tue, Sep 20

kasper81 edited reviewers for D132510: [RISCV][LLDB] Add initial SysV ABI support, added: jasonmolenda; removed: tzb99.
Tue, Sep 20, 2:42 AM · Restricted Project, Restricted Project

Mon, Sep 5

kasper81 added a comment to D132510: [RISCV][LLDB] Add initial SysV ABI support.

@jasonmolenda, @Emmmer, any other feedback, or good to merge? i will work on Plugins/Architecture/RISCV, unless someone else beat me to it. :)

Mon, Sep 5, 3:11 PM · Restricted Project, Restricted Project

Aug 26 2022

kasper81 added a comment to D132510: [RISCV][LLDB] Add initial SysV ABI support.

@Emmmer, agreed that automated tests for ABI plugins would be a nice thing to have at some point in the future, but it is out of the scope of this initial bring up for RISCV, as tests are missing for all architectures. Also we need Plugins/Architectureport for RISCV to get the exotic use cases working. So best way is to make individual short patches with fast iterations rather than stuck on one thing for years.

Aug 26 2022, 5:31 PM · Restricted Project, Restricted Project
kasper81 added a comment to D132510: [RISCV][LLDB] Add initial SysV ABI support.

Addressed review feedback.

Aug 26 2022, 11:52 AM · Restricted Project, Restricted Project
kasper81 updated the diff for D132510: [RISCV][LLDB] Add initial SysV ABI support.
Aug 26 2022, 11:50 AM · Restricted Project, Restricted Project
kasper81 updated the diff for D132510: [RISCV][LLDB] Add initial SysV ABI support.
Aug 26 2022, 11:46 AM · Restricted Project, Restricted Project
kasper81 added a comment to D132510: [RISCV][LLDB] Add initial SysV ABI support.

@jasonmolenda. @Emmmer, I've addressed your review feedback. Could you please take another look?

Aug 26 2022, 8:17 AM · Restricted Project, Restricted Project

Aug 24 2022

kasper81 updated the diff for D132510: [RISCV][LLDB] Add initial SysV ABI support.

Added a FIXME comment in CreateDefaultUnwindPlan, based on advice from @jasonmolenda.

Aug 24 2022, 2:15 PM · Restricted Project, Restricted Project
kasper81 added inline comments to D132510: [RISCV][LLDB] Add initial SysV ABI support.
Aug 24 2022, 10:28 AM · Restricted Project, Restricted Project
kasper81 updated the diff for D132510: [RISCV][LLDB] Add initial SysV ABI support.
Aug 24 2022, 6:10 AM · Restricted Project, Restricted Project
kasper81 updated the diff for D132510: [RISCV][LLDB] Add initial SysV ABI support.
Aug 24 2022, 6:04 AM · Restricted Project, Restricted Project
kasper81 added a comment to D132510: [RISCV][LLDB] Add initial SysV ABI support.

@jasonmolenda the problem with original review is that we were waiting for the wholesale support for 3.5 years, and it rendered into an impossible task for the author. I don't want to make this one "all or none" kind of a deal as well. This patch is neither bringing 100% lldb support nor regressing. It is an incremental step forward to unblock a few more scenarios to initialize SysV ABI.

Aug 24 2022, 5:35 AM · Restricted Project, Restricted Project

Aug 23 2022

kasper81 requested review of D132510: [RISCV][LLDB] Add initial SysV ABI support.
Aug 23 2022, 3:35 PM · Restricted Project, Restricted Project

Nov 28 2021

kasper81 added a comment to D62732: [RISCV] Add SystemV ABI.

Hi Luis, are you planning on adding plugin architecture support (in lldb/source/Plugins/Architecture) as part of this work?

Nov 28 2021, 11:30 PM · Restricted Project, Restricted Project

Jul 13 2021

kasper81 added a comment to D62732: [RISCV] Add SystemV ABI.

I think the main blocker for merging was testing. If it helps, I now have the RISC-V server in my hands and I should be able to set up a buildbot soon.

Jul 13 2021, 2:53 PM · Restricted Project, Restricted Project
kasper81 added a comment to D62732: [RISCV] Add SystemV ABI.

Hi, I have my fingers crossed since this request was opened in 2019. It seems like it compiles and usable to certain degree. Can this patch be merged and included in llvm 13 as initial riscv64 support? We can then improve it subsequently if bugs show up. Otherwise it will be one more year of waiting for the consumers. Thank you for your effort!

Jul 13 2021, 12:28 PM · Restricted Project, Restricted Project