Page MenuHomePhabricator

justinstitt (Justin Stitt)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 8 2022, 10:12 AM (8 w, 3 h)

Recent Activity

Aug 11 2022

justinstitt updated the diff for D131532: [Sema] Avoid isNullPointerConstant invocation.

move return to new line, as per clang-format.

Aug 11 2022, 12:49 PM · Restricted Project, Restricted Project
justinstitt requested review of D131699: add arcanist patch.
Aug 11 2022, 10:42 AM · Restricted Project, Restricted Project
justinstitt updated the diff for D131532: [Sema] Avoid isNullPointerConstant invocation.

add more descriptive names, add more detail to revision summary.

Aug 11 2022, 10:25 AM · Restricted Project, Restricted Project

Aug 10 2022

justinstitt updated the diff for D131532: [Sema] Avoid isNullPointerConstant invocation.

use @rtrieu 's suggestion regarding not invoking isNullPointerConstant as opposed to checking for C++ lang opt.

Aug 10 2022, 5:05 PM · Restricted Project, Restricted Project
justinstitt retitled D131532: [Sema] Avoid isNullPointerConstant invocation from [Sema] Only invoke DiagnoseNullConversions for CPlusPlus (-Wnull-conversion) to [Sema] Avoid isNullPointerConstant invocation.
Aug 10 2022, 5:04 PM · Restricted Project, Restricted Project
justinstitt added a reviewer for D131532: [Sema] Avoid isNullPointerConstant invocation: nickdesaulniers.
Aug 10 2022, 9:58 AM · Restricted Project, Restricted Project

Aug 9 2022

justinstitt added a reviewer for D131532: [Sema] Avoid isNullPointerConstant invocation: rtrieu.
Aug 9 2022, 5:01 PM · Restricted Project, Restricted Project
justinstitt requested review of D131532: [Sema] Avoid isNullPointerConstant invocation.
Aug 9 2022, 5:00 PM · Restricted Project, Restricted Project

Aug 8 2022

justinstitt updated the diff for D131416: [Clang][BinaryOperator] memoize ICEKind for BinaryOperator Exprs.

add profile data to commit message

Aug 8 2022, 2:57 PM · Restricted Project, Restricted Project
justinstitt updated the diff for D131416: [Clang][BinaryOperator] memoize ICEKind for BinaryOperator Exprs.

update commit message

Aug 8 2022, 2:56 PM · Restricted Project, Restricted Project
justinstitt abandoned D131447: [Clang][BinaryOperator] memoize ICEKind for BinaryOperator Exprs.
Aug 8 2022, 2:55 PM · Restricted Project, Restricted Project
justinstitt requested review of D131447: [Clang][BinaryOperator] memoize ICEKind for BinaryOperator Exprs.
Aug 8 2022, 2:54 PM · Restricted Project, Restricted Project
justinstitt updated the diff for D131416: [Clang][BinaryOperator] memoize ICEKind for BinaryOperator Exprs.

create getter/setter for optional ICEKind

Aug 8 2022, 2:50 PM · Restricted Project, Restricted Project
justinstitt updated the diff for D131416: [Clang][BinaryOperator] memoize ICEKind for BinaryOperator Exprs.
  • test adding reviewers
Aug 8 2022, 10:41 AM · Restricted Project, Restricted Project
justinstitt requested review of D131416: [Clang][BinaryOperator] memoize ICEKind for BinaryOperator Exprs.
Aug 8 2022, 10:34 AM · Restricted Project, Restricted Project