Page MenuHomePhabricator

justinkb (Paul Mulders)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 19 2019, 5:32 AM (130 w, 6 d)

Recent Activity

Jul 2 2021

justinkb added a comment to D102059: libsanitizer: Guard cyclades inclusion in sanitizer.

I believe it will be part of 12.0.1 already, luckily. Already ported to
release/12.x afaict

Jul 2 2021, 3:24 PM · Restricted Project
justinkb added a comment to D102059: libsanitizer: Guard cyclades inclusion in sanitizer.

Any chance this gets backported to 10, 11? edit: let me rephrase that, if I backport this to 10 and 11, will you merge it?

Jul 2 2021, 2:58 AM · Restricted Project

Nov 22 2019

justinkb added a comment to D60097: Fix implementation of ::abs and std::abs LWG 2192..

This change breaks compilation of firefox with clang and libc++. See https://bugzilla.mozilla.org/show_bug.cgi?id=1594027

Nov 22 2019, 5:29 AM · Restricted Project

Nov 19 2019

justinkb added a comment to D55891: [compiler-rt] [xray] [tests] Detect and handle missing LLVMTestingSupport gracefully.

That sounds like a bug in llvm-config. It shouldn't really return dylib for components that aren't part of it.

Nov 19 2019, 9:20 AM · Restricted Project
justinkb reopened D55891: [compiler-rt] [xray] [tests] Detect and handle missing LLVMTestingSupport gracefully.

The check doesn't work correctly if LLVM is built as a dylib and the LLVMTestingSupport static library isn't installed (which it normally wouldn't be)

Nov 19 2019, 5:53 AM · Restricted Project