Page MenuHomePhabricator

junhee-yoo (Junhee Yoo)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 20 2023, 7:03 PM (10 w, 1 d)

Recent Activity

Mar 27 2023

junhee-yoo added inline comments to D146771: [support] Provide overload to PrintNumber that use C++ types.
Mar 27 2023, 8:39 PM · Restricted Project, Restricted Project

Mar 21 2023

junhee-yoo added a comment to D146492: Add new printNumber() for size_t.

@junhee-yoo you may want to try your code w/ top-of-tree again. looks like someone added some static_cast to those APIs earlier today, so you may no longer have an issue. I didn't even notice that had landed earlier when I proposed changing to uint32_t.

Mar 21 2023, 8:18 PM · Restricted Project, Restricted Project
junhee-yoo added a comment to D146492: Add new printNumber() for size_t.

@junhee-yoo can you try https://reviews.llvm.org/D146544? I think that may be a good solution here, so long as @jhenderson agrees it won't run into problems w/ overflow.

Mar 21 2023, 5:59 PM · Restricted Project, Restricted Project
junhee-yoo added inline comments to D146544: [llvm-readobj][NFC] Replace size_t in HashHistogram with uint32_t.
Mar 21 2023, 5:37 PM · Restricted Project, Restricted Project
junhee-yoo added a comment to D146492: Add new printNumber() for size_t.

@jhenderson Thanks for your kind comment.

Mar 21 2023, 11:16 AM · Restricted Project, Restricted Project
junhee-yoo added a comment to D146492: Add new printNumber() for size_t.

@paulkirth thanks for your kind reply.

Mar 21 2023, 12:14 AM · Restricted Project, Restricted Project

Mar 20 2023

junhee-yoo added a comment to D146492: Add new printNumber() for size_t.

After https://reviews.llvm.org/D137096, I faced compile error:

Mar 20 2023, 8:59 PM · Restricted Project, Restricted Project
junhee-yoo updated the summary of D146492: Add new printNumber() for size_t.
Mar 20 2023, 8:59 PM · Restricted Project, Restricted Project
junhee-yoo updated the summary of D146492: Add new printNumber() for size_t.
Mar 20 2023, 8:37 PM · Restricted Project, Restricted Project
junhee-yoo updated the summary of D146492: Add new printNumber() for size_t.
Mar 20 2023, 7:52 PM · Restricted Project, Restricted Project
junhee-yoo added reviewers for D146492: Add new printNumber() for size_t: jhenderson, paulkirth.
Mar 20 2023, 7:34 PM · Restricted Project, Restricted Project
junhee-yoo updated the summary of D146492: Add new printNumber() for size_t.
Mar 20 2023, 7:33 PM · Restricted Project, Restricted Project
junhee-yoo requested review of D146492: Add new printNumber() for size_t.
Mar 20 2023, 7:31 PM · Restricted Project, Restricted Project