Page MenuHomePhabricator

jtmott-intel (Mott, Jeffrey T)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 8 2020, 10:25 AM (78 w, 23 h)

Recent Activity

Jan 7 2021

jtmott-intel added a comment to D92892: [clang] Change builtin object size to be compatible with GCC when sub-object is invalid.

Seems I don't have commit access. I'll look into it. For now, could someone push this commit? Thanks.

Jan 7 2021, 10:00 AM · Restricted Project

Jan 6 2021

jtmott-intel updated the diff for D92892: [clang] Change builtin object size to be compatible with GCC when sub-object is invalid.

Updated comments to reflect "outside of" instead of "before".

Jan 6 2021, 12:50 PM · Restricted Project

Dec 8 2020

jtmott-intel requested review of D92892: [clang] Change builtin object size to be compatible with GCC when sub-object is invalid.
Dec 8 2020, 3:07 PM · Restricted Project

Sep 1 2020

jtmott-intel added inline comments to D84049: Disable use of _ExtInt with '__atomic' builtins.
Sep 1 2020, 8:20 AM · Restricted Project, Restricted Project

Aug 18 2020

jtmott-intel added a comment to D84049: Disable use of _ExtInt with '__atomic' builtins.

Committed to master, and created bug to cherry pick into 11.0.

Aug 18 2020, 9:30 AM · Restricted Project, Restricted Project
jtmott-intel committed rGca77ab494aa2: Disable use of _ExtInt with '__atomic' builtins (authored by jtmott-intel).
Disable use of _ExtInt with '__atomic' builtins
Aug 18 2020, 9:18 AM
jtmott-intel closed D84049: Disable use of _ExtInt with '__atomic' builtins.
Aug 18 2020, 9:18 AM · Restricted Project, Restricted Project

Aug 14 2020

jtmott-intel added a comment to D84049: Disable use of _ExtInt with '__atomic' builtins.

Great! sounds like this might be resolved to everyone's satisfaction? I'll give this until end of Monday for other comments. cc @jfb

Aug 14 2020, 12:35 PM · Restricted Project, Restricted Project

Aug 11 2020

jtmott-intel updated the diff for D84049: Disable use of _ExtInt with '__atomic' builtins.

@ldionne @jfb Added libcxx test.

Aug 11 2020, 11:41 AM · Restricted Project, Restricted Project

Jul 29 2020

jtmott-intel updated the diff for D84049: Disable use of _ExtInt with '__atomic' builtins.

Modified _Atomic behavior to disallow *all* _ExtInt types of any size, which matches the behavior of __atomic builtins and std::atomic.

Jul 29 2020, 2:49 PM · Restricted Project, Restricted Project
jtmott-intel added a comment to D84049: Disable use of _ExtInt with '__atomic' builtins.

_Atomic appears to already have special logic for _ExtInt in clang::Sema::BuildAtomicType. If _Atomic is used with an _ExtInt whose size is not a power of 2, or whose size is less then 8 bits, then it's disallowed. Those cases already have tests in clang/test/SemaCXX/ext-int.cpp.

Jul 29 2020, 8:17 AM · Restricted Project, Restricted Project

Jul 17 2020

jtmott-intel added a comment to D84049: Disable use of _ExtInt with '__atomic' builtins.

Hi @jfb . This commit it meant to address the concerns raised in https://reviews.llvm.org/D83340 . Thanks!

Jul 17 2020, 1:37 PM · Restricted Project, Restricted Project
jtmott-intel updated the summary of D84049: Disable use of _ExtInt with '__atomic' builtins.
Jul 17 2020, 12:16 PM · Restricted Project, Restricted Project
jtmott-intel updated the diff for D84049: Disable use of _ExtInt with '__atomic' builtins.

Updated diagnostic message. Unless someone suggests something different, I used Erich's message.

Jul 17 2020, 10:18 AM · Restricted Project, Restricted Project
jtmott-intel added a comment to D84049: Disable use of _ExtInt with '__atomic' builtins.

This change is intended to be merged into the release/11 branch.

Jul 17 2020, 9:58 AM · Restricted Project, Restricted Project
jtmott-intel created D84049: Disable use of _ExtInt with '__atomic' builtins.
Jul 17 2020, 9:57 AM · Restricted Project, Restricted Project

Jul 13 2020

jtmott-intel added a comment to D83340: Prohibit use of _ExtInt in atomic intrinsic.

@jfb Ah, I feel I better understand your original question now. Thinking through how we would want __atomics to behave is great, and I'm genuinely glad someone's championing it. It also sounds a *smidgen* beyond the scope of what I was trying to accomplish with this particular patch. :-) This patch doesn't alter the behavior of the __atomic builtins one way or the other. It alters the behavior of the __sync builtins only to change a debug assert failure into a diagnostic error. I believe the _ExtInt authors are tracking new bugs related to that feature. A new bug report could keep the discussion going and keep the issue visible.

Jul 13 2020, 8:56 PM · Restricted Project
jtmott-intel added a comment to D83340: Prohibit use of _ExtInt in atomic intrinsic.

I don't have commit access. For whoever performs the commit, here's a (draft) commit message:

Jul 13 2020, 5:49 PM · Restricted Project
jtmott-intel added a comment to D83340: Prohibit use of _ExtInt in atomic intrinsic.

@erichkeane Assuming we're back to talking about the __sync functions, I get the following diagnostic.

Jul 13 2020, 3:28 PM · Restricted Project
jtmott-intel updated the diff for D83340: Prohibit use of _ExtInt in atomic intrinsic.

Addressed review comments.

Jul 13 2020, 12:38 PM · Restricted Project
jtmott-intel added inline comments to D83340: Prohibit use of _ExtInt in atomic intrinsic.
Jul 13 2020, 11:51 AM · Restricted Project
jtmott-intel added a comment to D83340: Prohibit use of _ExtInt in atomic intrinsic.

@jfb The __atomic builtins seem to round up to the nearest power of 2, and they appear to work because of that. Is there a specific use case or reproducer you were concerned about?

Jul 13 2020, 11:50 AM · Restricted Project

Jul 7 2020

jtmott-intel created D83340: Prohibit use of _ExtInt in atomic intrinsic.
Jul 7 2020, 1:07 PM · Restricted Project

Jun 14 2020

jtmott-intel added a comment to D81420: Fix size for _ExtInt types with builtins.

I don't have commit access. For whoever performs the commit, here's a (draft) commit message:

Jun 14 2020, 2:24 PM · Restricted Project

Jun 12 2020

jtmott-intel added inline comments to D81420: Fix size for _ExtInt types with builtins.
Jun 12 2020, 12:35 PM · Restricted Project
jtmott-intel updated the diff for D81420: Fix size for _ExtInt types with builtins.
  • Removed sign/unsign select.
  • Added test and support for placeholder types in builtins.
Jun 12 2020, 12:35 PM · Restricted Project

Jun 11 2020

jtmott-intel added inline comments to D81420: Fix size for _ExtInt types with builtins.
Jun 11 2020, 10:29 PM · Restricted Project

Jun 10 2020

jtmott-intel added inline comments to D81420: Fix size for _ExtInt types with builtins.
Jun 10 2020, 4:41 PM · Restricted Project
jtmott-intel updated the diff for D81420: Fix size for _ExtInt types with builtins.

This updated patch prepared before John's latest comments.

Jun 10 2020, 4:41 PM · Restricted Project
jtmott-intel added inline comments to D81420: Fix size for _ExtInt types with builtins.
Jun 10 2020, 3:35 PM · Restricted Project

Jun 9 2020

jtmott-intel added inline comments to D81420: Fix size for _ExtInt types with builtins.
Jun 9 2020, 9:29 PM · Restricted Project
jtmott-intel updated the diff for D81420: Fix size for _ExtInt types with builtins.

Limited diagnostic to *signed* _ExtInt, and added test to verify unsigned works.
Reused existing diagnostic message rather than make a new one.

Jun 9 2020, 9:29 PM · Restricted Project
jtmott-intel added inline comments to D81420: Fix size for _ExtInt types with builtins.
Jun 9 2020, 9:19 AM · Restricted Project
jtmott-intel updated the diff for D81420: Fix size for _ExtInt types with builtins.

Updated the diagnostic check and message for 128 rather than 64 bits.
Added sema tests for 128/129 sizes.
Added codegen tests for 127/128 sizes to mul.

Jun 9 2020, 9:19 AM · Restricted Project

Jun 8 2020

jtmott-intel created D81420: Fix size for _ExtInt types with builtins.
Jun 8 2020, 12:41 PM · Restricted Project