Page MenuHomePhabricator

jrkoenig (Jason Koenig)
UserEmail Not Verified

Projects

User does not belong to any projects.

User Details

User Since
Jul 13 2015, 2:35 PM (385 w, 5 h)

Recent Activity

Sep 11 2015

jrkoenig updated the diff for D12822: [MergeFuncs] Simplify the merge process.
  • [MergeFuncs] Simplify the merge process
  • Deferred comparison of callsites
Sep 11 2015, 4:34 PM
jrkoenig retitled D12822: [MergeFuncs] Simplify the merge process from to [MergeFuncs] Simplify the merge process.
Sep 11 2015, 4:30 PM
jrkoenig retitled D12820: [MergeFuncs] Fix bug in merging GetElementPointers from to [MergeFuncs] Fix bug in merging GetElementPointers.
Sep 11 2015, 4:02 PM

Sep 10 2015

jrkoenig updated the diff for D12581: [MergeFuncs] Fix callsite attributes in thunk generation.

Fixed typo and comment order

Sep 10 2015, 10:51 AM

Sep 3 2015

jrkoenig updated the diff for D12581: [MergeFuncs] Fix callsite attributes in thunk generation.

Clarified comment about questionable attribute transfers.

Sep 3 2015, 1:15 PM
jrkoenig added inline comments to D12581: [MergeFuncs] Fix callsite attributes in thunk generation.
Sep 3 2015, 11:25 AM

Sep 2 2015

jrkoenig retitled D12581: [MergeFuncs] Fix callsite attributes in thunk generation from to [MergeFuncs] Fix callsite attributes in thunk generation.
Sep 2 2015, 5:46 PM
jrkoenig added a comment to D12537: [MergeFuncs] Efficiently defer functions on merge.

In r245139, before hashing and the other recent changes, remove() was buggy as well. The problem manifests in all three LTO builds of chromium, mysql, and libxul.

Sep 2 2015, 12:29 PM
jrkoenig updated the diff for D12537: [MergeFuncs] Efficiently defer functions on merge.

Move comments into asserts.

Sep 2 2015, 12:27 PM

Sep 1 2015

jrkoenig added a comment to D12537: [MergeFuncs] Efficiently defer functions on merge.

According to this C++ standard draft/prerelease/whatever, Section 23.2.4, paragraph 9 claims that only the elements erased are invalidated. This is subtle but correct usage. Sounds like I need to add some comments.

Sep 1 2015, 5:08 PM
jrkoenig updated the diff for D12537: [MergeFuncs] Efficiently defer functions on merge.

Clarified invariant linking FnTree and FNodesInTree, use more descriptive
names, and add more comments.

Sep 1 2015, 5:07 PM
jrkoenig retitled D12537: [MergeFuncs] Efficiently defer functions on merge from to [MergeFuncs] Efficiently defer functions on merge.
Sep 1 2015, 11:56 AM

Aug 27 2015

jrkoenig added a comment to D12376: Remove Merge Functions pointer comparisons.

(There is already a test/Transforms/MergeFunc/ranges.ll test in the suite.)

Aug 27 2015, 7:53 PM
jrkoenig updated the diff for D12376: Remove Merge Functions pointer comparisons.

Add multi-segment range test.

Aug 27 2015, 7:52 PM
jrkoenig updated the diff for D12376: Remove Merge Functions pointer comparisons.

Fixed typo & expanded TODO

Aug 27 2015, 4:08 PM
jrkoenig updated the diff for D12376: Remove Merge Functions pointer comparisons.

Fixed range metadata comparison. Cleaned up tests.

Aug 27 2015, 4:05 PM

Aug 26 2015

jrkoenig retitled D12376: Remove Merge Functions pointer comparisons from to Remove Merge Functions pointer comparisons.
Aug 26 2015, 11:45 AM

Aug 25 2015

jrkoenig updated the diff for D12302: Comparing operands should not require the same ValueID.

Split tests into different files.

Aug 25 2015, 2:18 PM
jrkoenig updated the diff for D12302: Comparing operands should not require the same ValueID.

Formatting fixups.

Aug 25 2015, 1:47 PM
jrkoenig updated the diff for D12302: Comparing operands should not require the same ValueID.

Added undef tests; use consistent merge-checking method

Aug 25 2015, 1:44 PM
jrkoenig updated subscribers of D12302: Comparing operands should not require the same ValueID.
Aug 25 2015, 1:32 PM
jrkoenig added inline comments to D12302: Comparing operands should not require the same ValueID.
Aug 25 2015, 1:32 PM
jrkoenig updated the diff for D12302: Comparing operands should not require the same ValueID.

Added more positive/negative tests.

Aug 25 2015, 1:11 PM

Aug 24 2015

jrkoenig retitled D12302: Comparing operands should not require the same ValueID from to Comparing operands should not require the same ValueID.
Aug 24 2015, 4:41 PM

Aug 21 2015

jrkoenig added a comment to D12253: Expose more properties of llvm::fltSemantics.

Actually, it would need to be bool operator<(const fltSemantics &, const fltSemantics &), which is not generally useful. I need to totally order APFloats, not just compare for equality.

Aug 21 2015, 4:23 PM
jrkoenig retitled D12253: Expose more properties of llvm::fltSemantics from to Expose more properties of llvm::fltSemantics.
Aug 21 2015, 4:05 PM
jrkoenig updated the diff for D12168: Improve the determinism of MergeFunctions.

Made test more robust; added comment

Aug 21 2015, 2:31 PM
jrkoenig updated the diff for D12168: Improve the determinism of MergeFunctions.

Forgot a &

Aug 21 2015, 1:42 PM

Aug 20 2015

jrkoenig added inline comments to D12168: Improve the determinism of MergeFunctions.
Aug 20 2015, 4:53 PM
jrkoenig updated the diff for D12168: Improve the determinism of MergeFunctions.

Addressed @jfb's comments.

Aug 20 2015, 4:53 PM

Aug 19 2015

jrkoenig retitled D12168: Improve the determinism of MergeFunctions from to Improve the determinism of MergeFunctions.
Aug 19 2015, 2:59 PM

Aug 18 2015

jrkoenig added inline comments to D11923: Accelerate MergeFunctions with hashing.
Aug 18 2015, 11:14 AM

Aug 13 2015

jrkoenig added a comment to D11923: Accelerate MergeFunctions with hashing.

Any other comments?

Aug 13 2015, 3:21 PM

Aug 12 2015

jrkoenig added a comment to D11923: Accelerate MergeFunctions with hashing.

@jfb The failing test is Transforms/MergeFunc/call-and-invoke-with-ranges.ll. I have included a fix in this patch. This quick fix is to just swap the functions so the CHECK-LABEL directives pick up on the right definitions. The compile is still correct, the test is just not robust enough to see this.

Aug 12 2015, 4:20 PM
jrkoenig updated D11923: Accelerate MergeFunctions with hashing.
Aug 12 2015, 4:17 PM
jrkoenig added a comment to D11923: Accelerate MergeFunctions with hashing.

Updated style issues, etc.

Aug 12 2015, 3:25 PM
jrkoenig updated the diff for D11923: Accelerate MergeFunctions with hashing.

Fix style issues, change hash and test, add comments

Aug 12 2015, 3:19 PM

Aug 11 2015

jrkoenig updated the diff for D11923: Accelerate MergeFunctions with hashing.

Actually use the typedef in client code.

Aug 11 2015, 11:24 AM
jrkoenig updated the diff for D11923: Accelerate MergeFunctions with hashing.

Fix typos, makes typedef for hash value, and fixes issue with signature hashing

Aug 11 2015, 11:12 AM
jrkoenig added a comment to D11923: Accelerate MergeFunctions with hashing.

Mysqld is the name of the server binary, as opposed to the client library or
CLI binary. Timings of just the MergeFunctions pass (average of 4 runs):

Aug 11 2015, 11:01 AM

Aug 10 2015

jrkoenig retitled D11923: Accelerate MergeFunctions with hashing from to Accelerate MergeFunctions with hashing.
Aug 10 2015, 5:26 PM

Aug 3 2015

jrkoenig retitled D11732: Rewrite tail recursion as loop from to Rewrite tail recursion as loop.
Aug 3 2015, 1:14 PM

Jul 15 2015

jrkoenig updated the diff for D11208: Fix mergefunc infinite loop.

Fix variable name case

Jul 15 2015, 10:54 AM

Jul 14 2015

jrkoenig retitled D11208: Fix mergefunc infinite loop from to Fix mergefunc infinite loop.
Jul 14 2015, 5:45 PM