poke @mgorny
That would be awesome to have this merged before the feature freeze (6th of January I believe)

@whitequark don't worry, I don't mind. Thanks. I've updated the diff with requested change. As far as I tested (using opam and llvm-5.0.0), it's working.

Use ${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}${LLVM_VERSION_SUFFIX} directly and put -L before -l.

Can you try the LLVMCore target?

By the way, does anybody have any idea how to fix the get_target_property() called with non-existent target "LLVM". problem ?
Otherwise I can always do like the patch in use in opam right now: replace the lines 71 and 72 with a single line:

list(APPEND ocaml_flags "-lLLVM-${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}${LLVM_VERSION_SUFFIX}")

it just works but it's not really a solid solution it seems.

Wow, I replied to the comments two months ago but it seems that Phabricator made those only visible to me... I was supposed to click on submit at the end of the page or something maybe ? (let's see now)

Can you also backport this commit ? https://github.com/llvm-mirror/llvm/commit/876aa0d1c66ddcb1952d5153b4cb8486d5ac0ecc

Is it possible to backport this to the 5.0 branch ?

Is it possible to backport this to the 5.0 branch ?

Seems fair.

It works well. I updated my pull request.

In D24354#537592, @mgorny wrote:

Is there a reason to use multiple META.* files then? Considering that installing the files in a subdirectory is necessary anyway, I think it might be cleaner to just combine and install one META file for all of them. This will also make the logic simpler since it would be limited to a single flexible installation path with no need to reference parent/subdirectory structure.

Of course, another option is to just make the top directory configurable, and always create 'llvm' in it. I think this is the solution you were proposing, correct?

ocamlfind is looking for a "META" file in subdirectories so META.llvm (for example) is not handled.
META files in the form "META.thing" are handled only in the base directory.

This patch won't work because the META files should be installed in ${OCAML_STDLIB_PATH}.
Otherwise ocamlfind won't be able to locate them. You also have to modify the directory field in the META files accordingly.

Well, I did an opam package with a few patches if you want to know what I'd personally expect: https://github.com/ocaml/opam-repository/pull/7346

Where does the META files are going to be installed ? $LLVM_LIBRARY_DIR/ocaml or $OCAML_INSTALL_PATH ?