Page MenuHomePhabricator

jpakkane (Jussi Pakkanen)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 12 2019, 1:56 PM (18 w, 5 d)

Recent Activity

Oct 2 2019

jpakkane updated the diff for D64671: [clang-tidy] New check: misc-init-local-variables.

Rebased against latest Git master. Didn't see any rebase conflicts, though...

Oct 2 2019, 9:43 AM · Restricted Project

Oct 1 2019

jpakkane added a comment to D64671: [clang-tidy] New check: misc-init-local-variables.

Do you need someone to commit this on your behalf (sorry for not asking that question sooner)?

Oct 1 2019, 11:07 AM · Restricted Project

Sep 29 2019

jpakkane updated the diff for D64671: [clang-tidy] New check: misc-init-local-variables.

Rebased against master to fix a merge conflict in release notes.

Sep 29 2019, 12:05 PM · Restricted Project

Sep 23 2019

jpakkane updated the diff for D64671: [clang-tidy] New check: misc-init-local-variables.

Added MathHeader documentation.

Sep 23 2019, 11:36 AM · Restricted Project

Sep 6 2019

jpakkane updated the diff for D64671: [clang-tidy] New check: misc-init-local-variables.

Ordered doc list alphabetically.

Sep 6 2019, 2:28 PM · Restricted Project
jpakkane added a comment to D64671: [clang-tidy] New check: misc-init-local-variables.

It'll be reasonable to get IncludeStyle default from .clang-format.

Sep 6 2019, 2:15 PM · Restricted Project
jpakkane updated the diff for D64671: [clang-tidy] New check: misc-init-local-variables.

Added documentation. Well, actually just swiped it from abseil-string-find-startswith.

Sep 6 2019, 1:48 PM · Restricted Project

Sep 5 2019

jpakkane updated the diff for D64671: [clang-tidy] New check: misc-init-local-variables.

Fixed issues raised in review.

Sep 5 2019, 1:10 PM · Restricted Project

Sep 3 2019

jpakkane added inline comments to D64671: [clang-tidy] New check: misc-init-local-variables.
Sep 3 2019, 12:21 PM · Restricted Project
jpakkane updated the diff for D64671: [clang-tidy] New check: misc-init-local-variables.

Updated patch as per review comments.

Sep 3 2019, 12:10 PM · Restricted Project

Sep 2 2019

jpakkane added inline comments to D64671: [clang-tidy] New check: misc-init-local-variables.
Sep 2 2019, 2:33 PM · Restricted Project
jpakkane updated the diff for D64671: [clang-tidy] New check: misc-init-local-variables.

Updated to fix review comments. NOTE: detecting the include fix is broken because I could not get it to work.

Sep 2 2019, 2:25 PM · Restricted Project

Aug 29 2019

jpakkane updated the diff for D64671: [clang-tidy] New check: misc-init-local-variables.

Updated patch to remove #include<stdint.h> and the corresponding uint32_t test code snippet.

Aug 29 2019, 12:45 PM · Restricted Project

Aug 25 2019

jpakkane added a comment to D64671: [clang-tidy] New check: misc-init-local-variables.

I used stdint to replicate a real world use case as I'd imagine those types would match this search quite heavily.

Aug 25 2019, 3:44 AM · Restricted Project

Aug 24 2019

jpakkane added a comment to D64671: [clang-tidy] New check: misc-init-local-variables.

Does this still need work? FWICT all issues raised have been fixed.

Aug 24 2019, 3:48 AM · Restricted Project

Jul 31 2019

jpakkane updated the diff for D64671: [clang-tidy] New check: misc-init-local-variables.

Renamed to cppcoreguidelines-init-variables.

Jul 31 2019, 2:11 PM · Restricted Project

Jul 30 2019

jpakkane added a comment to D64671: [clang-tidy] New check: misc-init-local-variables.

A general comment: "misc" is a sort of a heap of checks that otherwise don't have a good home. This one would probably better go to bugprone (or maybe there's a relevant CERT or C++ Core Guidelines rule?).

Jul 30 2019, 5:34 AM · Restricted Project

Jul 19 2019

jpakkane added inline comments to D64671: [clang-tidy] New check: misc-init-local-variables.
Jul 19 2019, 11:11 AM · Restricted Project
jpakkane updated the diff for D64671: [clang-tidy] New check: misc-init-local-variables.

Now properly deals with template instantiations and macros.

Jul 19 2019, 11:10 AM · Restricted Project

Jul 17 2019

jpakkane added inline comments to D64671: [clang-tidy] New check: misc-init-local-variables.
Jul 17 2019, 8:49 AM · Restricted Project

Jul 16 2019

jpakkane added inline comments to D64671: [clang-tidy] New check: misc-init-local-variables.
Jul 16 2019, 2:29 PM · Restricted Project

Jul 15 2019

jpakkane added inline comments to D64671: [clang-tidy] New check: misc-init-local-variables.
Jul 15 2019, 9:50 AM · Restricted Project

Jul 13 2019

jpakkane updated the diff for D64671: [clang-tidy] New check: misc-init-local-variables.

Fix missing spaces in documentation.

Jul 13 2019, 3:13 PM · Restricted Project
jpakkane added inline comments to D64671: [clang-tidy] New check: misc-init-local-variables.
Jul 13 2019, 3:13 PM · Restricted Project
jpakkane updated the diff for D64671: [clang-tidy] New check: misc-init-local-variables.

Fixed issues found in code review.

Jul 13 2019, 3:06 PM · Restricted Project

Jul 12 2019

jpakkane created D64671: [clang-tidy] New check: misc-init-local-variables.
Jul 12 2019, 3:04 PM · Restricted Project