Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

jorgbrown (Jorg Brown)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 20 2018, 1:31 PM (276 w, 5 d)

Recent Activity

Oct 16 2021

jorgbrown added a comment to D70631: Microsoft's floating-point to_chars powered by Ryu and Ryu Printf.

Move the entire to_char floating-point implementation to the dylib

Oct 16 2021, 1:39 PM · Restricted Project

Aug 30 2021

jorgbrown added a comment to D70631: Microsoft's floating-point to_chars powered by Ryu and Ryu Printf.

@ldionne should we enabling floating point support by a CMake configuration option which is ON by default. The tables aren't small and it could add bloat for embedded devices.

Hmm, for now I'd make them available everywhere, and in the future, I'd add a knob if that is deemed useful. I believe that most embedded implementations will dead strip everything away if they don't use it anyways, so that might never be an issue.

Once this is shipped, we'll only be missing from_chars, right? We should be able to use https://github.com/fastfloat/fast_float to do that. We can ask if Daniel Lemire would relicense his code.

Aug 30 2021, 5:36 PM · Restricted Project

Dec 3 2019

jorgbrown added a comment to D70631: Microsoft's floating-point to_chars powered by Ryu and Ryu Printf.

assuming long double is 64 bits is stupid.

Dec 3 2019, 3:05 PM · Restricted Project

Nov 25 2019

jorgbrown added inline comments to D70631: Microsoft's floating-point to_chars powered by Ryu and Ryu Printf.
Nov 25 2019, 4:01 PM · Restricted Project

Nov 4 2019

jorgbrown committed rG586952f4cefd: Optimize std::midpoint for integers (authored by jorgbrown).
Optimize std::midpoint for integers
Nov 4 2019, 7:33 PM
jorgbrown closed D69459: Optimize std::midpoint for integers.
Nov 4 2019, 7:33 PM · Restricted Project

Oct 30 2019

jorgbrown added a comment to D69520: [libc++] Disallow dynamic -> static span conversions.

Thanks also for fixing the return statement of testConversionSpan() in span.pass.cpp

Oct 30 2019, 5:23 PM

Oct 25 2019

jorgbrown abandoned D69460: Optimize std::midpoint for integers.
Oct 25 2019, 9:53 PM
jorgbrown created D69460: Optimize std::midpoint for integers.
Oct 25 2019, 9:50 PM
jorgbrown created D69459: Optimize std::midpoint for integers.
Oct 25 2019, 9:05 PM · Restricted Project

Apr 29 2019

jorgbrown accepted D61272: [llvm-objcopy] Add RISC-V support for -B/-O.
Apr 29 2019, 5:55 PM · Restricted Project